Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <95834174-35c1-bec8-eaef-39518dc8a919@intel.com>
Date:   Fri, 14 Jul 2023 19:14:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH RFC net-next v2 2/7] net: page_pool: place frag_* fields
 in one cacheline
To:     "David S. Miller" <davem@davemloft.net>
CC:     Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        Yunsheng Lin <linyunsheng@huawei.com>,
        Alexander Duyck <alexanderduyck@fb.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230714170853.866018-1-aleksander.lobakin@intel.com>
 <20230714170853.866018-3-aleksander.lobakin@intel.com>
Content-Language: en-US
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230714170853.866018-3-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WG5ZR1Y2Nmc4bWdXQUVmbFBPbnBBL0c3TlhIRnR1UmNEUWFXMTJZZ28zb3Iw?=
 =?utf-8?B?eDRZQW9Id0tvV0F1UFYyNGdHUU03Tm5KVTRKN3liQnltR0pBaDVMMDczTWc1?=
 =?utf-8?B?OVZqR3k3Q3hwWTJQeS8rMWsrRHJ3ajJEdjM1MStNS3BHakROYXBZd3lKaGtH?=
 =?utf-8?B?VFNjVEhsZlJISFlnTmFuZjI5VDVIZEhXZW4yMnJEWDRFQ3U5THNOVVM1dHVV?=
 =?utf-8?B?RUFPSVo1TmI5eTFvbkJaYkF0bFZrVnlsK1lJSFJ0S2RYdmh2YjNMUjJwSzlU?=
 =?utf-8?B?WXJQRVR6dG1ueE1YeXdkeFJpeHNpbUN1OGhzN0FRdmtQN3hWY2ZNSXQ2bU9Y?=
 =?utf-8?B?RHRjeEdTck1ySE80RzRZbWs5WGEvbHpQQzNLc002YXk0NlVnSDdaNkVTSHBF?=
 =?utf-8?B?OFpBQ1N1eGwvSlhVOEJNV0xjSlA5UnVrU3h4MEl1WTFvcldtV0tDU1U0clVp?=
 =?utf-8?B?dnNoMmw5TEVxeEtIbFg2eFVBdmpMaGNNUEh1ZzM3OTJ2VEdNMUZQYmJ5K3l5?=
 =?utf-8?B?RDh0S3NEZFdEandyeDlncm1EeVM3UlUwTDFzbHQzOWdtZWhHUEx6czB5U21u?=
 =?utf-8?B?NVcwRlZ1aEE2KzQ2SFh1NVlYdGo1VUhRL3EwdWE5K2NVb1BkVjdpTWNCbjk5?=
 =?utf-8?B?YVgwT25pRDBRdnAwdlNNL2tOSkgyY1NZVnd1aDRXNHNBKzdYajV5Uk1lNEVy?=
 =?utf-8?B?SkwzVE54bGpCTFFCMkpRY2xLdjBqMnV1WTgzVnNFRDljanJCYnhJME1la2E3?=
 =?utf-8?B?blFxd1Q3R1Z0SVZLYWNYVnAwVnlpbkJaa0xsR3QyRUtoeTc2OXpqSlpNREs5?=
 =?utf-8?B?cXdQS0czMklqOG5xMkZjSFJwMHh5NlJlREdDbitDQUhsUnZCV0YzRXBjTXNI?=
 =?utf-8?B?OXUvNXE2cm8xYmlBU3NLbm14UzVKendzRFNnRk1qN0ZwV09Ya3hCejVSemph?=
 =?utf-8?B?TEUyRWJ3d2wxekcwWFk5MWZuVFZ2TTdqbktobkRkTU4rUXp6QmFKNGFmWS85?=
 =?utf-8?B?QnJBc1VZTGM5bVlGZ0RqdWtqUC9vRlZ6VG1SZHRjR0dqUzRIZTBURGorK3NI?=
 =?utf-8?B?NU9yd25aVThQR0ViOWFQMTNZWDJjSUY5QkRLRjhGSHVndU5WZ2I4VFlVMkpi?=
 =?utf-8?B?WmRNRWlBVXcrMnJXZHdVT056MUFBMDhDdFhXZ3NDRm9NWUpnV3hJN3UrVHY3?=
 =?utf-8?B?MVQ0K3cyV0dKbWlLUlN4YkduK2hLNXllam10SkRuR3poaXJpUDhtS2p4U01w?=
 =?utf-8?B?SXVDK1RycUkxbXRwcnNkL0NjUFRlQlFnRlF4c09YQ0xqNy8xOU1OR2xxRStU?=
 =?utf-8?B?UDQ0STBtQ2pPdmRSRkRiSnJ5R1NpcFZTTU1CVExrTEZJS0NleE9QK2RSLzZB?=
 =?utf-8?B?by9ZdkZtT0JUeVhwRlNubm56a2txTmhPQXZrNGk2SnZ6M2dWTktxOVlrRDdI?=
 =?utf-8?B?OEE5dEg4TlBLMVoybzNUaXlZUnB3aEM0WFZ1OFIwRENPZjI3bW9INGRQRS8z?=
 =?utf-8?B?V3A5eVFnZGdvamJWb1l2TkJzMW9kWUdJL3luVkdqV3Q3aG9DdjFUTXZENDRx?=
 =?utf-8?B?RDF0ZVN6VjM0N3FUQjVwQ0Y5TDBwbmdqSjh3SzZWTkNtMHJNS0NsS2hlRytK?=
 =?utf-8?B?d0VxOWRyM0tUKzcwcFQvU3Jqc25qZTdMWCtWY28vYkVyREdtZEdNd0ZVL3Ji?=
 =?utf-8?B?eWlObSs4YjV0dHpDTW9WVHVtakxmVXZEZmV1aTArU2NKSS95WUlObmVabmw5?=
 =?utf-8?B?M0FXTjhXaWFUcXFrbHpGYmtDN0dhY1N6cm5RMlBOOHcrWk1ZSVhQaHVPcVg1?=
 =?utf-8?B?eGJZOVg1SEtHZ0RhNklyZnBIRHdSRFVqVWRYajFVTXdDWVM5VFRPbkxYNDJs?=
 =?utf-8?B?bnNtU01zZzhmNXpaTk9NbGxGa3l6QTNUSGNhajJkUDc2WUdSZXFaRE9pWUZ4?=
 =?utf-8?B?OXhzRG1oakZxdURUZ3lrN2l2LzJQb2RJb1RmRXhoMEtSK04zclJHeGxvSWpS?=
 =?utf-8?B?aHVVTWxBMzNTTHJCVGFrUHBWQStFQnB0RW41VXVEbDN4UC81SERyVnFzQ09Q?=
 =?utf-8?B?Q291eWRXQ2g2aWtQMXd0cTBCZlNEd1ZEZ3VvUU5rVGUzQk9FOVVTUktmdXdt?=
 =?utf-8?B?Rk5qc1NxeFFDMnRXYVJ1aFpRMWt6RC9XcThsOXNQY0M5REJqVGNrd0ZBZnlw?=
 =?utf-8?B?RVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5bcfca6d-419b-4655-53c5-08db848df549
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 17:15:44.7869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: esIdbyJ0N1lnC80omz/gQXOqDo4JNJcLoBQkVETjnV5XmRLof+zh+QEgklQN4P9h5azGRQ0cMMXa68s/mtsgjPDUSj/6n76x2FdtrZYpvDw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6136
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: Fri, 14 Jul 2023 19:08:45 +0200

> On x86_64, frag_* fields of struct page_pool are scattered across two
> cachelines despite the summary size of 24 bytes. The last field,
> ::frag_users, is pushed out to the next one, sharing it with
> ::alloc_stats.
There are two copies now of #2 and #3 as I reordered them and forgot to
remove obsolete files ._. It's an RFC anyway, so please just ignore the
duplicates. Sorry.

[...]

Thanks,
Olek