Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230707190020.6280-2-vladimir.lypak@gmail.com> <7c4affcb-bcb4-5f4b-cc2f-bed2cad9de71@kontron.de>
In-Reply-To: <7c4affcb-bcb4-5f4b-cc2f-bed2cad9de71@kontron.de>
From:   Dave Stevenson <dave.stevenson@raspberrypi.com>
Date:   Fri, 14 Jul 2023 18:16:47 +0100
Message-ID: <CAPY8ntBWmfDPwPJS_z5tko7PUxHG9pVQ1DOKC3baGDCNzMzykw@mail.gmail.com>
Subject: Re: [PATCH 1/1] drm/bridge: Fix handling of bridges with
 pre_enable_prev_first flag
To:     Frieder Schrempf <frieder.schrempf@kontron.de>
Cc:     Vladimir Lypak <vladimir.lypak@gmail.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Jagan Teki <jagan@amarulasolutions.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Frieder

On Mon, 10 Jul 2023 at 08:46, Frieder Schrempf
<frieder.schrempf@kontron.de> wrote:
>
> On 07.07.23 21:00, Vladimir Lypak wrote:
> > [Sie erhalten nicht h=C3=A4ufig E-Mails von vladimir.lypak@gmail.com. W=
eitere Informationen, warum dies wichtig ist, finden Sie unter https://aka.=
ms/LearnAboutSenderIdentification ]
> >
> > In function drm_atomic_bridge_chain_post_disable handling of
> > pre_enable_prev_first flag is broken because "next" variable will alway=
s
> > end up set to value of "bridge". This breaks loop which should disable
> > bridges in reverse:
> >
> >  next =3D list_next_entry(bridge, chain_node);
> >
> >  if (next->pre_enable_prev_first) {
> >         /* next bridge had requested that prev
> >          * was enabled first, so disabled last
> >          */
> >         limit =3D next;
> >
> >         /* Find the next bridge that has NOT requested
> >          * prev to be enabled first / disabled last
> >          */
> >         list_for_each_entry_from(next, &encoder->bridge_chain,
> >                                  chain_node) {
> > // Next condition is always true. It is likely meant to be inversed
> > // according to comment above. But doing this uncovers another problem:
> > // it won't work if there are few bridges with this flag set at the end=
.
> >                 if (next->pre_enable_prev_first) {
> >                         next =3D list_prev_entry(next, chain_node);
> >                         limit =3D next;
> > // Here we always set next =3D limit =3D branch at first iteration.
> >                         break;
> >                 }
> >         }
> >
> >         /* Call these bridges in reverse order */
> >         list_for_each_entry_from_reverse(next, &encoder->bridge_chain,
> >                                          chain_node) {
> > // This loop never executes past this branch.
> >                 if (next =3D=3D bridge)
> >                         break;
> >
> >                 drm_atomic_bridge_call_post_disable(next, old_state);
> >
> > In this patch logic for handling the flag is simplified. Temporary
> > "iter" variable is introduced instead of "next" which is used only
> > inside inner loops.
> >
> > Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to al=
ter bridge init order")
> > Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
>
> I haven't had a chance to look at this, but I still want to reference
> another patch by Jagan that intends to fix some bug in this area:
>
> https://patchwork.kernel.org/project/dri-devel/patch/20230328170752.11023=
47-1-jagan@amarulasolutions.com/
>
> +Cc: Jagan
>
> Dave, as you introduced this feature, did you have a chance to look at
> Jagan's and Vladimir's patches?

Sorry, they'd fallen off my radar.
I'm having a look at the moment, but will probably need to carry it
over to Monday.

  Dave