Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230713163626.31338-1-jim.cromie@gmail.com> <20230713163626.31338-22-jim.cromie@gmail.com>
 <76995421-a529-ac25-c306-2e4ac2844602@infradead.org>
In-Reply-To: <76995421-a529-ac25-c306-2e4ac2844602@infradead.org>
From:   jim.cromie@gmail.com
Date:   Fri, 14 Jul 2023 11:34:37 -0600
Message-ID: <CAJfuBxyUoVJU13cVxtp01PLfQ1v3PZVWD9vLLR1y+Fiz5Xd66A@mail.gmail.com>
Subject: Re: [PATCH v4 21/21] dyndbg-doc: add classmap info to howto
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     jbaron@akamai.com, daniel.vetter@ffwll.ch,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, jani.nikula@intel.com,
        ville.syrjala@linux.intel.com, seanpaul@chromium.org,
        robdclark@gmail.com, gregkh@linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jul 13, 2023 at 1:13=E2=80=AFPM Randy Dunlap <rdunlap@infradead.org=
> wrote:
>
>
>
> On 7/13/23 09:36, Jim Cromie wrote:
> > Add some basic info on classmap usage and api
> >
> > Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> > ---
> >  .../admin-guide/dynamic-debug-howto.rst       | 64 ++++++++++++++++++-
> >  1 file changed, 63 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Docume=
ntation/admin-guide/dynamic-debug-howto.rst
> > index 8dc668cc1216..878750ce8c1d 100644
> > --- a/Documentation/admin-guide/dynamic-debug-howto.rst
> > +++ b/Documentation/admin-guide/dynamic-debug-howto.rst
>
> > @@ -374,3 +373,66 @@ just a shortcut for ``print_hex_dump(KERN_DEBUG)``=
.
> >  For ``print_hex_dump_debug()``/``print_hex_dump_bytes()``, format stri=
ng is
> >  its ``prefix_str`` argument, if it is constant string; or ``hexdump``
> >  in case ``prefix_str`` is built dynamically.
> > +
> > +Dynamic Debug classmaps
> > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > +
> > +Dyndbg generally selects *prdbg* callsites using structural info:
> > +module, file, function, line.  Using classmaps, user modules can
> > +organize/select pr_debug()s as they like.
> > +
> > +- classes coordinates/spans multiple modules
> > +- complements the mod,file,func attrs
> > +- keeps pr_debug's 0-off-cost JUMP_LABEL goodness
> > +- isolates from other class'd and un-class'd pr_debugs()
> > +  (one doesnt mix 2 clients bank accounts)
>
>           doesn't
>


thanks Randy,
got this, and the rest.