Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2787211rwp; Fri, 14 Jul 2023 11:16:38 -0700 (PDT) X-Google-Smtp-Source: APBJJlFnGi79rRZHVBh1y7NJPKBPAeps2N1dhonx+AkkVvBVpY8gIL0b8DnDUbQ0iK/7QXz/7HIY X-Received: by 2002:a05:6a21:99a6:b0:125:4d74:cd6a with SMTP id ve38-20020a056a2199a600b001254d74cd6amr4415084pzb.3.1689358598070; Fri, 14 Jul 2023 11:16:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689358598; cv=none; d=google.com; s=arc-20160816; b=F2Pp8hTWNBihe6pmJvNwRzYR26phltikLomd2oY6CbIw/OswmynZ2geflDqJab4//p WZubgxlsXp3LKPgC+e51PEsTSTG3BHI46rTrcKaOimMTbv7eobJPHQkGTzpgoRuWiRkN 3hdRPCitOoMfxteeBSmRiTv8MOM9besu72cReIfgu0l+yuNPnHXEmyOkZBgZNo/bOHRS D/KHRj5oWBRf51dP+bCbDQD/8qzZte85hBhLxsKFkbqvfbNhmHLHug/QzZGxILC9e+c6 YzAoDq77l+8nCesG9mdFO7R0pbovGM1f2oNdhvYDp9fmG9Mpycz1RtbUH8yxUHLWlMIc HsNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ElBmMm1ZevyAKtumVID4tVMI+TD8QnK9EnzezYAZC1A=; fh=rD5vFFkWHwqHosTMNEEV/egm2qfMwKe7R6TQq+rHRLw=; b=FhzMucQwJ2+XKZBOiTu6axbnXLUEAUMRHgbn80mFjryI/YSWuEJpYudGX/Yq4XaE2k qnHAkCtSlci42QM++bDxo41LYoLpjZ7PBSckHjy16MrfqXDogBsUqzMRDti+7WP+7vMT BY+diIoNVXRcwNy4u3tDK7dM5/biaC98M0zT+qQee2VarxX1SuwWwkiHh5gmCeVHqcAo bcns+l4Gmo0pvcKd3N1mbGmTGm3K3A13qsoNW4MTpnEmEXkTOOnneXpqMPW22E27DDT3 CiIGMQvd/FXto+s6aQp0nUhzgC/kMxxqg+37CyeJYWq8+n1Jcy3xCrPIgZwIu4bAXR7I mXUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ieee.org header.s=google header.b=Mpdbmrnz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=ieee.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b32-20020a631b60000000b005577fd7efa4si7100130pgm.427.2023.07.14.11.16.26; Fri, 14 Jul 2023 11:16:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ieee.org header.s=google header.b=Mpdbmrnz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=ieee.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236388AbjGNSLX (ORCPT + 99 others); Fri, 14 Jul 2023 14:11:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236309AbjGNSLU (ORCPT ); Fri, 14 Jul 2023 14:11:20 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C13873C34 for ; Fri, 14 Jul 2023 11:10:48 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-7835c92c373so76993139f.0 for ; Fri, 14 Jul 2023 11:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1689358246; x=1691950246; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ElBmMm1ZevyAKtumVID4tVMI+TD8QnK9EnzezYAZC1A=; b=Mpdbmrnz6XIJWmlHQJGoTmuC7D53w+ptxGvR1qzM5rcUr2yuAkawf06rjkPYMTBpFq l6MjPg1ZjnoCWgc8pvFZw+blKr4qxg2V0sQF1H0WVPdY6+DHII+TihuXYaBMer6Ieai0 olDYpMIpFkabUds26CFLUeHKHqIZFPDKt93i0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689358246; x=1691950246; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ElBmMm1ZevyAKtumVID4tVMI+TD8QnK9EnzezYAZC1A=; b=ZIXeSGXP3e8uNj/TGy/V853rylk767uyZ+pHNviNPQURhn5h7KwWj0GOOrO+J1LD9Y Lq1rj1xU59peA3rM2AN59MBP2SxsUsTBa2K2TLW18MnFOpsXVy7XCPswrXX7zVGuc5ds LU9lVOUkm/TwOXwKWD5yQYtJvWQ16PwxCj0ldFffbi7ubSvVkemxEVQz8t98tqGdGT/c 6kVp56U/dsaBLRiOKPhEIT583sPDPnK2qoyeCCm0BU/Z2gGzuCMd956Gf6FkbmzBwpwI Loc1FiSuauriBcds6S8TuFGKnNzAjncQ7Nu2gZlBw8dvcHh7vBdpOzVyIwI0qVAV1A9x Q53Q== X-Gm-Message-State: ABy/qLZMz8v2uFhNlReZIqyyddwqoDyKpPZ+CM5G7ydh+vpaoPi9FaQM ibHLzWr1lnuHBTm4XlMCt8SGvA== X-Received: by 2002:a05:6e02:221e:b0:346:bf9:76fb with SMTP id j30-20020a056e02221e00b003460bf976fbmr2505344ilf.6.1689358246007; Fri, 14 Jul 2023 11:10:46 -0700 (PDT) Received: from [172.22.22.28] (c-98-61-227-136.hsd1.mn.comcast.net. [98.61.227.136]) by smtp.googlemail.com with ESMTPSA id ee14-20020a056638292e00b0042ad6abe0bbsm2820039jab.20.2023.07.14.11.10.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jul 2023 11:10:44 -0700 (PDT) Message-ID: <2af8ba3f-566a-756e-48bf-3e723bc713da@ieee.org> Date: Fri, 14 Jul 2023 13:10:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [greybus-dev] [PATCH] staging: Explicitly include correct DT includes Content-Language: en-US To: Rob Herring , Greg Kroah-Hartman , Vaibhav Hiremath , Johan Hovold , Alex Elder , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Maxime Ripard , Paul Kocialkowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Parthiban Veerasooran , Christian Gromm Cc: devicetree@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org References: <20230714175002.4064428-1-robh@kernel.org> From: Alex Elder In-Reply-To: <20230714175002.4064428-1-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/14/23 12:50 PM, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring For drivers/staging/greybus/arche-platform.c: Acked-by: Alex Elder > --- > drivers/staging/axis-fifo/axis-fifo.c | 6 ++---- > drivers/staging/greybus/arche-platform.c | 1 + . . .