Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2852702rwp; Fri, 14 Jul 2023 12:23:10 -0700 (PDT) X-Google-Smtp-Source: APBJJlEDvIsKaCKU5C16mWojmticYQ0wLLIezzs8+a2e3cwr8vwZ/r2GCKO4hnfTWHaO0BJhQY21 X-Received: by 2002:a17:903:244e:b0:1b8:9b1d:d7f1 with SMTP id l14-20020a170903244e00b001b89b1dd7f1mr4810446pls.47.1689362589859; Fri, 14 Jul 2023 12:23:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689362589; cv=none; d=google.com; s=arc-20160816; b=crbZ+RITFoHAgH2A91zv5Yn1YxF/8HKCv15iKqxCxo5HtD8u62QfZptNfZHEVinGOu SIeOGPfEHVdU5pw6ZM4ugTW+8/ElFgB/8EHgUYe28H5PYuRRMi9W+Mx2LEbQDOGebV64 /MNB8OhRYlFTLYVKjX4JwEa5T+wzgm9gKm7wXahVwckBGpgJrH9PvkenK16pieFubW5A X11l7GDAq7/Pe5EbgX4zCLosL+fjB4ugS0lhyi3fjCGfNsBZi93DCucKTzOS4ETr0itp vz4n1YhgFBIv3tsycUZqO81pwQ8sMtIX5KZriMzHH8iuO7Nc7SCO4Em5pNt/OHQP0b8w BTXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=iJvvs9dOIGayOcerhrBaLhd0TaO38lkSU2S3p/bJwE8=; fh=8ghPFgvVUvoC8oJVlrEGkCBkEisKHRCt1mAa6UO7n7A=; b=T6R0y7Gmhx1U7ilg+gQibchVPwpckfZuKAujfmaZ8VEDKp7/Iq7+KGoMZMscsbJu0O 5g/HMGmTIZ9nFqXVSdwfSSjZb9llQGOeZmqott0ohMIQk+k2gzuRNsTQzXomaxZo6v7m oFLePE03VCIo1kuypNI/wpS7SIf2yp/EUpuZu2A0PYl20KsrIN12Etvvgi509+ndZZFT H9k2k2WUs6jNky7KKFnmX3aQNUDgpNyojTwouRb+SDMI10AfTKLt1RsDeZ3tK2R9FmIJ 92k5GeiUrj6Xio+iUCI5lfjld9oKuVKRzRau5p3AW9RpbxYpMn4JZF/UpYNeROLbU6VO 9RXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=BJInmMfm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b5-20020a170902650500b001b9dda4e1e7si7408852plk.154.2023.07.14.12.22.56; Fri, 14 Jul 2023 12:23:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=BJInmMfm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236503AbjGNSy3 (ORCPT + 99 others); Fri, 14 Jul 2023 14:54:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236439AbjGNSy2 (ORCPT ); Fri, 14 Jul 2023 14:54:28 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06BDA30FC; Fri, 14 Jul 2023 11:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=iJvvs9dOIGayOcerhrBaLhd0TaO38lkSU2S3p/bJwE8=; b=BJInmMfmI+72o4t0/qKzcQD2zi 8VH4rFNHZmk5NRtlCUqYHzlzRFrQLrNhnYi0ym5fM28T+ItwzIDA34QcOw5cTgfdFoDrM4EaI9Is7 G2ckWv6hyIO2QVmNEVCb7B11QeLghcNUOk4p7hCQLvzcvM+qb2gedx42ctNs41OGgiGs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qKNvr-001Nlf-TA; Fri, 14 Jul 2023 20:54:23 +0200 Date: Fri, 14 Jul 2023 20:54:23 +0200 From: Andrew Lunn To: Samin Guo Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Peter Geis , Frank , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Yanhong Wang Subject: Re: [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg Message-ID: <4efd8643-455e-4f7f-b031-a0a02dd65210@lunn.ch> References: <20230714101406.17686-1-samin.guo@starfivetech.com> <20230714101406.17686-2-samin.guo@starfivetech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714101406.17686-2-samin.guo@starfivetech.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + motorcomm,rx-clk-driver-strength: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + drive strength of rx_clk rgmii pad. > + |----------------------------------| > + | rx_clk ds map table | > + |----------------------------------| > + | DS(3b) | wol@1.8v | wol@3.3v | > + |________|_________________________| > + | | current(uA)| current(uA)| > + | 000 | 1200 | 3070 | > + | 001 | 2100 | 4080 | > + | 010 | 2700 | 4370 | > + | 011 | 2910 | 4680 | > + | 100 | 3110 | 5020 | > + | 101 | 3600 | 5450 | > + | 110 | 3970 | 5740 | > + | 111 | 4350 | 6140 | > + |--------|------------|------------| > + enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970, > + 4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ] > + default: 2910 The DS(3b) value is not relevant to the binding. It is a driver detail. So i would not bother listing it. Please add a comment explaining what wol is. Andrew