Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <245f0248-b0ea-fae5-ce1b-6d4414277f36@intel.com>
Date:   Fri, 14 Jul 2023 21:03:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v3 00/15] PCI: Define Intel PCI IDs and use them in
 drivers
Content-Language: en-US
To:     =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>
CC:     <alsa-devel@alsa-project.org>, <linux-pci@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        Hans de Goede <hdegoede@redhat.com>
References: <20230714202457.423866-1-amadeuszx.slawinski@linux.intel.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20230714202457.423866-1-amadeuszx.slawinski@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlVqd21mN3V0cnJHcThFZ1RWeVorQ2pUeGRqNHRQK3NrZ082WEM2cjJsSCtE?=
 =?utf-8?B?L3hGcjNiRy9LVVVjdU9OcGk1TFlTdWVEcVZMU0tXaTAvelpNYllJMmRYbW1z?=
 =?utf-8?B?aE1rV0lVcmNBNTNTZlZScWZJaDhJaUloYXA2N3hwUVhTbWowbHpQSy8wUUdx?=
 =?utf-8?B?aVFQN3VEWDU4dC9TTFVHOWRSb2F0cSttMTI5N3o2WWxMVkNpVzc3NE0zc1B0?=
 =?utf-8?B?TEMwbCtFUjhvYlZkOTFQMHV0a2tVRXJ3TTA4T3NGcXc5Q29JWVp1dThQZVJQ?=
 =?utf-8?B?M1VKVDc2NjlwV256UFI1RWhGWk5zWm5sT0F4NDc0WHNINDZXOFplY0NVaVVD?=
 =?utf-8?B?ZTdmK1VxUFZWcEt4aFl0TVRUZnh6WEw0cU5yMWswZHhrQSsxU1d6djcxU0xv?=
 =?utf-8?B?ZWFEazFSeFlKbFl4U0ZxMzlVbXpXNm5MY0hVblFSVXR6Tmd2OG1wMDBPcnZz?=
 =?utf-8?B?MGIrOWUzWlJ2aXl6bk84QjlGV1J6SWtmRW0vRWNTcmZkNkJsbnlITkFEZElE?=
 =?utf-8?B?N3IvZ3RDbW50UzI0bGZCZVFmb3FrSDlPWmtIVlUzWUZxRjhEZlNSN3ZaM1RS?=
 =?utf-8?B?MThKYjRyRXRSMlFLd0lJdXNFYktFZDFHZW5EVm9XbDl4c3E4ME41dVMrQWx0?=
 =?utf-8?B?ZFkxRmtvc2ZsK2xPdG94L0pIaktEZ1I1UUxUWlEwelp2U1NvMzIwMm94aWxU?=
 =?utf-8?B?T3I0OFFoUXNMcHhDdCtZQStUVFIrNitPYndKZFpvM3JzbXU5K04zYmhTWVJx?=
 =?utf-8?B?UjFYdytuUVUycFphR3JJU1piUllYa3gvSklxcUlnb2syN3FRUTRPV3ZLNFZC?=
 =?utf-8?B?clA5VUNFSGY0aTQ2TVlOTm1OYUUyL00zcjhEdGxnUVFXK2VZOUF4d2tzSFJP?=
 =?utf-8?B?QmhlL0pnZk1kbURNUGI2cHBFakZBY3VhZTk1VDFjemtuMUhIWklVc0thZ2t3?=
 =?utf-8?B?Y3hsNVp3VldESWZ1NEVJdDVJQ0pBWlNtOU1YSjFFUFVQZjZyU2xwMFhYV04v?=
 =?utf-8?B?MElpU1lITHhaYmJEMTNiVjZZWnhDN1NiMEpkLzhneTNUeVl1WHBRZ3cxM3Zn?=
 =?utf-8?B?NVdUd3BBdWxOUXhYUGRjeUVLeU1GL3lrU08xTUV1eHpsOHhpTnI4MEdsV0Vp?=
 =?utf-8?B?L1h0MTduUUJtVXdaa25heEh5ZGwvS2NDZVh3ekN2QWRyNW9xYlZTcGJtTmR2?=
 =?utf-8?B?WTA4andSa2cyWkFGUmZWeXduZ0FMajVoWWF5T3htYU9ERUxkVjUySWNrY0kw?=
 =?utf-8?B?SkljWlJ6Z3g0ZC9KY2wwbjVTY1NncUZLaG84ZzVINURsT0FPU0M1QVpPQzg0?=
 =?utf-8?B?NGJLTExBdkp6U2dYU283SzdpL00zcGp1LzZ1cWxnc3FxRFFobHoraHZ4Z25l?=
 =?utf-8?B?WW1vWWsvNUsxbU5ZdjRSYXQzQVI3Qnl1NUlkZDJhNTVvSzlzUUFQWjF6QUt3?=
 =?utf-8?B?TC9uV2ZCc0pySW5MTTVNWmgzMFQrOGNobC82U1lKZXRVeFZsaEJFVlNLaFAv?=
 =?utf-8?B?d29xaG1PNkdMSThJMzZXdEhReStJbWhONkc1UjdRc3dvNVlVR3dYdVE2bkNw?=
 =?utf-8?B?QWhaZGgyTlRSUmtOWUphTG5UdUExOHlIWFB2NUVpL2tYQlVsL1E5MnRFWUw3?=
 =?utf-8?B?QlNFQXJCcU51S1FqRC9iN2plN0gzUnJjVEtuZUVZYS9ZTDkxdjdYV1pScmVR?=
 =?utf-8?B?WW9uMExYNTlEZ2VCbFdvT2s0dTRWMWVXcFZwa1NURmtHZE14cHlWbjB0US9I?=
 =?utf-8?B?d0FTbjZsNkNFaGRscmYvVHkwU2pFV2RCZ2NvQnkxcDFxSzZYdGlNQWFMd09R?=
 =?utf-8?B?KzZnUTlsSDZUN0NuUmlXMlRNN3dxdFhQUDVKaE5hU1VBaExBcndSOVJkdmR1?=
 =?utf-8?B?STlkb2I0cjRROGRqNkl1MzRWcXdTNVN4L2NkNkZiUmtqeVZoYzAxTEVPVGht?=
 =?utf-8?B?R2Q4TFk0dml5R25kVEluTmVrNGxRWlB0c09ZNzNZSnJZOWw4WkdJOFU4Y0xp?=
 =?utf-8?B?d1V6V2E5RnRiNXd4U2c2Mm13WmJhV2RFdmJia2tRcExRYkVBOUZ6TjdSRXVS?=
 =?utf-8?B?MmNQVldXV2dweHdnMWY2anZxaFJBQkxEYWhjS2xaSmJvM2MzQkJ5eW1rMlJC?=
 =?utf-8?B?eWFQSFhYblpRc2VDTmdTcnlCM2ZqK2Y3cXZldHVKQVNNYk9UaFllUG5ZM3dw?=
 =?utf-8?B?ZWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bde0426-2eee-4e1f-0346-08db849d1628
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 19:04:02.2410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J4utCn5CxV80mZ427R2ZCpAzczwOqg1FP9up15cuDOAgpfGZcWFwl/XyJrhNMvrtLjwMqtxMbT94TC6l0qU3AOPL/3q34YIB0oUTpyb3B1M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8038
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-07-14 10:24 PM, Amadeusz Sławiński wrote:
> PCI IDs for Intel HDA are duplicated across quite a few drivers, due to
> various configurations and historical reasons. Currently almost all uses
> of HDA PCI IDs have corresponding comment telling which platform it is.
> Additionally there are some inconsistencies between drivers about which
> ID corresponds to which device.
> 
> Simplify things, by adding PCI IDs to global header and make use of them
> in drivers. This allows for removal of comments by having IDs themselves
> being self explanatory. Additionally it allows for removal of existing
> inconsistencies by having one source of truth.

...

> Amadeusz Sławiński (15):
>    PCI: Sort Intel PCI IDs by number
>    PCI: Add Intel Audio DSP devices to pci_ids.h
>    ASoC: SOF: Remove unused Broxton PCI ID
>    ALSA: Remove unused Broxton PCI ID
>    ALSA: hda: Add controller matching macros
>    ALSA: hda: Use global PCI match macro
>    ALSA: hda/i915:  Use global PCI match macro
>    ASoC: Intel: Skylake: Use global PCI match macro
>    ALSA: intel-dsp-config: Convert to PCI device IDs defines
>    ALSA: hda: Convert to PCI device IDs defines
>    ASoC: Intel: avs: Convert to PCI device IDs defines
>    ASoC: Intel: avs: Convert to PCI device IDs defines
>    ASoC: Intel: Skylake: Convert to PCI device IDs defines
>    ASoC: SOF: Intel: Convert to PCI device IDs defines
>    ASoC: Intel: sst: Convert to PCI device IDs defines

Given the amount of talks we have had internally regarding this subject, 
to my best knowledge series looks good:

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>

Great initiative Amadeo and, good job.