Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2881943rwp; Fri, 14 Jul 2023 12:59:10 -0700 (PDT) X-Google-Smtp-Source: APBJJlHtigx8K1Qh+abiMVo5sUsUQuhABiOsUhRIvqDJOen272kyBZHs5V8EjgYVLBwHFtKU7Grq X-Received: by 2002:a17:902:d2c5:b0:1b7:d0b3:1678 with SMTP id n5-20020a170902d2c500b001b7d0b31678mr4605590plc.17.1689364750439; Fri, 14 Jul 2023 12:59:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689364750; cv=none; d=google.com; s=arc-20160816; b=sXsmcoimirRHyZNXCMoBGuD18A0PR8B/Yhnqf/8e9yQTldOggD0MBUq8qZti0UjTuP bwMYQmhTufpbyfatFx/8gjqOj3WmG8hFB5nC8IHRdeRIRXO/EkMyRaALdsts94d7iqmn JmE+dXtJCIMO5AIz5M2vgvACPiJtEKYAvoCHE/+SK6YDuz+I5w01Mn/OjN65zHBZRmFs YgHIT5RJH9EqWh0fGLYFtUQJjlCw8/QLVu1AClzg83Rufmsmb/ESV9WYGmJUSQph+1mD bFt8L06c8D5QInGBRr9lJTPKzO5QzfaZNQCOPNTjzNPbN6vyPSFKMYCsZh3upOqkhHOv Kc+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Ui/hYqp1kWYkMnWgauwkUhdMp+tW3fV5QNxGKFBzBho=; fh=JrnZ8l7HFAve7jVei8WcewuHFsb2sPAsEJ24O0c9gZg=; b=jqQAJThNbIPQ1biTohELyARapod57WKNR9qpMCZxOgR2zIiFZq65+F2KJGArq6V89Z 6pPge7ia44khKLKnObruBGVn0AlEEKRMZtCJvtjXRGxzfdF/odleMpvFuRyGZTsxbUf6 oE2PnccZIpCgrwOgggcil6PvNcf2axImsrQSZsWkHwqcjzM6T/dGcjzWUZS0ve8gpdz1 7GAhbVG/V1nIzQMY6Od/eFf+K85TQM3XtIz8zm3ctfaLTGoccrSkpj17+I83rBb7Zsnw oB1pS3W8vid4feVVgV3ihnXrz1pKiTa+qfYXVAi1sQZjic63FIXhTZPAeuzGPykyZY0n DB3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ega7w8Kg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kn12-20020a170903078c00b001b9c992945fsi7095733plb.555.2023.07.14.12.58.58; Fri, 14 Jul 2023 12:59:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ega7w8Kg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236408AbjGNTgN (ORCPT + 99 others); Fri, 14 Jul 2023 15:36:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235705AbjGNTgM (ORCPT ); Fri, 14 Jul 2023 15:36:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FC1612D; Fri, 14 Jul 2023 12:36:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3493C61DDB; Fri, 14 Jul 2023 19:36:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F33BC433C7; Fri, 14 Jul 2023 19:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689363370; bh=Cysarz/hhMo/bK+dPUbL3TWMzv7sx9BTXTOdSSRZeOw=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=ega7w8KgFJ16HD1GYoX1h4GiocZpQVQFvGcEGonZbz750+cvVJnS222Rs1NkYmeur FBlGhqgX+LkX6K1+6UT6Ynqb4157JHvh8IdnFy05pscRhGgf+h0vDoheEQjAPG6xGL 1DeTwrWjuxaWJKnSrSX9v70q6KjMdeenBZxKanBPFnjuNk8u973+Z6IrexuiSj5N3H GsuJIC2hlA5j8tRu5QZSp/PxlVMMBIN0B28okP9XI4NnfjEzDsM5Lmhanpfr4kMCvR 2nJkQvIk4LCEpZsjDK8H3AQAXnq7vygyZC3ndShkjhwx/uKDAtTObQSXew1oI61EF7 EcQ/INrDH3TGA== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 2DFB8CE009F; Fri, 14 Jul 2023 12:36:10 -0700 (PDT) Date: Fri, 14 Jul 2023 12:36:10 -0700 From: "Paul E. McKenney" To: Sandeep Dhavale Cc: Alan Huang , Joel Fernandes , Gao Xiang , Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Matthias Brugger , AngeloGioacchino Del Regno , linux-erofs@lists.ozlabs.org, xiang@kernel.org, Will Shiu , kernel-team@android.com, rcu@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v1] rcu: Fix and improve RCU read lock checks when !CONFIG_DEBUG_LOCK_ALLOC Message-ID: Reply-To: paulmck@kernel.org References: <894a3b64-a369-7bc6-c8a8-0910843cc587@linux.alibaba.com> <58b661d0-0ebb-4b45-a10d-c5927fb791cd@paulmck-laptop> <7d433fac-a62d-4e81-b8e5-57cf5f2d1d55@paulmck-laptop> <6E5326AD-9A5D-4570-906A-BDE8257B6F0C@gmail.com> <453bcbbd-94f4-46da-98f6-c9fa5f931231@paulmck-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2023 at 12:15:23PM -0700, Sandeep Dhavale wrote: > > > > Sandeep, thoughts? > > > I prefer to modify erofs check and contain the fix there as erofs > cares about it and it's > least invasive. For contexts where erofs cannot tell for sure, it will > always schedule kworker > (like CONFIG_PREEMPT_COUNT=n). > > I will also do measurements to see if erofs should continue to check > for context and > what are the benefits. At the end of the day, I guess it is Gao Xiang's and Chao Yu's decision. Thanx, Paul