Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230714-spi-nor-winbond-w25q128-v3-1-bdb2192f079b@linaro.org> <a5dd9f7d14c94c9be99c93b9475683bf@walle.cc>
In-Reply-To: <a5dd9f7d14c94c9be99c93b9475683bf@walle.cc>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Fri, 14 Jul 2023 22:11:21 +0200
Message-ID: <CACRpkdYWEtHsTRwCYNt7sNtMfs39wKgP8CeuW4cp6VZ+F_y6dQ@mail.gmail.com>
Subject: Re: [PATCH v3] mtd: spi-nor: Correct flags for Winbond w25q128
To:     Michael Walle <michael@walle.cc>
Cc:     Tudor Ambarus <tudor.ambarus@linaro.org>,
        Pratyush Yadav <pratyush@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jul 14, 2023 at 9:30=E2=80=AFPM Michael Walle <michael@walle.cc> wr=
ote:
> Am 2023-07-14 20:29, schrieb Linus Walleij:

> > The Winbond "w25q128" (actual vendor name W25Q128JV) has
> > exactly the same flags as the sibling device "w25q128jv".
> > The devices both require unlocking to enable write access.
> >
> > The actual product naming between devices vs the Linux
> > strings in winbond.c:
> >
> > 0xef4018: "w25q128"   W25Q128JV-IM/JM
> > 0xef7018: "w25q128jv" W25Q128JV-IN/IQ/JQ
>
> This is still wrong btw. According to:
> https://www.winbond.com/resource-files/W25Q128JV%20RevI%2008232021%20Plus=
.pdf
>
> This should be
> 0xef4018: "w25q128"   W25Q128JV-IN/IQ/JQ
> 0xef7018: "w25q128jv" W25Q128JV-IM/JM
>
> Otherwise, looks good. Either Tudor can change that in
> place while picking up the patch or you could send a new
> version.

Ooops you're right, I'll just pick up your tag and re-send,
sorry!

Yours,
Linus Walleij