Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2987417rwp; Fri, 14 Jul 2023 15:07:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlGb33OelUQa3Bv9kbWI1EXKYIkZL8mCrQJq83Q/7wYtcdcD0dCMvhTUqIheMH4s//lEA/WX X-Received: by 2002:aa7:d855:0:b0:51e:3bb0:aa4e with SMTP id f21-20020aa7d855000000b0051e3bb0aa4emr5564597eds.15.1689372454423; Fri, 14 Jul 2023 15:07:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689372454; cv=none; d=google.com; s=arc-20160816; b=B/tB6pJ2o59ts0BENUFzMB03uPSoRPKrzU9m5D68Loe/SYIgUzfu92o5kLaa9URr/J abZr7GHBBefL346thmIy1HbdpjP/E/xlZZdP+73gY1OXmqxN/KBfK2jmpeNNNce1mpMv YSEAaYimK7WqMUkcvik0abmc3MD/pWvWuOapsiOiyyn22MZOPmJ/buRujAzyOtrf1zj0 dLNty1IwBkl+u9clpduHNACyVQYDHf+BUdTjZn6LUFQSObENynBSVw3SPBLSqShx2/bs 7XZ6+dUG3tMoeWqlDXSI8gC+F1+rEUumR7iZ1R9QFlDn7nOHl1oETY7uy/Z9BJMstlmJ Uqow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=8Hxo+RkWpN14XLiWcgexFQoX59W2A8cV2w6hOlqdXYc=; fh=NJ2nHj4NeEk1rpKoPkwE0e/ThqHTKKo/QmdEutQRUy4=; b=v4Fm4aKKaThTFz7NXJFM9v4GvyBN1AwRhJ/TJ/gi6iT8cr4gjtf8uPtZw95htmWVQQ /fomfkfk3/N048WAtHUGHvsTFQ+m8IGN4SpoJS9a1fPgUeIICH7INIF4Em8j+gFInmri jdu+bVni02sY2/SAdE8M4p/bnMT3Qv/ejPngJ8NO2AaWrd+8+Tr6PbUjudMRdE5ESTj7 6FP6o81mOVd1wRwcjrU8pDKrx928MZRtsniTnGerjd14ibqtL0YVGA+8ROFfCmcWRaiw 3vkmv0AlG1rzzdasIxUKV14CQ317F8DxPTDL6wFx0YRz3J4TeKGGeCZxwef32G0Rju6f RlGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VNfjDqnf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k19-20020aa7c393000000b0051e2cc05ba9si9961058edq.306.2023.07.14.15.07.09; Fri, 14 Jul 2023 15:07:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VNfjDqnf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbjGNVwI (ORCPT + 99 others); Fri, 14 Jul 2023 17:52:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjGNVwG (ORCPT ); Fri, 14 Jul 2023 17:52:06 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20A9235A6 for ; Fri, 14 Jul 2023 14:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689371478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8Hxo+RkWpN14XLiWcgexFQoX59W2A8cV2w6hOlqdXYc=; b=VNfjDqnfrBrNxOPVNlhYQ/vf+n6J7yYF0K3x74avT6yvpyjf7GI0qxae3PZskDldFJvzSC XkCdCNaqCIjTj4CecIB0jbGSWEICUaYEEdtdv0PzrVhxFZRr7UW+mT45vrxW3ZGNILCgU3 fOtWsFfblAWGmLMzLdBTvSnYNAzSzFc= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-UsYhiLZYOeqe-HaEq60pkA-1; Fri, 14 Jul 2023 17:51:16 -0400 X-MC-Unique: UsYhiLZYOeqe-HaEq60pkA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-635325b87c9so23806966d6.1 for ; Fri, 14 Jul 2023 14:51:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689371476; x=1691963476; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Hxo+RkWpN14XLiWcgexFQoX59W2A8cV2w6hOlqdXYc=; b=LDEL9bUPpez6FUy3MxnE2PZWJMhTPBbUKUezG6pdwxXDHctpSjRfMiRMeexJtuq0qX sFNJYHpZtvxrj+OU6Lr6A9+Ayeik2aq2+bPwbFRZxY9AcYzREONTjpHqWr90D5YEjI+b t2ROGRcKw0JrhSWipVWl03xLM2haWeqpVia8Na3kF6QXpM9aYIVpNgrLiU1uS6pbyf7c e4YAnnwaCyyR1tYgofOJXWMh8J+wB9zfmMpm4TlJhJNcjGa8sHZSUAkIyInFAE/IzwoA aidvriF9d8wDpU7+vFD1BEmJ2gQeZu7CH6ppVzA/dnT2oKizCjH2ac1dE7x2AfSy+vFp 5pwA== X-Gm-Message-State: ABy/qLYH1BeMu1N2Yj/lHs1W0FUJw10lXGwLX+S68Rzck2rha0uzya4a 2nFob+riWAVhLRcHRSh+bWTBUAETBZCn109sakBHc7uf63cH1LGwQ0LYrpQa9rjNJVXgaqTPZH/ wPxTWyrJ/hx1PfWVaFRvfIbcO+peUctKI X-Received: by 2002:a0c:f452:0:b0:635:e209:178c with SMTP id h18-20020a0cf452000000b00635e209178cmr5074117qvm.10.1689371476121; Fri, 14 Jul 2023 14:51:16 -0700 (PDT) X-Received: by 2002:a0c:f452:0:b0:635:e209:178c with SMTP id h18-20020a0cf452000000b00635e209178cmr5074111qvm.10.1689371475858; Fri, 14 Jul 2023 14:51:15 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id t10-20020a0c8d8a000000b00626362f1bf1sm4276508qvb.63.2023.07.14.14.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 14:51:15 -0700 (PDT) From: Tom Rix To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static Date: Fri, 14 Jul 2023 17:51:13 -0400 Message-Id: <20230714215113.3919026-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org smatch reports mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty' was not declared. Should it be static? mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info' was not declared. Should it be static? These variables are only used in their defining file, so it should be static. Signed-off-by: Tom Rix --- mm/shmem_quota.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/shmem_quota.c b/mm/shmem_quota.c index e349c0901bce..062d1c1097ae 100644 --- a/mm/shmem_quota.c +++ b/mm/shmem_quota.c @@ -315,12 +315,12 @@ static int shmem_release_dquot(struct dquot *dquot) return 0; } -int shmem_mark_dquot_dirty(struct dquot *dquot) +static int shmem_mark_dquot_dirty(struct dquot *dquot) { return 0; } -int shmem_dquot_write_info(struct super_block *sb, int type) +static int shmem_dquot_write_info(struct super_block *sb, int type) { return 0; } -- 2.27.0