Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e051f7f9-3d51-e45c-f8d4-e3700d68aa92@intel.com>
Date:   Fri, 14 Jul 2023 14:53:38 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v5 6/8] x86/resctrl: Display CLOSID and RMID for the
 resctrl groups
Content-Language: en-US
To:     <babu.moger@amd.com>, <corbet@lwn.net>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <168564586603.527584.10518315376465080920.stgit@bmoger-ubuntu>
 <168564611100.527584.7981937236207103115.stgit@bmoger-ubuntu>
 <94694f76-62e0-3751-3791-936db8b7e3ce@intel.com>
 <f443880e-fad7-b61e-e832-3cd180ad3a33@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <f443880e-fad7-b61e-e832-3cd180ad3a33@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkk0WUovKzhUY1BpLzZEVC9zZG9JRDVRYlBoQkpMUExkamdOUVdsc2RDTzZN?=
 =?utf-8?B?YUtsUTNMZGRlc04vUmgyaVZLcEZMSk1LdCtyY2E1NFFkQS9WUFl0Z3lhYUFx?=
 =?utf-8?B?dll3OG1MSEVtTVBqRkdZeUk4LzZBY1RiSFlDZ2tWQmRKZ1JOSUNKcE1pZDJl?=
 =?utf-8?B?bVpQYjVSSlpSZ1FjbVpGSXRxQUNTbHBERkJCdWZmVGZZcnYvVWh2ekVHUXF5?=
 =?utf-8?B?MDkrMUlsM3pWMmVVN01jZkR5RnQ1RVYzSFYzc2NzWmlxa1dWQVVCY1IrVVor?=
 =?utf-8?B?cWhORDhhaWNVOExZL3dHR3RzTVNJUHlzbUhEQ3hmQkkrNWpRVEJvR3U1V3Bq?=
 =?utf-8?B?RkVGYzJFMy8yekx5dEwweHR1OWNoL2FNSEJzOXMvSGZSSGJWWUprMnRBMUNT?=
 =?utf-8?B?bThxT0FCSHNVaU5aUVJBK2JPY2cwaHE2aDZ3cjFwRGd2ZDFDM2MzQzloQlVF?=
 =?utf-8?B?MCsrckFuVDJ4UjdkQWRGQkhnSjVJOEtZOGdUOEFGZ2twelo5RGMvRjRETkda?=
 =?utf-8?B?RS9DWnZYb29YdTF6WjlscE1ISXpXZzlEdklFUzdMMlg1bjBHNWp1SjYxZUlo?=
 =?utf-8?B?WEtIeUFKeU9xZmxGOXpjZWlUYTg2dUxCT0k3SDY5dmpka3BhOUR2dWIzSlQ2?=
 =?utf-8?B?dnlQUWR3M09vWUlUN3AyZ0dkcnRDTVZVNXF1WDA4MExlNG85YlFGQ2ZwRmJF?=
 =?utf-8?B?OXhsTzV3ejF4b2NLN25EcDhhRVRFUHZsMmM3SklGTUY2N09WdmZqQ2p3N3Yr?=
 =?utf-8?B?UmRDWUZtUVoxT2M2K3NkQU1odWdsUllSOVB1T0pVb1pZZzBJbHZrQWRrTjU5?=
 =?utf-8?B?VjRZUERZN3J3dnIxUGxYMWtjVldWaExUVUhZcUluYUV3eklXYVNxWnhETThx?=
 =?utf-8?B?SHFEbWJMdDcwcStXWjRvYVZkWE8yNWZlb1ZFZmZOVFJDMDlGZFVzMVdWUWdV?=
 =?utf-8?B?QlJUaGZlNE93SnM0TEN4TTU5M1p1NEtCRHI5eHVwMTFncXdJOGtLYnd5c1Jv?=
 =?utf-8?B?Y0I0NW1YSjR4dXNzK2Y0aDBReitXcU13ZzBhRldHSXo3ano1VHByYnBMbDdx?=
 =?utf-8?B?aHB4THBWZnJhY2pEcTM5VzgvZ2hlaVZjcVFyQ0dTNHo2ak5maGE0RUFIV2x6?=
 =?utf-8?B?TVBDRzViSW9jQVIrak1ITzRqQmxJcWtjK3pOWVZrQm9vWlV6bW50U1I2QnA0?=
 =?utf-8?B?L0dFYW1LZ09lcGowVVBSWVZKalBKbHQ4cXJCY0E4d1ZhMTVLVityNmwwWVE5?=
 =?utf-8?B?Y1FQTHNDWTNpaHkyK3d2Z1hNRzFQSzJNd3BWOUxUZ3A5M1haQ1dvRHMzL21G?=
 =?utf-8?B?Mk1QeEZFZVAvUUJ4OUxMOEZNQWcxSDNVM0poOVJTMTNFZGtMbmpCNHAyM0g4?=
 =?utf-8?B?di9lQ0dzSGVPS1psQ2swL2pFVUpvSzMrVWpwbVVFSktQOW13MGdBeERiemRD?=
 =?utf-8?B?MHlQL0hvUXkxNzJtYTg1RDBydUtkc29OV3lSbTdIR0tNYURGVVcyNXlVNUs1?=
 =?utf-8?B?NkZNMGQzdG9QUk4ySDZ3VlBMQXBaUEI2ODZGcHFtcE5ET2d1OTJZdHQ5SnJY?=
 =?utf-8?B?bGx1YkVkVkhJOElndm5JSitHWUJVcHRRK3UxZWp3YmFJZHBieUY2RzB4QnQ5?=
 =?utf-8?B?SFZPcElMdHgzOEVvaU1ZWERZVVZZTzlGR3RSUFkrbzc1TUJBYUlZYzZUbiti?=
 =?utf-8?B?WGExazh5R1F5OEVIK3RTMG5qdjZRUzVsWjJKYUlCdkxrbStRSks5Nm1oRGtI?=
 =?utf-8?B?eW9nRkpHNTMxRUlhM2MrZlJFQmpVMktzNktaK2JlSnBLSVlseGdrb1ljUTdO?=
 =?utf-8?B?b1VneitXWkRROGJnZVU3UlBhVFovMjkwNnNwVGtWMnV4L3phODY2UHk4RVFx?=
 =?utf-8?B?d2p2SDFzSDRpbDdtWjFWU21rSjFZQ2RlaUtqWk53UVQvODZYb2tGdWtjeEVa?=
 =?utf-8?B?MkxDYmpMaEVFZzRlcXZJQWFYQ0N5MjI1cHJ4cnEwQS82bHA0ZzErWjhiRW9p?=
 =?utf-8?B?ZVRZYjVLVFhHYjJXdVh1amgxV2Q1OXZVdnRIY0p5emUxanVMQklzenQyV2FU?=
 =?utf-8?B?K211ZG1kRGxaU0FwWngyVUpCM2NQQklTdmZ4aWtDUlRJOTR1OFRSdUtBVlVK?=
 =?utf-8?B?TldUZGxsYWk1WnU3NDhQWUxzSjdSVFVvd0N1cHlwTTg0Q3QxbzU4SVFMQ1B0?=
 =?utf-8?B?U1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 083913ff-b57e-4f46-c539-08db84b4c999
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 21:53:41.6977
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gcoTuV+A3S5wxoV/AOmIGOj1JCCV9b+HzQ8ooZTFzNi5U4lVKJicPVNznSDoriX58VFOQ13JTUS66Yz+GkAY16yoMxPKVZT0hUvPMPiZ670=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8404
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 7/12/2023 12:36 PM, Moger, Babu wrote:
> On 7/7/23 16:45, Reinette Chatre wrote:
>> On 6/1/2023 12:01 PM, Babu Moger wrote:

>>
>> Could you please add a snippet to explain the file naming choice? Just a
>> mention that this is done in support of other architectures that do not use
>> "CLOSID" and "RMID". 
> Adding this.
> 
> Other architectures do not use "CLOSID" and "RMID". Kept the names
> ctrl_hw_id and mon_hw_id to refer "CLOSID" and "RMID" respectively in an
> effort to keep the naming generic.
> 

Looks good. I would just replace "Kept" with "Use" since this
change introduces these terms.

Reinette