Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6ce7c4d8-3320-7712-a562-a43224c2602b@linux.intel.com>
Date:   Fri, 14 Jul 2023 14:47:24 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [6.5.0-rc1] unchecked MSR access error: RDMSR from 0xe2 at rIP:
 0xffffffff87090227 (native_read_msr+0x7/0x40) (intel_idle_init_cstates_icpu)
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        Bruno Goncalves <bgoncalv@redhat.com>, x86@kernel.org,
        LKML <linux-kernel@vger.kernel.org>
References: <CA+QYu4qSBdhEgFURu+ouAf2d_JNPbZgCSUaxCLoGzMqDQOLWsQ@mail.gmail.com>
 <20230711112421.GI3062772@hirez.programming.kicks-ass.net>
 <CA+QYu4qzJgiiU1qsjtWb9OU3=C=hb_c-Ag5Y4c=Xp_ObfGH=hg@mail.gmail.com>
 <20230711125557.GM3062772@hirez.programming.kicks-ass.net>
 <20230711132553.GN3062772@hirez.programming.kicks-ass.net>
 <0837a34c-f66e-aa04-d4a7-b032d3dbab7a@intel.com>
 <b672c500-5f2f-d60c-84da-80269b8b420f@linux.intel.com>
 <20230714211109.GC3275140@hirez.programming.kicks-ass.net>
From:   Arjan van de Ven <arjan@linux.intel.com>
In-Reply-To: <20230714211109.GC3275140@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/14/2023 2:11 PM, Peter Zijlstra wrote:
> On Tue, Jul 11, 2023 at 11:39:53AM -0700, Arjan van de Ven wrote:
>> On
>>> I think you mean "revert"?
>>>
>>> That can be done, but maybe it can be fixed instead?
>>
>> this specific issue I will fix shortly (together with the RDMSR thing)
> 
> I still don't know why this needs to be in intel_idle.

we can do a seperate idle driver; it'll still be x86 specific (since idle really is arch specific)...
and then the umwait parts of this will be Intel specific.. as well any future idle methods ..
and I'm not sure the AMD folks would even want it used .... at which point it ends up Intel
specific fully and we now have 2 Intel idle drivers.
I don't see how that makes sense.