Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 15 Jul 2023 00:28:39 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Arjan van de Ven <arjan@linux.intel.com>
Cc:     "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        Bruno Goncalves <bgoncalv@redhat.com>, x86@kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [6.5.0-rc1] unchecked MSR access error: RDMSR from 0xe2 at rIP:
 0xffffffff87090227 (native_read_msr+0x7/0x40) (intel_idle_init_cstates_icpu)
Message-ID: <20230714222839.GD3273303@hirez.programming.kicks-ass.net>
References: <CA+QYu4qSBdhEgFURu+ouAf2d_JNPbZgCSUaxCLoGzMqDQOLWsQ@mail.gmail.com>
 <20230711112421.GI3062772@hirez.programming.kicks-ass.net>
 <CA+QYu4qzJgiiU1qsjtWb9OU3=C=hb_c-Ag5Y4c=Xp_ObfGH=hg@mail.gmail.com>
 <20230711125557.GM3062772@hirez.programming.kicks-ass.net>
 <20230711132553.GN3062772@hirez.programming.kicks-ass.net>
 <0837a34c-f66e-aa04-d4a7-b032d3dbab7a@intel.com>
 <20230714211021.GB3275140@hirez.programming.kicks-ass.net>
 <ab419bb9-1065-5200-5b22-32f36b0426a8@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ab419bb9-1065-5200-5b22-32f36b0426a8@linux.intel.com>
Precedence: bulk

On Fri, Jul 14, 2023 at 02:45:21PM -0700, Arjan van de Ven wrote:
> On 7/14/2023 2:10 PM, Peter Zijlstra wrote:
> > On Tue, Jul 11, 2023 at 08:37:51PM +0200, Wysocki, Rafael J wrote:
> > 
> > > > Rafael, can we please just pull these patches and try again later?
> > > 
> > > I think you mean "revert"?
> > 
> > Yes, revert. The whole premise with the unparsable changelog that
> > babbles about TLB invalidates without any performance data-so-ever
> > should've been a red-flag.
> > 
> > That whole TLB angle is nonsense. We have paravirt TLB invalidation for
> > this.
> 
> for kvm and hyperv. not for vmware etc.

And for everybody that does play ball, this will be a net negative by
causing extra TLB invalidations :/