Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Jul 2023 23:25:05 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Okan Sahin <okan.sahin@analog.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] regulator: max77857: Add ADI MAX77857/59/MAX77831
 Regulator Support
Message-ID: <0faa7534-cd76-4678-963f-4350dbd7178e@sirena.org.uk>
References: <20230711162751.7094-1-okan.sahin@analog.com>
 <20230711162751.7094-3-okan.sahin@analog.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="r/nsbsijOa9vrkbY"
Content-Disposition: inline
In-Reply-To: <20230711162751.7094-3-okan.sahin@analog.com>
Precedence: bulk


--r/nsbsijOa9vrkbY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 11, 2023 at 07:27:48PM +0300, Okan Sahin wrote:

> Regulator driver for  MAX77857/59 and MAX77831.
> The MAX77857 is a high-efficiency, high-performance
> buck-boost converter targeted for systems requiring
> a wide input voltage range (2.5V to 16V).

This looks good, I've queued it for CI (it'll probably be Monday before
I check that though).  One minor nit:

> +struct regmap_config max77857_regmap_config = {
> +	.reg_bits = 8,
> +	.val_bits = 8,
> +	.cache_type = REGCACHE_RBTREE,
> +	.volatile_reg = max77857_volatile_reg,
> +};

Please prefer REGCACHE_MAPLE for new devices, it probably makes no
practical difference but it's more modern code and we might want to
retire _RBTREE at some point - please send an incremental patch to
update assuming this makes it through CI OK (I'd expect it to).

--r/nsbsijOa9vrkbY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSxy0AACgkQJNaLcl1U
h9BkKQf/VvNJMLFok80h1swgvk7vg2A25p0jdT8jKPzhESRN9SutzdIn7GDTSsbp
y+gWR770luIWEvmjAfV2bh5+ZLh0CfCl3W+IDMyUfxcOJqSjoHJnI90sRer2/SdA
vVroSLqKc/5asmlWwCzhfwyCvD4+s23ZWPBkW9uqQrgSeIU0gtKf97KlKNB1wHfJ
fL0Syz26UsSRWYjbfxWWHvLRImXNZwHRZe1DR/JPC1PoboO5DDhNp1QiWpmRQz87
Zqy6L3OBT8rmGFnfTJOldgSfB3NXFajirHGEvTutimEdnPUFjFxi131DQSyeJijO
HfGXJ1KOoZMmY9cCWgEfxEj0MkrcWg==
=fPwt
-----END PGP SIGNATURE-----

--r/nsbsijOa9vrkbY--