Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <0b0e6961-1211-4765-2a63-4b69789dbbb3@roeck-us.net>
Date:   Fri, 14 Jul 2023 16:27:48 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v3 2/3] arm64: dts: ti: Add reserved memory for watchdog
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>, huaqian.li@siemens.com
Cc:     wim@linux-watchdog.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        huaqianlee@gmail.com, vigneshr@ti.com, kristo@kernel.org,
        linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        jan.kiszka@siemens.com, baocheng.su@siemens.com
References: <20230713095127.1230109-1-huaqian.li@siemens.com>
 <20230713095127.1230109-3-huaqian.li@siemens.com>
 <20230714225240.dvlwqaodp2l3cczm@disfigure>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20230714225240.dvlwqaodp2l3cczm@disfigure>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/14/23 15:52, Nishanth Menon wrote:
> On 17:51-20230713, huaqian.li@siemens.com wrote:
>> From: Li Hua Qian <huaqian.li@siemens.com>
> 
> I guess I should be explicit about this: Lets keep this dts patch as
> "DONOTMERGE" in subject line for driver subsystem maintainer (I don't
> want a repeat of cpufreq maintainers picking up dts and associated
> warnings that are now pending fixes), resubmit at next rc1 and I can
> queue up the dts once the maintainers pick up the driver and bindings.
> 

FWIW, I never pick up patches outside drivers/hwmon without explicit Ack
from responsible maintainers (and most definitely not dts patches unless
a maintainer responsible for the file(s) specifically asks me to do it
(which I think never happened).

Guenter

> Ref: https://lore.kernel.org/all/20230714084725.27847-1-krzysztof.kozlowski@linaro.org/
> 
>>
>> This patch adds a reserved memory for the TI AM65X platform watchdog to
>> reserve the specific info, triggering the watchdog reset in last boot,
>> to know if the board reboot is due to a watchdog reset.
>>
>> Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> index e26bd988e522..4bb20d493651 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> @@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@a2000000 {
>>   			alignment = <0x1000>;
>>   			no-map;
>>   		};
>> +
>> +		/* To reserve the power-on(PON) reason for watchdog reset */
>> +		wdt_reset_memory_region: wdt-memory@a2200000 {
>> +			reg = <0x00 0xa2200000 0x00 0x1000>;
>> +			no-map;
>> +		};
>>   	};
>>   
>>   	leds {
>> @@ -718,3 +724,7 @@ &mcu_r5fss0_core1 {
>>   			<&mcu_r5fss0_core1_memory_region>;
>>   	mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
>>   };
>> +
>> +&mcu_rti1 {
>> +	memory-region = <&wdt_reset_memory_region>;
>> +};
>> -- 
>> 2.34.1
>>
>