Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 15 Jul 2023 04:14:21 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Tom Rix <trix@redhat.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] shmem: set variable shmem_mark_dquot_dirty and
 shmem_dquot_write_info storage-class-specifier to static
Message-ID: <ZLIPDVIw/6cZfKrz@casper.infradead.org>
References: <20230714215113.3919026-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230714215113.3919026-1-trix@redhat.com>
Precedence: bulk

On Fri, Jul 14, 2023 at 05:51:13PM -0400, Tom Rix wrote:
> smatch reports
> mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty'
>   was not declared. Should it be static?
> mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info'
>   was not declared. Should it be static?
> 
> These variables are only used in their defining file, so it should be static.

These are functions, not variables, and you're the third person to send
this patch today.