Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp3221554rwp; Fri, 14 Jul 2023 21:00:56 -0700 (PDT) X-Google-Smtp-Source: APBJJlHyiiY1ksL6Zuk1CT/gdQ7tkdlJJ8m1UcE4eJTT3vz/ZGZZbPPQSCaHwVlsPDoEQEZHsN4Q X-Received: by 2002:a17:906:2258:b0:98d:5ae2:f1c with SMTP id 24-20020a170906225800b0098d5ae20f1cmr5995023ejr.34.1689393656471; Fri, 14 Jul 2023 21:00:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689393656; cv=none; d=google.com; s=arc-20160816; b=UGlF2QvXIqprMbfonwZTa6rq/z4bfAn64L5cdsTXDPjz2owBoTkVi+vKdbHVkMqPI4 zAZ1gwp4qVsXkUY5vjTXiA0U8SDKCU3A+WEfqZr2jtMLjdO6/YxJFjlySLvxyOS/9ElV 3VQR58WIINxaFGarm6FYoVJu2WmTI/Ei5K/IlIt+rZkkiSNxXN5I5XX0C6o19O6qZTIz 8JeekcIYMG9mKWBHBvZvT94MrOFk8ff9kf6qmVbjYrKXbTKEzNJP2z9qoXbc1rqF4LqL Xzwgb/Dq5DmOceyNBrwkU7Z9Cap1Y5yhEhRi2IKIkUM1ohw1eiMqcFO1314DFrgaunHO UfHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yKjL48l7aPRw8IocgRlVRY32V+vRxNKJ9cdRkCWL6qw=; fh=HWMaEWT7OZhan/GGEUpfenaCfeyh8Cu3JdXXq15heuQ=; b=s4QftkpM1M+C38yn/hTif95T0MIOUTU8ZuS9pfQL7VY/F3oyp2OwwGWgbEFk3XwkzF l2JApVmIgMkhaO0N3e4mmAk+C3+BwL682nq8Md1qS7emIM8yZ/+x8TRdW7jmD4N5kIMx x+Jlx06iVpIfU0XwzK8nq+6OMToE6J55CHgZMabxUDEoLcwDbBzAksEmZ4AU3viFfulI 53j+XLAkRcp0tGD3nhi/rL8i5RpryeEXWF3N0adiMU2eEZNNrFXWT73R5pRLEaxFZdyp PRFEmn+yNLsBoUrLtowAjakWOiUFZPAKxqEjl2nR0vIcVjh7vKcAmSTMeiqtMGVd6g9m /y1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="P/pMrUwn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id la21-20020a170906ad9500b00992feae3848si10217054ejb.38.2023.07.14.21.00.33; Fri, 14 Jul 2023 21:00:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="P/pMrUwn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbjGODmX (ORCPT + 99 others); Fri, 14 Jul 2023 23:42:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbjGODmX (ORCPT ); Fri, 14 Jul 2023 23:42:23 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DFB110EA for ; Fri, 14 Jul 2023 20:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yKjL48l7aPRw8IocgRlVRY32V+vRxNKJ9cdRkCWL6qw=; b=P/pMrUwn5P9Y9d44vXU4s64xqn BgNAcSxwdu1J7hdcFr3BjWrO2ghT2IqrRnE4doa/NqWIZ/J0V4oYz6Ye2DH5MtI/u8WyZFfPfoC91 hNogEZnp4Oxya0+y/OQoCUMrIQfUdwaKfFBblKAkx4CnMgMphIpfYPEZoCUR++BdKjswJJWKXfnqh sU7eQJ5T4zsfC3q4qMPjKReOCKxek7xt4sD+smSPs7beK6OO7iFelmM4Sr2fcuAXn3Lh3b1CHjqRW DVZAIcNPceUHWSO2lUSyy1xI2ZY6y5ijetd8lLv3f2uD2wNtla9ZuM57jct1pLcDWs2fFBIVqu/Az OJYLOvaA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qKWAf-001nAv-9W; Sat, 15 Jul 2023 03:42:13 +0000 Date: Sat, 15 Jul 2023 04:42:13 +0100 From: Matthew Wilcox To: Johannes Weiner Cc: Andrew Morton , Yosry Ahmed , Christoph Hellwig , Nhat Pham , Domenico Cerasuolo , konrad.wilk@oracle.com, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kill frontswap Message-ID: References: <20230714194610.828210-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714194610.828210-1-hannes@cmpxchg.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2023 at 03:46:08PM -0400, Johannes Weiner wrote: > diff --git a/mm/zswap.c b/mm/zswap.c > index 62195f72bf56..1b0128060792 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -2,7 +2,7 @@ > /* > * zswap.c - zswap driver file > * > - * zswap is a backend for frontswap that takes pages that are in the process > + * zswap is a cache that takes pages that are in the process > * of being swapped out and attempts to compress and store them in a > * RAM-based memory pool. This can result in a significant I/O reduction on > * the swap device and, in the case where decompressing from RAM is faster > @@ -20,7 +20,6 @@ > #include > #include > #include > -#include > #include > #include > #include To make this patch compile, I had to add zswap.h to the include list.