Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230704221951.7396-1-bp@alien8.de> <20230705162026.GA2951@dev-arch.thelio-3990X>
In-Reply-To: <20230705162026.GA2951@dev-arch.thelio-3990X>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sat, 15 Jul 2023 14:46:19 +0900
Message-ID: <CAK7LNARbt-=KnmA+pTJQ1Fg9XmGMySWAFd1jDs_smnpq1Nus7w@mail.gmail.com>
Subject: Re: [PATCH] kbuild: Enable -Wenum-conversion by default
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Borislav Petkov <bp@alien8.de>, linux-kbuild@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jul 6, 2023 at 1:20=E2=80=AFAM Nathan Chancellor <nathan@kernel.org=
> wrote:
>
> On Wed, Jul 05, 2023 at 12:19:51AM +0200, Borislav Petkov wrote:
> > From: "Borislav Petkov (AMD)" <bp@alien8.de>
> >
> > This diagnostic checks whether there is a type mismatch when
> > converting enums (assign an enum of type A to an enum of type B, for
> > example) and it caught a legit issue recently. The reason it didn't sho=
w
> > is because that warning is enabled only with -Wextra with GCC. Clang,
> > however, enables it by default.
> >
> > GCC folks were considering enabling it by default but it was too noisy
> > back then:
> >
> >   https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D78736
> >
> > Now that due to clang all those warnings have been fixed, enable it wit=
h
> > GCC too.
> >
> > allmodconfig tests done with: x86, arm{,64}, powerpc{,64}, riscv
> > crossbuilds.
> >
> > Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
>
> Yes please :)
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>


Applied to linux-kbuild.
Thanks.


--=20
Best Regards
Masahiro Yamada