Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 15 Jul 2023 10:34:21 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Minjie Du <duminjie@vivo.com>
Cc:     Horatiu Vultur <horatiu.vultur@microchip.com>,
        "maintainer:MICROCHIP LAN966X ETHERNET DRIVER" 
        <UNGLinuxDriver@microchip.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        "open list:MICROCHIP LAN966X ETHERNET DRIVER" 
        <netdev@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>,
        opensource.kernel@vivo.com
Subject: Re: [PATCH net v3] net: lan966x: fix parameter check in two functions
Message-ID: <ZLJoHV+gdBMQrnfJ@corigine.com>
References: <20230714085115.2379-1-duminjie@vivo.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230714085115.2379-1-duminjie@vivo.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3d4picd2H+17jn886rJ4M0tOZ19pImwfgrCaMp/06dV3/tuRZrpV8x97lQWG?=
 =?us-ascii?Q?CiR4LTGkjRztgAgeuk+WPNNk5hya7ptntRxo8aQWF8LIEkEvDJujyRjwmc8W?=
 =?us-ascii?Q?RXZ7eqoI11Vu8J8USAgRJ1LpSyR8f91A7HnxlY91o05dwj//MVEdBbdfQ73P?=
 =?us-ascii?Q?g1JPqEJBBDKp0kVfdKB0dndr/hZczX9abul4jxW9sG/21tqve1SvAuRoKXnf?=
 =?us-ascii?Q?VgD6o27EfCLEQezZYT7eUdEA+KlgzTIGoSJGv00wXYwOMg2Mu4LZWuwzE6CK?=
 =?us-ascii?Q?pDjnskwj7t8fTvS++00VyMF9mM+YMyeB/0oxI9713MApLIKiA+UJCr0gNNPx?=
 =?us-ascii?Q?w9I1geY8RXqjgjkgrEIwarUmkW4V+Gga8/Wagm48dB685nqxgcU/T4A5SdRv?=
 =?us-ascii?Q?yPrP3klTef0TzKazYbxBPjbafFv1JuwtBrpLHbEYVaqtr8wSbyGWzs7Uj72V?=
 =?us-ascii?Q?eAS1d/ilB5IE8PrtlD+HRkjdJWvW+vA8gWddYi7F5Bn4K6Nw8/89U1bCZFab?=
 =?us-ascii?Q?FZftTtOIsPqBhpUlBVOLMSFkBcEZeWHRMxWCnJUTcrlstMgi+SjTYJEmLTXk?=
 =?us-ascii?Q?tWhBEERSNmHcunu4vk/XVTXt6k6j2bPZ4wC12iPhjFeINfiTrVm8ha1OiJs1?=
 =?us-ascii?Q?76jUTNCiT433rsReBwAqNroI0RWVefCWk1DPvGybEskQ8B3R2TGKyHTN6GT1?=
 =?us-ascii?Q?wkcKDaRgjzfFO7ybykySNTaqK9nIQrq/WnqOjB50MyxPbh9VHIzK+KsYByhJ?=
 =?us-ascii?Q?5IzwyzgGjBMBaj+Q9f/C0XVqum3gagnn4bL9uJz6uDnDkvMy94DhyQbzbW3a?=
 =?us-ascii?Q?kh1G/HpRXHrs2+xClFcF60Tst2G/IobqReMchTSIxQ7Z3uNjxuJPJpFwrjjz?=
 =?us-ascii?Q?ZW3RKc8trS3Z+1okPT7XdR++p7XRHvCrIxp5d6j70l/WQeibnnua7Vapi2rh?=
 =?us-ascii?Q?m9tSWnpliRw+W5xylMD8fWQMjYijpWWJMZLUtGCfGvRtv7ip1kplhT0BecYt?=
 =?us-ascii?Q?PiNrM7EiTbtblXVaXH/MdFERSC3l5cYNmLfesQOnq6UUXK6R2IiYCtAIXt3m?=
 =?us-ascii?Q?p1g7wEOBTkrDPkIAxrEwsP3xr9wp6DQOVMbpytcrhqLFw+zPD9fqNPnnGqLB?=
 =?us-ascii?Q?r5l3fCNnp8Gwa5NDCXKJYtBHKX6N+7h/h02FYZLhj4OAt6vux15S2LWxSRXe?=
 =?us-ascii?Q?uoYOjlEWCpzvpdXpWXkDOCr7wfFEt+u67HS3USrD5LniyVKXYL37f+L4OZF+?=
 =?us-ascii?Q?ldV9WIH2dlPFY+Kjwr+hIiHjLV4ze2KQnNDeYMq2+gHEFsf3bR0Bk+sW2Bwy?=
 =?us-ascii?Q?pMMw8uBaYAth4WslwD5+2N8Vb6BLL/EQLsb2iWVy0+jp/HBWAqHrFIG7nIMo?=
 =?us-ascii?Q?m/Z++CYJGTtQ5ODf4gU/kisNLAUaDJow8k7xCQAtSKiLv/U8zYSasb38+K+C?=
 =?us-ascii?Q?MDn09BzOxHTdMLBdxCF+zR52QfIOLZJd9Sopf77HFeTQ20YWy1J4t/VhorP1?=
 =?us-ascii?Q?hrAnRQo1/HMZzncPsG9NhU3opFcEGamraSXGi97TRlDSNRkyyVg/BXxt9CoL?=
 =?us-ascii?Q?OE/2rF5O1zag+ED2VZx1vayG6paXyCfgk+LNN2RP/IYX+siyNOx4vguYMLgY?=
 =?us-ascii?Q?dg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92573e67-589a-4db3-030e-08db8516aeda
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2023 09:34:27.3781
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EXkH6dmfM5hhyiEZTgOzNCDpUybuusA60+uz/31Q6fCWTz9P6sfVWO8WNvzXP8JzISHnB9k6s0VeDX4Aht0KZWlABrUtsHftai+zWbJzwN0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5329
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 14, 2023 at 04:51:15PM +0800, Minjie Du wrote:
> Make IS_ERR_OR_NULL() judge the vcap_get_rule() function return.
> in lan966x_ptp_add_trap() and lan966x_ptp_del_trap().
> 
> Fixes: 72df3489fb10 ("net: lan966x: Add ptp trap rules")
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>