Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b95c4169-88c8-219e-87b7-6c4e058c246a@suse.com>
Date:   Sat, 15 Jul 2023 13:05:48 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Content-Language: en-US
To:     Kai Huang <kai.huang@intel.com>, peterz@infradead.org,
        kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org
Cc:     dave.hansen@intel.com, tglx@linutronix.de, bp@alien8.de,
        mingo@redhat.com, hpa@zytor.com, x86@kernel.org, seanjc@google.com,
        pbonzini@redhat.com, kvm@vger.kernel.org, isaku.yamahata@intel.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
References: <cover.1689151537.git.kai.huang@intel.com>
 <c22a4697cfe90ab4e1de18d27aa48ea2152dbcfa.1689151537.git.kai.huang@intel.com>
From:   Nikolay Borisov <nik.borisov@suse.com>
Subject: Re: [PATCH 08/10] x86/tdx: Unify TDX_HYPERCALL and TDX_MODULE_CALL
 assembly
In-Reply-To: <c22a4697cfe90ab4e1de18d27aa48ea2152dbcfa.1689151537.git.kai.huang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d09ZTFlGYjBKcWhkU3czVU1ZMFR3ck5wRDU3Q2RtTnR6eUVlOW92bDl2WFFx?=
 =?utf-8?B?R3RtVzZ0Ukl6SmlrbE9HWnVmdUQ2MkZPdmJuWTBkOWkvL3orREZ0b2xGek8y?=
 =?utf-8?B?ZWRDZVE0NEtxL2F4N3FNM0xpWXo3TUtsVUVXbzQ3UVBpMWJJdDlsVE5hZVF5?=
 =?utf-8?B?cmpoNXQ3bGlZTWlCbU5xN0sxTjBkYmtQZmppZ2tKcXNxZzltV0JWdllPVGJH?=
 =?utf-8?B?VTdiM2h3bG9JTndlSTkwb3h0Z09uSm1UdXNnSFNMVnJWRXVaZGJXM1dlS0J1?=
 =?utf-8?B?SnY5RHZJSWJGUmpQRGxLclJaaVozd1FMeFNaM0Q4ajlMaEVrSXgwdWltdkVl?=
 =?utf-8?B?eE5ibmlUdmx4SGl5SEpqTHRJc2gvaWNpUDkvd1Z2T2loSTBqL3RqR3J6bjBq?=
 =?utf-8?B?Qk90UmFkYWp4V3RVNzd2V09FbkhmcFduWjJSNk5CcHBlNFpqeTBXZEVHUE1S?=
 =?utf-8?B?eUlIQUpHMTQ4RE9HMkhubkRPWXpHQk5JVEZQRVBKaWNiRmVNZTJHNVAwOUNK?=
 =?utf-8?B?aDFjMlBPbEthUGl3MnBqNnhBbTBCMElybk9iTTJpQ2lVWktFOFRQcUtlYUFj?=
 =?utf-8?B?c2NNYVlLQmRHcFlRbnVHelZMTDM2N3ZoMnpUelAzVFhBSTJiK1NIbnF3RW9D?=
 =?utf-8?B?bXB5UXlmRWZmYUJPOUpyU25qblBXbzhXZ0lkQjg3b1FCaVNNYmpLVHUzenh2?=
 =?utf-8?B?MjhFY2VYWXJXT1N3NUMraUd0eTZqMU5DZERFMzJQckV0TEVRSlFEV2FZbS9Q?=
 =?utf-8?B?Wnl4ZHJmTVRVQ1VmWlhkMThpSWZoRmdUV3Z4NVc1UEV4dG45YUE5bDBGNlIw?=
 =?utf-8?B?ZDhUd0VkaHg4WGNkclpXaDhQdHdNaTVnTmtwMWVXLys1RHBCS0xFTnQ4QXEw?=
 =?utf-8?B?aGNRd3pjc0cyRG8rdUY1UnU1NVVQN0VLY1RuREg5WkdScWNtUTlGUHdOYmpP?=
 =?utf-8?B?a3NMcmdYbkRQL0JLWTBDVmtNOS94UnJZamtXNlF0WWRCazVqRk1rUzlFaTlH?=
 =?utf-8?B?RXBaSXZ5bE1rTTRHR3lZbjFYYlp1ZEI1M29WOXNLd1VScmtVd3VBR0xaT0tP?=
 =?utf-8?B?aFQ3cDMvbUpQR1FOOFE4VFhGblo2NE5xN2hlNlpKWHJQbjA5aDE5NGdLTmti?=
 =?utf-8?B?alJJQ2pjN1BucmU3V3hXRVREelQxdzI4dmc0QkJQeHA4cE41bUd0KzYvVmRX?=
 =?utf-8?B?bnhVS0hEUFhyTlg4dWxFd0ZMQjJib3RRTGdtazA0Qit5WWZWWWpOU2NvcjB2?=
 =?utf-8?B?T2ZSQUJoZ01jY0xYMStLRjBzNlFGS3R4clhISk5OYVZGdi9XdENPQi9PRzZq?=
 =?utf-8?B?SlRuRUlBTUU0dmZ2M280VldXR2M1UldtaUJPQTNrNDNMNWFqazlocDhVcUZn?=
 =?utf-8?B?SkhPR2ZvNVNuUWVPeG9ZeHVtbFJYU1JyZ0E2aVBhZGZ2QlNSYURnUGFORXRi?=
 =?utf-8?B?a1Yra1lXRHZRRVc0VVRGclpMNGlmTjVoajRFYzFBTHFuOW9UaXpUYkI5MnlC?=
 =?utf-8?B?TGpuMUxRdUk0VjdJT2w5cGhyNkVXSTJ3MDBqNzJNK2wwdktNSUZ0ZmpBNTdu?=
 =?utf-8?B?R1AycmlFVVRFbTFTajFXNEcvVHhidzUxN1dnYXVXdWdsU2Q2dFFNKzExOU5s?=
 =?utf-8?B?YTJITWNUSVNVZEswcEQvaktZK1F0c2wvMzFGaElwSFNuWTNUMlYzUE0xZG9E?=
 =?utf-8?B?bEg3Y2JqZWVGMXFtNzhvOGdJSXNuZUcxV3hqVy9USEhWcW1WaTV2S3dJWkxE?=
 =?utf-8?B?TUZzZnFncDA1NnNSbElQREJSdzhsLzNuWmRZZ0xRcHdHNWNTZm95VFhIblRx?=
 =?utf-8?B?Q3dDTmF5M2hKMnVONVdJZ0E1RDNsREJwNGhZZTREbWR0YzkrYU5leTFmZVVU?=
 =?utf-8?B?L2o3Y1M2d1MxRFd1Q2o5S0Rvd0FxNkRCR0s4aFNlZWtWNm8wQ2dpekZNdGVN?=
 =?utf-8?B?NU51Nmd0WDk2Y3NmT3hNbi9CL1NpYnM4MVQxNE8yckZoaHcwd0FTQkl6ODlk?=
 =?utf-8?B?bHhvNnhrMEtHUUdVK3FOdTk4enUvVW00aTdIV2UrbjMwampDSzQ4QXVVVWMv?=
 =?utf-8?B?S01od3AySFl3dHJ5UXUyejQ1RHU5Qk9ScW1wMUxuVEc4c0ZsWllwcFZGYncy?=
 =?utf-8?B?WHBIVGloOWIzTEw0Tldpb2twclpmc3RUbllNZnRpQTNJbW5OQmpGaENnbjZa?=
 =?utf-8?Q?332D1nm7WklMxL2Yibuw6MMYbW9ye83Ey158EuvyO9h+?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36c675ef-6a21-4052-dc31-08db851b11db
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2023 10:05:51.4691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hjx5Z+LBnf9hDtoG/0wbCHGBCqcJiOoae/zCkUpfpie5vYPwXTQxJjJLL/G1VqQ/0wPPy9GCgHW+u0b1SjbgEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9818
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


<snip>

> diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c
> index 0f16ba52ae62..a5e77893b2c0 100644
> --- a/arch/x86/coco/tdx/tdx.c
> +++ b/arch/x86/coco/tdx/tdx.c
> @@ -51,13 +51,38 @@
>   
>   #define TDREPORT_SUBTYPE_0	0
>   
> +/* Called from __tdx_hypercall() for unrecoverable failure */
> +static noinstr void __tdx_hypercall_failed(void)
> +{
> +	instrumentation_begin();
> +	panic("TDVMCALL failed. TDX module bug?");
> +}

So what's the deal with this instrumentation here. The instruction is 
noinstr, so you want to make just the panic call itself instrumentable?, 
if so where's the instrumentation_end() cal;?No instrumentation_end() 
call. Actually is this complexity really worth it for the failure case?

AFAICS there is a single call site for __tdx_hypercall_failed so why 
noot call panic() directly ?

> +
> +static inline u64 __tdx_hypercall(struct tdx_module_args *args)
> +{
> +	u64 ret;
> +
> +	args->rcx = TDVMCALL_EXPOSE_REGS_MASK;
> +	ret = __tdcall_saved_ret(TDG_VP_VMCALL, args);
> +
> +	/*
> +	 * RAX!=0 indicates a failure of the TDVMCALL mechanism itself and that

nit: Why mention the register explicitly, just say that if 
__tdcall_saved_ret returns non-zero ....

> +	 * something has gone horribly wrong with the TDX module.
> +	 */
> +	if (ret)
> +		__tdx_hypercall_failed();
> +
> +	/* The return status of the hypercall itself is in R10. */
> +	return args->r10;
> +}
> +
>   /*
> - * Wrapper for standard use of __tdx_hypercall with no output aside from
> - * return code.
> + * Wrapper for standard use of __tdx_hypercall() w/o needing any output
> + * register except the return code.
>    */
>   static inline u64 _tdx_hypercall(u64 fn, u64 r12, u64 r13, u64 r14, u64 r15)
>   {
> -	struct tdx_hypercall_args args = {
> +	struct tdx_module_args args = {
>   		.r10 = TDX_HYPERCALL_STANDARD,
>   		.r11 = fn,
>   		.r12 = r12,

<snip>