Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 15 Jul 2023 11:54:53 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Tristram.Ha@microchip.com
Cc:     Michael Grzeschik <m.grzeschik@pengutronix.de>,
        Oleksij Rempel <o.rempel@pengutronix.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v2 net] net: dsa: microchip: correct KSZ8795 static MAC
 table access
Message-ID: <ZLJ6/ZkKk00AFPqi@corigine.com>
References: <1689295582-2726-1-git-send-email-Tristram.Ha@microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1689295582-2726-1-git-send-email-Tristram.Ha@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rCPsilAZLokz9b0kUaThqwHcGoE5+BYNV5dBqGhyUesdGg5b5z1nrSAUgwaJ?=
 =?us-ascii?Q?w73OPkV4/TI8YlzPFHf5upbOxrAU9pTe38tvzLsUUktzMJBk0sRsH9SzabJN?=
 =?us-ascii?Q?lAJk6BzL1khfG5jAJrnMohLDkvjioX4zocnQudkXlVvWlWhpc5OpzuB8g3xj?=
 =?us-ascii?Q?FEsyGFHP6nIYH70zcMK2OAo4eb/ffx5YzjwkeCS/2QXSunggnoDRU3EVhIqN?=
 =?us-ascii?Q?uAN3GKVcDKLg8PixglhsuyQ+DPf3wgJ+JlAVIuXHZU2arlZ91j7d1ZDXRP47?=
 =?us-ascii?Q?417VnPV1mvoFN2CDyYTlRqfT50Y1w5ph+TE3eZ4N8ApSe0RVXa79KgzIQSPq?=
 =?us-ascii?Q?WuazF6Pq9+lzGFIIUNECD5z2AjFd/LAkt0U1HLcBkmt4UDhflJmH8kZQjGNE?=
 =?us-ascii?Q?p/P8LBNLJNonkuWhgjo5vfdJ0kQcYk6Li6gsSdNJ67Jep6QaeEBttayxvTwi?=
 =?us-ascii?Q?vnDMUeCJ1jGe1WfHHcWbIR+Phw4w5wYaSP5nZzsuhl6Iv21ytxhvlW2b/Otc?=
 =?us-ascii?Q?jdtn6fuppUj97mJgFNGyYjDGnA/f4d6SasyxD9fRVar2rYhuwSDNvxSQ+v26?=
 =?us-ascii?Q?x6lRO1sfnbqXCH9PO8+pPDA8CTOOulGt/Knu6NEepnoOdZBHU5T+zy/x0g3o?=
 =?us-ascii?Q?S40T9bGDWuqrcA8gfKpxu16NwQWmsTOatRyDfJ0PY6IBlMGyDkk35X9zwS9Y?=
 =?us-ascii?Q?KrzUcj0SBC+MgwxH208++l5MnZ5paM2zAu4SvdhBXwjb++mO5jJKvlEY7/0u?=
 =?us-ascii?Q?TEl1txDJhkA8Z92zrfdss+7N94s17oIKv+cMaLfhaz0jqPNGSZXegz26KBXQ?=
 =?us-ascii?Q?mlOM36eeQPAMUOzXun156ILhUghtudDYMyA0AnumbE2un5203jXjDNdxLDsp?=
 =?us-ascii?Q?QDQ281uqfX/KMvGJB8s1C53cBoomOSBDG+1JAyUy6eXvV+3juIppAkf9rmjk?=
 =?us-ascii?Q?iIsP4gexZsAL6eDGexzPU+vOytUUKurtILbhUveBh4qUkDhk78meqCuRJEw3?=
 =?us-ascii?Q?DH19qjUf3RLS+wI6PIGtopOI7MmNqDPEmyVU/4Is1m8sEndy86EQZpCg8rYA?=
 =?us-ascii?Q?yz5UFHqeQvxgDALgsaN3eFruNfwZ7TRqCWDOBTY0p5LNiT1Atvg97mebwRhT?=
 =?us-ascii?Q?d5Qr/yyeXxauhSIN9UPhpUAg54aQJ5yIsQsiNk35bgRXtPpJE9UQV2uJ2K1e?=
 =?us-ascii?Q?HQc2Vy6BSmeo0XlC/1F9xtUX1yT78a805vOFtJfMm3GyALnhaSJbla3xpRkO?=
 =?us-ascii?Q?udzSVPxAIri7sh5GVtD0Aarkk/4x+XWDyYAqXeerfcKU/T0IcR9+dXy1uXIa?=
 =?us-ascii?Q?bUCJqYg+ge5hSIdniA4GzeDDHHSEGMg/u/FiZTYrKrjaYGj9NKlAJDFEWIzu?=
 =?us-ascii?Q?dfhJYxwnLx1E3TmmL0HKV8IxNZPeD9hyg1X/uzHE4z4JO35Wn6KspS13NAxI?=
 =?us-ascii?Q?aw5MAy8XMzU1wTRW92MUJOB/moF2XXRlNwJQAXdGrJvSgiW6i0WwQ2eZU3Eb?=
 =?us-ascii?Q?cN07Aizxbeqfb51vy5NpHKMuXG4o8MlJs28/AEdvIYdOCpWJdKSBWONd/scc?=
 =?us-ascii?Q?JieG8RwDNzlrMKVIEdm+gjXTMsj2LTmRQK6On17yg3b67zj1MHOp45w7R/aB?=
 =?us-ascii?Q?1g=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78b48ace-cdae-459e-6a64-08db8521f09d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2023 10:55:02.1572
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WXYnDC9p+f5RWHTQjAAQmpTVH2CQw11LeTVs4Fw2c65YOGe/wrNQOxEdNsd8dGR81MKDXrgSr9D48ZiZx/1IkQkpsoPTHSfgBIpUZd2FJSU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB4681
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 13, 2023 at 05:46:22PM -0700, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <Tristram.Ha@microchip.com>
> 
> The KSZ8795 driver code was modified to use on KSZ8863/73, which has
> different register definitions.  Some of the new KSZ8795 register
> information are wrong compared to previous code.
> 
> KSZ8795 also behaves differently in that the STATIC_MAC_TABLE_USE_FID
> and STATIC_MAC_TABLE_FID bits are off by 1 when doing MAC table reading
> than writing.  To compensate that a special code was added to shift the
> register value by 1 before applying those bits.  This is wrong when the
> code is running on KSZ8863, so this special code is only executed when
> KSZ8795 is detected.
> 
> Fixes: 4b20a07e103f ("net: dsa: microchip: ksz8795: add support for ksz88xx chips")
> Signed-off-by: Tristram Ha <Tristram.Ha@microchip.com>
> Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>