Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp3763463rwp;
        Sat, 15 Jul 2023 08:58:12 -0700 (PDT)
X-Google-Smtp-Source: APBJJlFAhgT3Kmh7Wtl0Z2twSV3HmuQyULHlZRlYWhZVp+HNsQDW/Oyd8TxckZPZ+DGDY/pRQdG0
X-Received: by 2002:a17:906:d4:b0:993:d88e:41e3 with SMTP id 20-20020a17090600d400b00993d88e41e3mr5739357eji.4.1689436691774;
        Sat, 15 Jul 2023 08:58:11 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1689436691; cv=none;
        d=google.com; s=arc-20160816;
        b=w+l4nPBdQFth8tAt1kd3m6RlQI49A1G5E6gIDwOtEKxUZQt6M7BItgZOqX8fC8eEdH
         w1F4z9v0w/SPFG004SIkwk2Mt/Qvr07Jy7WG+ClXSLdmJ7PZR0t8rSn1FjuIZ389H1Og
         s8oAdcyCDyhE2m62F1MRH1jlXQU2Lbb7Ysm1KScwXsok9+MTJd0W5RbawPZfVO6EBmJ8
         WWRFSr3bEAqrS1EcLrT7K4102FCx8sQQr0Tb1CdSe7zVvSfzsG/1XUOIyIt2y3JBqhMt
         ehuCYbcIOdtBK7MCTq2ms54Ph1F/OHgXTQsErU2mYbr6QkQ7wQA48fjNuaVmnd6Q8tjI
         2x/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=gX2Ur56CpmqFeyTI5I1MG2pU7sRyHX4d4pChbT4mh+c=;
        fh=FemtBqNxo2AF6CbdHF3JZi281P7kABwrzdM8mK9BWVw=;
        b=gmylW77IUFe5TAEqSKTKVY4Ys/SKyhXUqY3NjffQ9CJzTFF1ta75P7VShYXRt7cMyC
         UpR4gKMhgghvE2WYvyFd30v90mrvdBsWhw3bcd+jdL8W3FbfgMHBSPQMfS+HuKjqVYFe
         zkEKIZ9sKjKXFJkTNuR8Ysxd/mtGwB90a2TFnPX0/PdLSCmUHIv4jieGZuH+smKqaKvT
         AYe+SA23Bwm74gx8KQ6jSCyn0ZaOQQCjMTg8RXY8TlSk+CzS5XUaJkAu4lywJ1/bChyn
         UNuyZY3Fx1DCP9qFRA4qk99B/m782H6MzPtm0jccQfAfRcJavtKJQXTfnhmPCT3qzsf8
         2rxA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=B5zVT4Ic;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id ox29-20020a170907101d00b00988f21df36esi3021586ejb.594.2023.07.15.08.57.48;
        Sat, 15 Jul 2023 08:58:11 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=B5zVT4Ic;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229631AbjGOO4b (ORCPT <rfc822;amanduch@gmail.com> + 99 others);
        Sat, 15 Jul 2023 10:56:31 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54992 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229597AbjGOO43 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 15 Jul 2023 10:56:29 -0400
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C46592726;
        Sat, 15 Jul 2023 07:56:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=gX2Ur56CpmqFeyTI5I1MG2pU7sRyHX4d4pChbT4mh+c=; b=B5zVT4IcoB76XE8RWVSIUOQH2I
        xgxMCzyS7OA1VYd40ZyS6+2gsIvDn1qgLguSLVH71cf1zOSFQee3+i9jgTf3+L26Gxpi9mm0nE64e
        zSUPzmTnee8R6tC1bsR1AWv9PPgQJvXI77qhHt+K76S0y2LmnTj8N8fJZapmwUteSOtZzHQRcZpJR
        NXtDwHM7EXfLyX56JkfwfDOVR/du50e5HNXyeZzUSc7RKrDbdtCII9rlMYunTaC2lxHEuh24DOfLf
        rmdXbIMUhCUhpk8kbkgj01gUYumQxWlTs21nha2+o5tAKoGLNYz2MpvL5jILrEGbqq+x0VqSrDCK5
        xXjcPFzQ==;
Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1qKgh5-002GWX-JB; Sat, 15 Jul 2023 14:56:23 +0000
Date:   Sat, 15 Jul 2023 15:56:23 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Leesoo Ahn <lsahn@ooseel.net>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Leesoo Ahn <lsahn@wewakecorp.com>
Subject: Re: [PATCH v2] fs: inode: return proper error code in bmap()
Message-ID: <ZLKzl+Ac+px98GwC@casper.infradead.org>
References: <20230715082204.1598206-1-lsahn@wewakecorp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230715082204.1598206-1-lsahn@wewakecorp.com>
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jul 15, 2023 at 05:22:04PM +0900, Leesoo Ahn wrote:
> Return -EOPNOTSUPP instead of -EINVAL which has the meaning of

EOPNOTSUPP is the wrong errno.  ENOTTY is "more" correct.

By the way, don't send v2 just because Markus has picked at a nit.
Wait for substantive feedback.