Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp3844112rwp; Sat, 15 Jul 2023 10:29:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlH4MjS0S1BrtsfegFOxEBlTLOOqLG1DZlbUWrDBWnmaDx82+/apWZ3aibgZ/eoRhy3KPi8o X-Received: by 2002:a05:6a00:8d3:b0:677:bb4c:c321 with SMTP id s19-20020a056a0008d300b00677bb4cc321mr3693063pfu.0.1689442173659; Sat, 15 Jul 2023 10:29:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689442173; cv=none; d=google.com; s=arc-20160816; b=sxgFzSLwhrrBMMkpCyGGX5OuJPqdf2wNIi7hby0t+i7ACndkho+TgtnXMuPb6PHKz3 Pw11fjByNeghfuBaD9Yp4DJ9Qh/lloVYSnb4Wk+Dg+1M/ehq6h+9G2Jf1n89TOSb/bZC emqXgwNd4pxef4iv6epOifLMDkD5mymFq4IABjRTlrDGVduK/hHgM2uvO6pLxp9Pj4Xa Q9+S/xO/GaqBqC/YL+C48Y2ZC783ZMm3BAUfCHAMLWQ64bOTe54JnJ6IYnh7IpMo4tip yP3Cg4iRfhly5Q3PrIIpcoS7AM0a35C69P9qCCIY+ukKWRsPXykpOtfHDRBIH/ufisPc byDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fhOJU2QYRw24rNNIIDEPTDWF78Rd0G+6iDEmVYYFPQk=; fh=x07qdGu0xmUVm51MfsaBT1/rbcOwfte7l4r3CCws/P8=; b=t/gaaYKq5BFSncnUmFENzXj+PMUs6ZSPCd8ZUabJF19g19O7VS9gKXq/R26GjMQl02 bUcGSkjS03cIaQte/xxkNpsyHL8wk9ucnvVpj0lB2wDXweCuVQjBw7pPLnZ0Y3wDqVbl i82Oz9YYMbI8JyW17du/lB4CTLI6T3Fsj3+z6zHh0EFI5+nTRyPp9jByANjQKesspN9P hV/cTgi8hH2q/jjjFNc90yRrTrW66Mu+blD1NDhppAzfU/oHOz3HRS3wZVv4cHMxpw+R gwUJi9NQT0HyMs98UAx35X7+IjQN2WVJUU3D5qfaR4C6NYrYwf/Ru+rAAWdWOqK22CSS hhog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k9TOh4ZD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bw27-20020a056a00409b00b0068250ef5920si8957129pfb.67.2023.07.15.10.29.21; Sat, 15 Jul 2023 10:29:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k9TOh4ZD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230290AbjGORFj (ORCPT + 99 others); Sat, 15 Jul 2023 13:05:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjGORFi (ORCPT ); Sat, 15 Jul 2023 13:05:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 303E7B5; Sat, 15 Jul 2023 10:05:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B761760BD4; Sat, 15 Jul 2023 17:05:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0321C433C8; Sat, 15 Jul 2023 17:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689440736; bh=ncuBs4kxzk2VlZm7kfJfgZlSPKeTybZkTtdYydKCK18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k9TOh4ZDaNP4erpFLfnmoiw+h2TmkSY9NJv0apQm7CqXF3xU7UZA22oYIy3CmWXDL S21PAMmPfcahzR3TC+SMWaYnKmDOIo4smNCrXt7gjGhtg86ICAxGeLV31ZUNCgTqZo jcQoa016QrvOmJIxM0rCJbcdMTyDqTwvTuBTnlVWG69hTO22gQbWUtqM97oifq+5pE 1OM/nEiN/Nen1hIEM9lM3vNcoq4fuwL4uqc+acilKzQZ60iocC+Ro/lD6cewlLWdvi eTaH9UxQLTgWebkdKCwnsKufKpIPtYIpVK+kTCgbKftUxiSk+TGmXAMBikgX7+G4AN fiKJQAUS7Lsmw== Date: Sat, 15 Jul 2023 10:09:03 -0700 From: Bjorn Andersson To: Georgi Djakov Cc: Konrad Dybcio , Andy Gross , Michael Turquette , Stephen Boyd , Leo Yan , Evan Green , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Dmitry Baryshkov , Stephan Gerhold Subject: Re: [PATCH v7 00/22] Restructure RPM SMD ICC Message-ID: References: <20230526-topic-smd_icc-v7-0-09c78c175546@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 13, 2023 at 08:37:57PM +0300, Georgi Djakov wrote: > On 19.06.23 16:04, Konrad Dybcio wrote: > > This series reshuffles things around, moving the management of SMD RPM > > bus clocks to the interconnect framework where they belong. This helps > > us solve a couple of issues: > > [..] > > Thank you, Konrad! > > Acked-by: Georgi Djakov Thank you, Georgi. I've applied the patches to a branch based on v6.5-rc1, merged that into the qcom-tree and pushed the branch. Regards, Bjorn The following changes since commit 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5: Linux 6.5-rc1 (2023-07-09 13:53:13 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git 20230526-topic-smd_icc-v7-0-09c78c175546@linaro.org for you to fetch changes up to 17fc623e0f728c35b82a0e79cd4f3b8aab495663: interconnect: qcom: icc-rpm: Fix bandwidth calculations (2023-07-15 09:54:45 -0700) ---------------------------------------------------------------- Konrad Dybcio (21): dt-bindings: interconnect: Add Qcom RPM ICC bindings soc: qcom: smd-rpm: Add QCOM_SMD_RPM_STATE_NUM soc: qcom: smd-rpm: Use tabs for defines clk: qcom: smd-rpm: Move some RPM resources to the common header interconnect: qcom: icc-rpm: Introduce keep_alive interconnect: qcom: Add missing headers in icc-rpm.h interconnect: qcom: Fold smd-rpm.h into icc-rpm.h interconnect: qcom: smd-rpm: Add rpmcc handling skeleton code interconnect: qcom: Define RPM bus clocks interconnect: qcom: sdm660: Hook up RPM bus clk definitions interconnect: qcom: msm8996: Hook up RPM bus clk definitions interconnect: qcom: qcs404: Hook up RPM bus clk definitions interconnect: qcom: msm8939: Hook up RPM bus clk definitions interconnect: qcom: msm8916: Hook up RPM bus clk definitions interconnect: qcom: qcm2290: Hook up RPM bus clk definitions interconnect: qcom: icc-rpm: Control bus rpmcc from icc clk: qcom: smd-rpm: Separate out interconnect bus clocks interconnect: qcom: icc-rpm: Fix bucket number interconnect: qcom: icc-rpm: Set bandwidth on both contexts interconnect: qcom: icc-rpm: Set correct bandwidth through RPM bw req interconnect: qcom: icc-rpm: Fix bandwidth calculations Stephan Gerhold (1): soc: qcom: smd-rpm: Move icc_smd_rpm registration to clk-smd-rpm drivers/clk/qcom/clk-smd-rpm.c | 314 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- drivers/interconnect/qcom/Makefile | 2 +- drivers/interconnect/qcom/icc-rpm-clocks.c | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/interconnect/qcom/icc-rpm.c | 220 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------------------- drivers/interconnect/qcom/icc-rpm.h | 56 +++++++++++++++++++++++++++++++++++++++++++++----------- drivers/interconnect/qcom/msm8916.c | 5 +++-- drivers/interconnect/qcom/msm8939.c | 6 ++++-- drivers/interconnect/qcom/msm8974.c | 2 +- drivers/interconnect/qcom/msm8996.c | 10 +++++++--- drivers/interconnect/qcom/qcm2290.c | 8 ++++++-- drivers/interconnect/qcom/qcs404.c | 5 +++-- drivers/interconnect/qcom/sdm660.c | 8 +++++--- drivers/interconnect/qcom/smd-rpm.c | 23 ++++++++++++++++++++++- drivers/interconnect/qcom/smd-rpm.h | 15 --------------- drivers/soc/qcom/smd-rpm.c | 17 +---------------- include/dt-bindings/interconnect/qcom,rpm-icc.h | 13 +++++++++++++ include/linux/soc/qcom/smd-rpm.h | 20 ++++++++++++++++++-- 17 files changed, 456 insertions(+), 345 deletions(-) create mode 100644 drivers/interconnect/qcom/icc-rpm-clocks.c delete mode 100644 drivers/interconnect/qcom/smd-rpm.h create mode 100644 include/dt-bindings/interconnect/qcom,rpm-icc.h