Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp3928724rwp; Sat, 15 Jul 2023 12:19:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlE2yxa6NZsDOHSjaQIYwuGq9MGhwmClAbSPtwiXbwbiXMLRTwrC51+ZVF06wvqUl9FXd7os X-Received: by 2002:a17:902:e804:b0:1b8:a277:4b5b with SMTP id u4-20020a170902e80400b001b8a2774b5bmr8450058plg.7.1689448782059; Sat, 15 Jul 2023 12:19:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689448782; cv=none; d=google.com; s=arc-20160816; b=wz1qZxh5eeCHx9TsudEXMQXTReM3TS/NnNA0qiUT4TS1lag7s4LKjPoFgvo1aKX3E0 5b4YKEoLXJbX51PIWTv41FZCvb1e3ukYuBHZtlZKVvxReZA6/c6Em285aTPzG3WD8uWl WvdAIVo2E1U+BqJKUNOISmjQzz4pgKuAMSlBWm0/YjwU6xs44aiSPje8YRUfjBX6wUDL H51OL6EhPmg9I2jkpvy2B8ySzJLIrhC1JRl6h2SO+JWXtoT2avbiVipm9QbGrmNKh/0p 0qiQnJjyfSeCx1pQ6in+SKJ3x8YOFwuMFiOuSxZxxunTUFmhWXDblZHFwA54CJuil0B5 Jd4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=85l2ukO3ODIPQ6vFxAUAj342VQosexDKbJyC6X6EE14=; fh=YTnRr2rtaOv/simLXC1tQC1/aSnRMsRamdiQFO2K3GA=; b=tqU1X7C+Iu2wxSEYbM2jqZM7NiwoZdYWyqd6x86AuChXd9BH9yD9K/L1G3NVEYCVBB hdigaOEu3dYUYPFxeF6321Yqk2diCZcQTsRjhyFceouk/zpOPtpYCdv6VhDrmMYKk2h6 QNGsa/UoqGfRn63eo/M/lgJLaNTUBQbgFQbC+dWH23hOSeXFNedv5ZmzqRJ4l1IX1/ny vZu4B2jw16kBx1YhHCH8QgtKm9qPFEMu4eVsHRsTBMMvUNCqW/7lu3y2bNp6vqL0dKYf HYAhs32FssnGvjTpJU4vMr7J1jXiD/Fhi2R7Q0BoQx0pEo897HRJEMpLqG7d2dQT+Akv gkQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=q+wmO2L7; dkim=neutral (no key) header.i=@suse.de header.b="B8Oqy/BZ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u12-20020a170903124c00b001b8c6f80ddbsi9446312plh.105.2023.07.15.12.19.29; Sat, 15 Jul 2023 12:19:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=q+wmO2L7; dkim=neutral (no key) header.i=@suse.de header.b="B8Oqy/BZ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231362AbjGOSye (ORCPT + 99 others); Sat, 15 Jul 2023 14:54:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230497AbjGOSyC (ORCPT ); Sat, 15 Jul 2023 14:54:02 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 278123580; Sat, 15 Jul 2023 11:53:59 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 14E0E21B07; Sat, 15 Jul 2023 18:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689447233; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=85l2ukO3ODIPQ6vFxAUAj342VQosexDKbJyC6X6EE14=; b=q+wmO2L7THxUtdrTQjB/LLyhfeV5dy5BggvtU0z2+qjj/UnEzx9JPCNdDdBfjjx8DDIw19 Sv0avuzwuGHVNqs4jMSnD7kFT0It0RpxCbIHytPlak2zQrtTJKAIWmdOMbfML4oaf0FXoC RIxu4ZmN2o9LSF2EEqwcGcjucqh3tRI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689447233; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=85l2ukO3ODIPQ6vFxAUAj342VQosexDKbJyC6X6EE14=; b=B8Oqy/BZp1yACjXJ0JzvToLBfwr0tFR66oZ/zhoyhyomVAU8oE5h6tGMzoSY6RNTzmKSJU 2XFd87XMxEkwqfBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9982713A23; Sat, 15 Jul 2023 18:53:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KMMxJEDrsmQCBwAAMHmgww (envelope-from ); Sat, 15 Jul 2023 18:53:52 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com, geert@linux-m68k.org, dan.carpenter@linaro.org Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Thomas Zimmermann , Sam Ravnborg Subject: [PATCH v4 16/18] fbdev/pxafb: Remove flag FBINFO_FLAG_DEFAULT Date: Sat, 15 Jul 2023 20:51:58 +0200 Message-ID: <20230715185343.7193-17-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230715185343.7193-1-tzimmermann@suse.de> References: <20230715185343.7193-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Helge Deller --- drivers/video/fbdev/pxafb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index c8c4677d06b4..beffb0602a2c 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -888,7 +888,6 @@ static void init_pxafb_overlay(struct pxafb_info *fbi, struct pxafb_layer *ofb, ofb->fb.var.vmode = FB_VMODE_NONINTERLACED; ofb->fb.fbops = &overlay_fb_ops; - ofb->fb.flags = FBINFO_FLAG_DEFAULT; ofb->fb.node = -1; ofb->fb.pseudo_palette = NULL; -- 2.41.0