Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 15 Jul 2023 21:24:16 +0000
To:     linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        Mark Gross <markgross@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Armin Wolf <W_Armin@gmx.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
From:   =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>
Subject: [RFC PATCH v1] platform/x86: wmi: Do not register driver with invalid GUID
Message-ID: <20230715211604.1272227-1-pobrn@protonmail.com>
Feedback-ID: 20568564:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Since a WMI driver's ID table contains strings it is relatively
easy to make mistakes. At the moment, there is no feedback
if any of the specified GUIDs are invalid (since
028e6e204ace1f080cfeacd72c50397eb8ae8883).

So check if the GUIDs in the driver's ID table are valid,
print all invalid ones, and refuse to register the driver
if any of the GUIDs are invalid.

Signed-off-by: Barnab=C3=A1s P=C5=91cze <pobrn@protonmail.com>
---
 drivers/platform/x86/wmi.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index a78ddd83cda0..bf0be40b418a 100644
--- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -1513,6 +1513,19 @@ static int acpi_wmi_probe(struct platform_device *de=
vice)
 int __must_check __wmi_driver_register(struct wmi_driver *driver,
 =09=09=09=09       struct module *owner)
 {
+=09bool any_id_invalid =3D false;
+
+=09for (const struct wmi_device_id *id =3D driver->id_table; *id->guid_str=
ing; id++) {
+=09=09if (!uuid_is_valid(id->guid_string)) {
+=09=09=09pr_err("driver '%s' has invalid GUID: %s",
+=09=09=09       driver->driver.name, id->guid_string);
+=09=09=09any_id_invalid =3D true;
+=09=09}
+=09}
+
+=09if (any_id_invalid)
+=09=09return -EINVAL;
+
 =09driver->driver.owner =3D owner;
 =09driver->driver.bus =3D &wmi_bus_type;
=20
--=20
2.41.0