Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3e99caed-13bb-204c-4458-e0670fa9e8c9@gmail.com>
Date:   Sun, 16 Jul 2023 14:58:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4] gpio: mmio: handle "ngpios" properly in bgpio_init()
To:     Linus Walleij <linus.walleij@linaro.org>,
        Asmaa Mnebhi <asmaa@nvidia.com>
Cc:     andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= <noltari@gmail.com>
References: <20230306211237.14876-1-asmaa@nvidia.com>
 <CACRpkdZoVo-6BMYcuike2eC85ZGpP93_4WQVLTfjRAa1ho5xhg@mail.gmail.com>
Content-Language: de-DE
From:   Christian Lamparter <chunkeey@gmail.com>
In-Reply-To: <CACRpkdZoVo-6BMYcuike2eC85ZGpP93_4WQVLTfjRAa1ho5xhg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/16/23 09:42, Linus Walleij wrote:
> On Mon, Mar 6, 2023 at 10:12 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
> 
>> bgpio_init() uses "sz" argument to populate ngpio, which is not
>> accurate. Instead, read the "ngpios" property from the DT and if it
>> doesn't exist, use the "sz" argument. With this change, drivers no
>> longer need to overwrite the ngpio variable after calling bgpio_init().
>>
>> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thank you!

For context:
<https://patchwork.kernel.org/project/linux-arm-kernel/patch/535f785bf6116c0fb6f46afbb77e6d4bd3ef5f60.1462543458.git.chunkeey@googlemail.com/>

Regards,
Christian