Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Rahul Rameshbabu <rrameshbabu@nvidia.com>
To:     Fabio Baltieri <fabiobaltieri@chromium.org>
Cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] HID: hid-google-stadiaff: add support for Stadia
 force feedback
References: <20230709214410.3676224-1-fabiobaltieri@chromium.org>
        <878rbidwn5.fsf@nvidia.com> <ZLQ5XMobES0r6Fel@google.com>
Date:   Sun, 16 Jul 2023 11:47:53 -0700
In-Reply-To: <ZLQ5XMobES0r6Fel@google.com> (Fabio Baltieri's message of "Sun,
        16 Jul 2023 18:39:24 +0000")
Message-ID: <87zg3vr8va.fsf@nvidia.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ie46plRmAafgYEvYGpjQG52qOUpS+ErqAl0C+sm+A6OPTEACy/Dg3kV4f2He?=
 =?us-ascii?Q?laOhz24rCebi5jxJjSlcC+fL27nskhj0m4ZhIr4jQpRoK/ZHrwNZGB+9GaFJ?=
 =?us-ascii?Q?L9XquZgL7UqjFabawA8jTtAG/djnX0Kl51WMRHRiI76QG0OKRlwT3O+HH7H+?=
 =?us-ascii?Q?9mC18FoG6/m5Rgu0T2xiLNThyFBiGg0AYAQauK6BxRqmG+X6AU8O7lQ8ja8J?=
 =?us-ascii?Q?tghp7Y1Ah6zKznnkjehWP1C8IERzpEdBWNp4LjifGGgbB1ht13kECs2EIGnl?=
 =?us-ascii?Q?rT45yxmBF6eNzUbJzy/JnZ5l+fWGVz5f0OuR8hr9Z5h6eUgnHX0p8N2kk1pn?=
 =?us-ascii?Q?gndx24SO4/6wGqgsJUKzG2fdr2JRiMk+FraF/pMC6v1GhViGezrITc7IIOaN?=
 =?us-ascii?Q?pWVzewjWk4lznP/2TvkhF7g4lmzb6RW5XK+kgQuCQZYg1DvmH1KWxPJ6HQnt?=
 =?us-ascii?Q?0hztyFPlgCbmmqs+VIHBFUTZPMHB7VFgolUt1ONDorzbk0sZRTyxTtfHRJwW?=
 =?us-ascii?Q?+dO7AHMEgJ+Gx+lYnULGOY5XzbY+1tI35c1HE7QAJWOwjbxoYPGt3dTN+oUJ?=
 =?us-ascii?Q?gxkIwLZdGd5EhsFj2xDFmOkd0deIhwXUNBRXQ3IiIuTPUJdkHacURyqU0ftI?=
 =?us-ascii?Q?7/LTypQIf8WoCHqwWhDutexlItfAzGwMycwaDXV79KQUn8hrAH7QM4sqqmRF?=
 =?us-ascii?Q?xj59L90G572fcM1tnTUaiNyHDNHyuyorpVjA89OVAioLr05e+073PVyrCtgV?=
 =?us-ascii?Q?zqmlZluY7gKphJwApdfBjiOIi0zd2GOU8MFciWh78DUFqyfqwWvP7k13xiXv?=
 =?us-ascii?Q?YYV29GHnvYj/TL5iBrSpaSpqyTbKjiRoDjy6myl2IZVFOjX6cSi4wXaRChFT?=
 =?us-ascii?Q?53T/Pcj1k5aoCOrn/7+AVhYSdZvgJZytXnQc/jpwX+GMlbX0i8NmshXvOXCx?=
 =?us-ascii?Q?PgDBN9LGHwncUx4KYwxyp7WHRBDo1Z81TfsDoP66HjEdO8bmbzEh9DgddQYk?=
 =?us-ascii?Q?eyJkVZ+/5+pNdy7abUgVTaE4BAPjd60co1+E/RJWpKZdqSbK+L5/sShqHpJX?=
 =?us-ascii?Q?nWRyEfvG+4pJCpILxMzMolY8/Vl5/9GQiLdSnZ4yOLaGLBbjLkYnl/vgfWV9?=
 =?us-ascii?Q?svmpZ7a0hsKqSgSB01Zbmt3adFsNApfGIMdbCQvQn3xf7V9jr/Kyh2ulwGtT?=
 =?us-ascii?Q?CM8I2Aizdy+1BTPStGFPnsOc/qugLNhlMkZiYoeRZwIMFAHCf9CBF7GIUUIQ?=
 =?us-ascii?Q?4t+VBfeIao+hzIBLbpLvaJVWt/8uviWlyFuwkBRzeUy3R5AiWpzqrEKfO1GF?=
 =?us-ascii?Q?O6IynYMF6zv6H6Lr6nspm43SFSNKmkaxStLVBJ3OFzaQHu52Eg2k1bddIJ2m?=
 =?us-ascii?Q?X+tRuRscsTndS5iG7uOYlvWJskdgY1clK6T9qGhKhCUAYBjH1GgIZNpX+XMg?=
 =?us-ascii?Q?X5HvouNWVfHAfXfmfxUgm9mj22UNGwtYQlGWCN6yFsFaQfVUPN7jd9XQ0tAW?=
 =?us-ascii?Q?S5czBaPtn7dMZ7VHDixPXPriRnJQvapaVHMNXX7ACQ7ng+DkCDO5ZwZEiBgA?=
 =?us-ascii?Q?dKFOq/vgNbGY+sLeTdTmS1T8y1F03n5QrHCuV4JVnbprZ7QCrzKzL4Vn6Q1C?=
 =?us-ascii?Q?Bw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e080de3e-47d9-4519-339d-08db862d3142
X-MS-Exchange-CrossTenant-AuthSource: BN7PR12MB2740.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2023 18:48:06.3483
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qBR/khCxNj8zlSDqQwJNHaYx5cxv98eaaVw84kpZz6836IkLBCyyg8J2CMo7oCbfsCv00b+FaSItUABtdVqPkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4293
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 16 Jul, 2023 18:39:24 +0000 Fabio Baltieri <fabiobaltieri@chromium.org> wrote:
> Hi Rahul,
>
> On Fri, Jul 14, 2023 at 02:13:34PM -0700, Rahul Rameshbabu wrote:
>> On Sun, 09 Jul, 2023 21:44:10 +0000 Fabio Baltieri <fabiobaltieri@chromium.org> wrote:
>> > Add a hid-stadiaff module to support rumble based force feedback on the
>> > Google Stadia controller. This works using the HID output endpoint
>> > exposed on both the USB and BLE interface.
>> >
>> > Signed-off-by: Fabio Baltieri <fabiobaltieri@chromium.org>
>> > ---
>> > +static int stadia_probe(struct hid_device *hdev, const struct hid_device_id *id)
>> > +{
>> > +	int ret;
>> > +
>> > +	ret = hid_parse(hdev);
>> > +	if (ret) {
>> > +		hid_err(hdev, "parse failed\n");
>> > +		return ret;
>> > +	}
>> > +
>> > +	ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT & ~HID_CONNECT_FF);
>> > +	if (ret) {
>> > +		hid_err(hdev, "hw start failed\n");
>> > +		return ret;
>> > +	}
>> > +
>> > +	ret = stadiaff_init(hdev);
>> > +	if (ret) {
>> > +		dev_err(&hdev->dev, "force feedback init failed\n");
>> 
>> Error handling looks good to me now. Is there any particular reason you
>> use dev_err here instead of hid_err here?
>
> Not really, copied from another hid driver and did not realize the
> inconsistency. I'll fix that up and send a v4.
>
> Thanks again for spotting this!

No worries. Btw, in your commit message body, you might want to change
hid-stadiaff to hid-google-stadiaff as well for your v4 submission.

Thanks,

-- Rahul Rameshbabu