Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 16 Jul 2023 21:55:52 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Florian Fainelli <florian.fainelli@broadcom.com>,
        stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Backporting commits for generating rpi dtb symbols to stable
Message-ID: <20230716195552.kcvjhowowxdbhyyt@pali>
References: <20230716162444.zzvkm4rh7s7lu37x@pali>
 <ZLRJaiIfPtqEB9Vb@aurel32.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZLRJaiIfPtqEB9Vb@aurel32.net>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Sunday 16 July 2023 21:47:54 Aurelien Jarno wrote:
> Hi,
> 
> On 2023-07-16 18:24, Pali Rohár wrote:
> > Hello,
> > 
> > I see that raspberry pi bootloader throws ton of warnings when supplied
> > DTB file does not contain /__symbols__/ node.
> > 
> > On RPI 1B rev1 it looks like this:
> > 
> > dterror: no symbols found
> > dterror: no symbols found
> > dterror: no symbols found
> > dterror: no symbols found
> > dterror: no symbols found
> > dterror: no symbols found
> > dterror: no symbols found
> > dterror: no symbols found
> > dterror: no symbols found
> > dterror: no symbols found
> 
> Do you have those errors with the default configuration? On a RPI 4,
> this only happens when setting uart_2ndstage to 1 in config.txt.
> According to the documentation, this option enables diagnostic
> information from the main firmware.

Yes, I have it with default configuration. And I really do not know why
it is happening, I just described observations and that dtc -@ fixes
this issue. Note that this is about 1b rev1 (the first revision); so the
older HW, so maybe this can be a reason?

> Unless this is different on RPI 1B, this means we are talking about a
> warning that happens when enabling diagnostic information, so I am not
> sure it warrants a change to stable kernels.

Well, that is why I asked, if it is something for stable or not.

> Regards
> Aurelien
> 
> -- 
> Aurelien Jarno                          GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net                     http://aurel32.net