Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <40cbc39e-5179-c2f4-3cea-0a98395aaff1@intel.com>
Date:   Mon, 17 Jul 2023 07:59:50 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [RFC PATCH v2 3/3] mm: mlock: update mlock_pte_range to handle
 large folio
Content-Language: en-US
To:     Yu Zhao <yuzhao@google.com>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <akpm@linux-foundation.org>, <willy@infradead.org>,
        <david@redhat.com>, <ryan.roberts@arm.com>, <shy828301@gmail.com>
References: <20230712060144.3006358-1-fengwei.yin@intel.com>
 <20230712060144.3006358-4-fengwei.yin@intel.com>
 <CAOUHufYef--8MxFettL6fOGjVx2vyZHZQU6EEaTCoW0XBvuC8Q@mail.gmail.com>
 <CAOUHufZ6=9P_=CAOQyw0xw-3q707q-1FVV09dBNDC-hpcpj2Pg@mail.gmail.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <CAOUHufZ6=9P_=CAOQyw0xw-3q707q-1FVV09dBNDC-hpcpj2Pg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0x2bURBZWdoSkZ0MDVaRW5jN2FMaXAxeThqc3ByZjhrengwZENJZ25haFkr?=
 =?utf-8?B?KzZUcEVSL1FTb1prUWxUVHlRZnZPVjRWU3c1U3EybDFWZG5tcmJzZWpaTGZS?=
 =?utf-8?B?bGZ2a0FuMGJuQ1lNUDJJTlcySGtSN3prVG55TmxsVEs1emtsRVdNdURWZ2F5?=
 =?utf-8?B?RlYxYndVQXJJRDE2anVoWkV3aEFkVVVDcDdxcjl2VmNQVTJqZVFKeHFzQzNk?=
 =?utf-8?B?enlrWk1odW9oMkVkZ1NYTmxUVG1zMk5IaE9FaUZTY2cvT2ovV3Vuc3hhZkt3?=
 =?utf-8?B?NWZ0V3hUemRiQS92UDJmRnVnVjhxR2pFOTdHS3JnMXVDUGRsemZRTE4zc3Ra?=
 =?utf-8?B?UWZDNnNtM09HUkExdGU5YkVQdGJiWWdIcG5Ed3ExSXd5Si9nNi9qaUpHNDRk?=
 =?utf-8?B?dlo5SHFBUDJLeklnc09xdC9DajZkS0taZ3NkbUFpVjN5b2VualBVY2Zhd1Zq?=
 =?utf-8?B?Qjh3NHhQR1h2MlpKb254YVFONWUrSUpGM1F0akF1SFJzYTYxdkh4NjlHWnYz?=
 =?utf-8?B?NEhxKzNkeGdUYXl0RDVobG5YMDNhVE9PRnNpL2NJYWZnNzdKcmFIYUZ3TXo1?=
 =?utf-8?B?QVR4Q0V2ak1MMHJLajBQSzBFVkRsNVBIa0dlRmV5d1VLWGdrU0x0aTlDcmNM?=
 =?utf-8?B?QVdXcFhCWmFGbXlBak1iL1plUUFySjlaSlJpVytmMWFzODdVUEg1U2tzczBi?=
 =?utf-8?B?MVhzYXQ3RDhmRnFyRlRmRTVrQWo4OFlyRzNpVzM4c21DRG56c3FKT1puTDZY?=
 =?utf-8?B?L0RsR3BzMEt5cExEUnE1N1c1cHh0OHVoMHVKSWVnK3pMai9Td1p5Mlg4cXlQ?=
 =?utf-8?B?bDJvWFJLbjFmQnNBZ05uY0I3blQrT3NVOFA5UE4xb1p5cnpRa05LZmVrYld3?=
 =?utf-8?B?NndSc05qbzZlUzAzNHpyU1FxSC9QeVZqNC9ZMmlqc2pNZDIwdkFFZHZrQVp2?=
 =?utf-8?B?aFNheW1XMzI4RGZjWUc4UDQvN05HTHBkWDZOWlhIYlgrNWpnVnNEeTdwc284?=
 =?utf-8?B?NTRKeEtvZGZOZktjMlp1VWVYRktodkVLMmZJZXQvZGRoQzdnQlI4OHZOd0ZS?=
 =?utf-8?B?QnV1M3RhS09lNnlRbjYwQkk1QU1xYVR3RVl3K3BRU3lvdXhZOWZXNU5VQXl3?=
 =?utf-8?B?UVMzTHRxZEdRcDNvQjhLVmZlaWdqa3NYSjAwM2lTWlJpT1FEdWJudHFodEJZ?=
 =?utf-8?B?VWtuM2VsVjZUdkJ3bk1zdm5NUHJtS0N4cXVKVlN6YkFVUkZwSkhxUzhTMm0v?=
 =?utf-8?B?b1VPZ2E2d3ZKUmkrVEl1SU00WXl2cG9hL1hMMnVUck1BbTlWVFRBUERYZFd3?=
 =?utf-8?B?Q2p1bGNjUHJDd0gzcmpHdk52STNoUUpnSWk2Y3JaMUlMaTlxQ1dYQzFEK1dl?=
 =?utf-8?B?Q0JPR0RGZTJzL1lnYWhoZUNHZ1A4YXhHaEhtWjIvVXBqa1pIdXVUU3hiYld5?=
 =?utf-8?B?Y0c4bXFuVDVjL1Y4bXNCeWpzSFpYU3dJNDJNQ3MyRU1GZnVseVBlLy9HcWsr?=
 =?utf-8?B?am0xekF1dCtBZ0JMNytKSC8zZWFuNkVOd1VteWVQR2VhRTgwazJqMVBseVRT?=
 =?utf-8?B?Y085YVlWenkzeTJ4QnhjVEgwS2loRWNTTi9MbEpPbVFkak81dE1HenZWWk9h?=
 =?utf-8?B?Y1puY0NaYmZZQWE4TExiZml5OVNzQ2hLdU5CWUVmcG93cDRIeDlyUkVnVGgx?=
 =?utf-8?B?Q3d0NHFyY0sxYURBZ2t5R1RUQkd1bkVsK1U3ekJoQjhyellpLzNvY1ExMVlV?=
 =?utf-8?B?d3VsVHpPK0JJcmwyNmF2c3EySHZ1NUhTYjc4TFdzZ09oa3ZESk9jNFB5V2dY?=
 =?utf-8?B?dFRQZFVKZFIxY0QwSjRUYWVLeHFDNkJQWkdlbDIxSGxaeFVQN2NsaE41OGJv?=
 =?utf-8?B?djlWYTgzV3ZvTEsrOFM1UkZ2V1JkZUdPdnhrNkJta01NaDNhekFUU2FHeHNG?=
 =?utf-8?B?ZlY0cm9IbG1FM2FFZWplZWR4VU90VUQ5TjJkL09qSER1NktuUkRsbU5iQXVx?=
 =?utf-8?B?c1Z5blh4QitiWThKTnFiMjlveWZzRXd5RndjYnVtQ3FsYm9GbnN1OXJpM0Uw?=
 =?utf-8?B?RGNVaU53MzlSZGZnUlgzT0UxRVNzeWxoZU5UVU1oYlJPSDNNY3lXVExhZUIr?=
 =?utf-8?B?ZjI1WkRFdXNUU3lCVGlHV3FxbnFyczlXOHB1TmFwN28wYXRZS21CR241VEhO?=
 =?utf-8?B?c0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 73c89f81-32eb-4117-bdae-08db8658c33d
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2023 23:59:59.6346
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dVZpOaMgPAy6JXihEaFB8rchEgj3+JVgzzgyCs+waawQktW6CJpqHJYe/woU7kJU6mKydXTj78rkjIa3H2pQDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7104
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/15/2023 2:06 PM, Yu Zhao wrote:
> There is a problem here that I didn't have the time to elaborate: we
> can't mlock() a folio that is within the range but not fully mapped
> because this folio can be on the deferred split queue. When the split
> happens, those unmapped folios (not mapped by this vma but are mapped
> into other vmas) will be stranded on the unevictable lru.
This should be fine unless I missed something. During large folio split,
the unmap_folio() will be migrate(anon)/unmap(file) folio. Folio will be
munlocked in unmap_folio(). So the head/tail pages will be evictable always.

> 
> For that matter, we can't mlock any large folios that are being
> shared, unless you want to overengineer it by checking whether all
> sharing vmas are also mlocked -- mlock is cleared during fork. So the
> condition for mlocking large anon folios is 1) within range 2) fully
> mapped 3) not shared (mapcount is 1). The final patch should look like
> something like this:
> 
> -  if (folio_test_large(folio))
> +  if (folio_pfn(folio) != pte_pfn(ptent))
> +    continue;
> +  if (!the_aforementioned_condition())
> 
> There is another corner case I forgot to mention: for example, what if
> a folio spans two (the only two) adjacent mlocked vmas? No need to
> worry about this since it's not worth optimizing.
Yes. The behavior will be related with whether the folio is mlocked or not.
But the worst case is the folio is split and each page is mlocked during
next scan again.


Regards
Yin, Fengwei