Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <0b2e2708-b658-1640-1ebd-4c84c3552714@roeck-us.net>
Date:   Sun, 16 Jul 2023 17:01:55 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 6.1 000/591] 6.1.39-rc1 review
Content-Language: en-US
To:     =?UTF-8?Q?Daniel_D=c3=adaz?= <daniel.diaz@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     stable@vger.kernel.org, patches@lists.linux.dev,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com,
        f.fainelli@gmail.com, sudipm.mukherjee@gmail.com,
        srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org
References: <20230716194923.861634455@linuxfoundation.org>
 <CAEUSe7-XjSvLKxFuHbKUrJBWAmgKRg5oZRppnDYn1CuoWCUURw@mail.gmail.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <CAEUSe7-XjSvLKxFuHbKUrJBWAmgKRg5oZRppnDYn1CuoWCUURw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/16/23 16:40, Daniel Díaz wrote:
> Hello!
> 
> On Sun, 16 Jul 2023 at 14:31, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>> This is the start of the stable review cycle for the 6.1.39 release.
>> There are 591 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Tue, 18 Jul 2023 19:48:07 +0000.
>> Anything received after that time might be too late.
>>
[ ... ]
> We're seeing build failures on i386 and x86 with Clang:
> -----8<-----
> /builds/linux/block/blk-cgroup.c:1238:6: error: variable 'ret' is used
> uninitialized whenever 'if' condition is true
> [-Werror,-Wsometimes-uninitialized]
>          if (init_blkcg_llists(blkcg))
>              ^~~~~~~~~~~~~~~~~~~~~~~~
> /builds/linux/block/blk-cgroup.c:1288:9: note: uninitialized use occurs here
>          return ret;
>                 ^~~
> /builds/linux/block/blk-cgroup.c:1238:2: note: remove the 'if' if its
> condition is always false
>          if (init_blkcg_llists(blkcg))
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /builds/linux/block/blk-cgroup.c:1223:33: note: initialize the
> variable 'ret' to silence this warning
>          struct cgroup_subsys_state *ret;
>                                         ^
>                                          = NULL
> 1 error generated.
> ----->8-----
> 
> More info to follow soon.
> 

Caused by 3b8cc6298724 ("blk-cgroup: Optimize blkcg_rstat_flush()")
which is missing its prerequisite b5a9adcbd5dc ("blk-cgroup: Return
-ENOMEM directly in blkcg_css_alloc() error path"). With three Fixup:
patches following, it is one of those patches where I wonder if it
is worth the trouble.

Guenter