Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <16844254-7248-f557-b1eb-b8b102c877a2@intel.com>
Date:   Mon, 17 Jul 2023 09:58:39 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [RFC PATCH v2 3/3] mm: mlock: update mlock_pte_range to handle
 large folio
Content-Language: en-US
To:     Yu Zhao <yuzhao@google.com>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <akpm@linux-foundation.org>, <willy@infradead.org>,
        <david@redhat.com>, <ryan.roberts@arm.com>, <shy828301@gmail.com>
References: <20230712060144.3006358-1-fengwei.yin@intel.com>
 <20230712060144.3006358-4-fengwei.yin@intel.com>
 <CAOUHufYef--8MxFettL6fOGjVx2vyZHZQU6EEaTCoW0XBvuC8Q@mail.gmail.com>
 <CAOUHufZ6=9P_=CAOQyw0xw-3q707q-1FVV09dBNDC-hpcpj2Pg@mail.gmail.com>
 <40cbc39e-5179-c2f4-3cea-0a98395aaff1@intel.com>
 <CAOUHufZHyEvU-c2O6B6stM_QVMxc22zV4Szn52myYqjdZvptUA@mail.gmail.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <CAOUHufZHyEvU-c2O6B6stM_QVMxc22zV4Szn52myYqjdZvptUA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1lIZHpRUzAwWkJBM00rdW8xRUp6cDRIR0d3Z3RZbStzU1RaUmVKT2NMQStQ?=
 =?utf-8?B?eW16Mk9IdUo3ODlUZE00TlVTZk9NenJmeTlWMVpoMmhPWmt6ZFpieW91bUY2?=
 =?utf-8?B?L0V5dVdZdDFmYllPRWxDc2x0Mjk2eTVic1BhcmNKN0IyMk1nNGl4UUMwK2VP?=
 =?utf-8?B?Z1Y1VkV4NW1heFNESTBZV3hMTCtjbTI3RXhpNzdXUzI5UVYvVk1jN0J3Q2xL?=
 =?utf-8?B?a3VKajM2QUlqcWpxVVdZakYyYTBYL3FjTEdpQUpybFlxRjJMbUhVMmg3eVlh?=
 =?utf-8?B?ZGRHMkUzbnc1MWYydU1DMEFST083L3VPeHpOalNubkVybnFKbnhNM0ZLeTI1?=
 =?utf-8?B?VFRqcHpzQ0dPbDJ6MzZHS2VUT0d3aEh4SXBVRFZWYVl0T3lSdnk4M0ZZZlV6?=
 =?utf-8?B?OTk3RmE4dkNQeVNlK2wwOTkweWcrbXpSNnhrSFJlKzNLVy8rV3VHRW4zNWhO?=
 =?utf-8?B?N3VIbkF2STJNbUVyS1E5M21hVkR1YXdPa2tPWm9jOXpZNkJheU5hQm45S2Zq?=
 =?utf-8?B?VEFMdlRmTG8yTmlYbXFHVFArejFtNFc2eVlsMm9BOW41TCtMaXgzVnhMK283?=
 =?utf-8?B?NGRXdXlWeHN4bGh4dGRjcWVBTGc4SndvR3V0R2YwM09SV25YUS9FZWZLTEV2?=
 =?utf-8?B?VDJTenErQW53ZTMxbHQ0azlRSmdLRU5nOTludlN1N0RvekxXOGVZYWVteVV3?=
 =?utf-8?B?am5CT0RJclhDU0JhWWtVbUt0VldJOENuTXpTWnc4YXJVSGdCNXU4Q3Z2TlIr?=
 =?utf-8?B?alZHRVpvK290TWEwWjNCRWd6UjVIRS9GVjBRMEFVTFB2WENtOStKVC92VGVS?=
 =?utf-8?B?SFFyWVB6WjJyV3lETStFVlhqVGJyQmV2MjFzTUlpVDY5U2pLc0VEckFUclF5?=
 =?utf-8?B?bDhJejRpNVVHL2t5V2lpU3ZoWlpvMlE0WnhnaGNOZ2R3Y0NWQkN2Qk1tZ2VK?=
 =?utf-8?B?bk4zcE40LzR5WGdEeGppa0l1M0NqUWZCUkpRVEpWejhFaXRtZjhGdzVEbFVB?=
 =?utf-8?B?OFF5RTIzelhtU3ZySmREQnNRRS85bStmOU52V2pNWG82K3M2Z2krekFtOHNk?=
 =?utf-8?B?NXczeWpCTFN2WkpDUmt2S2tBcTR6L2NSL3ZxOFJyYSt6SWJGdTlzMVhpOEZ2?=
 =?utf-8?B?SzVGYmNMdlNMWVU2TlpYbWZENkgwbkRORnZnS0hsUFBnTlZWSFpMblNJa1ZC?=
 =?utf-8?B?TE9mT2NVa1dSa1NPNlowY2kyTWQ3Y3BSQmNMQVFaODVrdUcxV2xKL3VQUmdK?=
 =?utf-8?B?YnF1UGZMNDN1K1pMKy9aODBiV2RSZHVhWTFhb1pEdlNiVE5ONTZqQWV4OTBj?=
 =?utf-8?B?MlZoT2dOQ1RhNDBnMHVhdUd6aVBmRnVjMjJ4a0lRY251dGxKSUx2NEhqbytR?=
 =?utf-8?B?eVZEYzRCTkY2N3V1VUEzeE5RUUVMOFhXZTRSdVhPS0Z6WE5YQ3Z2bmZmQUhP?=
 =?utf-8?B?R0I1Y1BEUjNIenJ5K1A3Zy9zd2s4N282ZVdUTG1nUUdpYkhPSnNkKzdPTEhG?=
 =?utf-8?B?RFpDV3VnZEk3bXhLTmtUR1R4cHdGWnNXVTBmZURuV1BGdGtKRGo1VGpOckov?=
 =?utf-8?B?QzJseUN5Q3Bzd0IrbU40TnFqN0I4YW9naVFuTkdTVjVvNktQZmFhS3VnZXc1?=
 =?utf-8?B?YjcvbGYrN3Z5WkFBaUdaMVZzVHRDcXo5cVllSTRLbXpCQXIzb29qNjIyZ1J6?=
 =?utf-8?B?ODNKazg3R0xuYXEwN1l5RmprVlhsZkhoL3Fzd25FMk9CZEg0WXFkRlZuMm5O?=
 =?utf-8?B?QnFLN2lxblcxcWpqTFMrcWo2eVp5OHVtZUFhMDVDSDNIYUVTYTd2QWZ6Q2Jm?=
 =?utf-8?B?MzVjSkRRYklZRlYrdW9SRlhWVkRzVUpNcFYzdW9BYVBITkVVMytjS2dmQzE1?=
 =?utf-8?B?b2kwYnFaNVRPYkpGOUowWmJoZy9DMko3ZGdqc2YzVm9KUTdYdnlkak5tMzV0?=
 =?utf-8?B?OG1GdU5qWlB5UzhacGk3M3JLMXJPY0RnMTZualJ6cmlJSFkreEF4WjlxaFNw?=
 =?utf-8?B?Q2wvOWFtbzBENUFWS0NzUDlJR2syTS9hNVIyNU5VOWw2QTJDeStrd0ZaM1E2?=
 =?utf-8?B?eHQzcS91VW5rSHpUczN6OXNha2l4bTNLSGVGZXRaS3Bkc1pXWC9KMkg0N0VY?=
 =?utf-8?B?c3dBN3Nkd0xGWnJnMzdjc3pPeFdLaTBQcnhQWjY2Z0JqMG15dVpmVmNIQkUz?=
 =?utf-8?B?d0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b6fb45e-928a-4abf-6bea-08db86695713
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 01:58:39.6362
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4f+HdXlgMdPrFwV2t2tgcM6pX1cO0QqCxbjeyHJJScvq39wAWGpU+0c7vx/z79Q/neUMDKFu6GLzUy3og9Wz5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7340
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/17/23 08:35, Yu Zhao wrote:
> On Sun, Jul 16, 2023 at 6:00 PM Yin, Fengwei <fengwei.yin@intel.com> wrote:
>>
>> On 7/15/2023 2:06 PM, Yu Zhao wrote:
>>> There is a problem here that I didn't have the time to elaborate: we
>>> can't mlock() a folio that is within the range but not fully mapped
>>> because this folio can be on the deferred split queue. When the split
>>> happens, those unmapped folios (not mapped by this vma but are mapped
>>> into other vmas) will be stranded on the unevictable lru.
>>
>> This should be fine unless I missed something. During large folio split,
>> the unmap_folio() will be migrate(anon)/unmap(file) folio. Folio will be
>> munlocked in unmap_folio(). So the head/tail pages will be evictable always.
> 
> It's close but not entirely accurate: munlock can fail on isolated folios.
Yes. The munlock just clear PG_mlocked bit but with PG_unevictable left.

Could this also happen against normal 4K page? I mean when user try to munlock
a normal 4K page and this 4K page is isolated. So it become unevictable page?


Regards
Yin, Fengwei