Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     simon.horman@corigine.com, Marcin Wojtas <mw@semihalf.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        netdev@vger.kernel.org (open list:MARVELL MVPP2 ETHERNET DRIVER),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v2] net: mvpp2: debugfs: remove redundant parameter check in three functions
Date:   Mon, 17 Jul 2023 10:55:37 +0800
Message-Id: <20230717025538.2848-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OVg8N+HlKMaRmddV0xysrT69PkYKkpO/sxvWGeEgdLqvlXja1jz/xsMhbQ9w?=
 =?us-ascii?Q?dBP51oWPb5FISQqrBNyo6qSgYdjUVWN9YvrnA0NGTKtZ8MlNvj0T7ebahJmu?=
 =?us-ascii?Q?MCZ4ffbnrU1xjY9RQ6RUV3tBAYP0T/DJZluXgpZDSENjNNV4S64ihniNVqrz?=
 =?us-ascii?Q?R0eLkUErIagXGwb+iH4UKt9iuny83lrpzYRhMbOmMnqK0Fm6yWKyUzYwDNMm?=
 =?us-ascii?Q?WzUBElN/nUshIR+JpyShDMT3qeL/ozB8VcsSlFF5wRJ3JEot0b7mHuEDZdXm?=
 =?us-ascii?Q?eGrjC2qchtZrA4bsAdI5lyO0oo7AkFGuvxScRffov6zAMGKRbfEEJRYZAuc5?=
 =?us-ascii?Q?anXjfvB+spndxEyjuwxXMIIiAkm51Vz/wPtRmkrXArr1X5OKj0fZeBoI92JQ?=
 =?us-ascii?Q?q3NN9XHFImm9ZgRweDVPNGbYEOWH33XfGImmEzCgzCbad/gpV0F/3U//kP3i?=
 =?us-ascii?Q?gaYWVH68VkA9ssLaMMYeiopgldpfWmJXlgG+AJE3CQdLV2/yKzplyeBD6a10?=
 =?us-ascii?Q?/4DeLpdgBPLRY3Szye5dThSk+xFHduxZSXP159gyrG2zWArVT2PvG8p4FoBy?=
 =?us-ascii?Q?KhvuHkF4fGugZUXqXEqD8T1AYBj44fB7A6lQ/pCPUnnZ1iB0ptu7I9hB+W3N?=
 =?us-ascii?Q?G0Ylh6xFKgyCBzjeGArYZSYNibMxshEpRNSOL4GCEqQOuzbYaFqb3qarJ88k?=
 =?us-ascii?Q?u9J3rIsiA6jppMjdtr17hy9o+QUBzZ54ZgA86lrC7yh3W9nT8Eqwx8RPJlYm?=
 =?us-ascii?Q?a9s27SsQ9Iuzh41bO3F9dVPutQsociLVabu04NufCcbIWY77crmNzWnLPFxH?=
 =?us-ascii?Q?7xvd5Lb1xyX7X0bqstDcuP+P1Y405cFidTDbkX0eA64vLww63TD7nqsSJlZc?=
 =?us-ascii?Q?s6Yxp2fFVqjBgvkH4b8TXiMEHI4TE0U2Q9puDfHWNFDFqzdDxCdzPWFG0aAs?=
 =?us-ascii?Q?4o7CR+GVn8lfvtDxTf6XdORNYlpwV15aDkbYfxWU7ejMCIuyLmhLuOU5M3ui?=
 =?us-ascii?Q?hsNY4uWFy53Ii8sXuE/nT91o3i8AydNnJ5nmHKrGAnIUZjqcAuZnC4kcldOm?=
 =?us-ascii?Q?2V6RtcQiJMAuGtWxqv7RqBOY/3WruKviFmZBKezE2LZBUGYDoSgUxTpg97HU?=
 =?us-ascii?Q?088SjqwbL72us0u8OWhBIFSMToySuL2h3EianQurP2VjgVGM0sixZ7s+kCci?=
 =?us-ascii?Q?cpWWD9QuGRmS+ZEO7IMeBVNMfJJkOoR2xDELgQxWYQ0wA49R44DXiWVK9dFs?=
 =?us-ascii?Q?+VVri+J0r8l6Xe/4ijbsfvd7TraIw36MX/a6hESyoX/ynA43LVAsFJ62k53e?=
 =?us-ascii?Q?xd0/lrnIv+VThx+jHnFp+OjN+94n73xOuUuepPB8PfVfhRuXj8D4Fn51vd3K?=
 =?us-ascii?Q?1JA7rPc28p/fdpWbGFnA6U5OLTg0l0WmIi8BG/IKtIboPGHjRK4kCxe4ieiA?=
 =?us-ascii?Q?GKA1pOP5GrBYx+xqQMagljy393L3j5fb3jY1ZSBTqgf5+3Lzx4JOmC2Nfz+j?=
 =?us-ascii?Q?dKA+TSYeiCXaabbzt1tDgiOrNZdhyasZ0JX4lHNPBQqofmEvqscV2Rqj0l0J?=
 =?us-ascii?Q?VfUU3KwWnip/nTllb3E9XJOgIUzNO3+Oy6TEVrWN?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a307876a-2b81-496d-1247-08db867151b6
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 02:55:46.4734
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5RhloPfUgwO9Wp0H/opxgWqqMWhbmsCK93WxrMEtJnsR4j3CUdQrlzh7s/Br0TPg1xnRPQ+j+417d5ifUjU12w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4371
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

As per the comment above debugfs_create_dir(), it is not expected to
return an error, so an extra error check is not needed.
Drop the return check of debugfs_create_dir() in
mvpp2_dbgfs_c2_entry_init(), mvpp2_dbgfs_flow_tbl_entry_init()
and mvpp2_dbgfs_cls_init().

Fixes: b607cc61be41 ("net: mvpp2: debugfs: Allow reading the C2 engine table from debugfs")
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
index 75e83ea2a..0f9bc4f8e 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
@@ -593,8 +593,6 @@ static int mvpp2_dbgfs_c2_entry_init(struct dentry *parent,
 	sprintf(c2_entry_name, "%03d", id);
 
 	c2_entry_dir = debugfs_create_dir(c2_entry_name, parent);
-	if (!c2_entry_dir)
-		return -ENOMEM;
 
 	entry = &priv->dbgfs_entries->c2_entries[id];
 
@@ -626,8 +624,6 @@ static int mvpp2_dbgfs_flow_tbl_entry_init(struct dentry *parent,
 	sprintf(flow_tbl_entry_name, "%03d", id);
 
 	flow_tbl_entry_dir = debugfs_create_dir(flow_tbl_entry_name, parent);
-	if (!flow_tbl_entry_dir)
-		return -ENOMEM;
 
 	entry = &priv->dbgfs_entries->flt_entries[id];
 
@@ -646,12 +642,8 @@ static int mvpp2_dbgfs_cls_init(struct dentry *parent, struct mvpp2 *priv)
 	int i, ret;
 
 	cls_dir = debugfs_create_dir("classifier", parent);
-	if (!cls_dir)
-		return -ENOMEM;
 
 	c2_dir = debugfs_create_dir("c2", cls_dir);
-	if (!c2_dir)
-		return -ENOMEM;
 
 	for (i = 0; i < MVPP22_CLS_C2_N_ENTRIES; i++) {
 		ret = mvpp2_dbgfs_c2_entry_init(c2_dir, priv, i);
@@ -660,8 +652,6 @@ static int mvpp2_dbgfs_cls_init(struct dentry *parent, struct mvpp2 *priv)
 	}
 
 	flow_tbl_dir = debugfs_create_dir("flow_table", cls_dir);
-	if (!flow_tbl_dir)
-		return -ENOMEM;
 
 	for (i = 0; i < MVPP2_CLS_FLOWS_TBL_SIZE; i++) {
 		ret = mvpp2_dbgfs_flow_tbl_entry_init(flow_tbl_dir, priv, i);
-- 
2.39.0