Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <658bfc14-3819-8cf2-6e08-a9794c72f4c8@infradead.org>
Date:   Sun, 16 Jul 2023 23:08:31 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] proc: Fix four errors in kmsg.c
Content-Language: en-US
To:     Sergey Senozhatsky <senozhatsky@chromium.org>, huzhi001@208suo.com,
        Petr Mladek <pmladek@suse.com>
Cc:     tglx@linutronix.de, adobriyan@gmail.com, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
References: <tencent_053A1A860EFB7AAD92B2409B9D5AE06AB507@qq.com>
 <2f88487fa9f29eeb5a5bd4b6946a7e4c@208suo.com> <ZLEF16qgcTOaLMIk@alley>
 <20230717060500.GB57770@google.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230717060500.GB57770@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/16/23 23:05, Sergey Senozhatsky wrote:
> On (23/07/14 10:22), Petr Mladek wrote:
>> On Fri 2023-07-14 14:57:59, huzhi001@208suo.com wrote:
>>> The following checkpatch errors are removed:
>>> ERROR: "foo * bar" should be "foo *bar"
>>> ERROR: "foo * bar" should be "foo *bar"
>>> ERROR: "foo * bar" should be "foo *bar"
>>> ERROR: "foo * bar" should be "foo *bar"
>>
>> Please, do not do fix these cosmetic issues reported by checkpatch.pl.
>> It is not worth the effort. In fact, it is contra productive.
>> It complicates the git history, backports.
> 
> Absolutely agree with Petr.
> 
> As a side note, I wonder if checkpatch can deprecate that -f option?

Either that or document in very strong language that it should only be used
in very special circumstances, usually by the file owner or maintainer.

-- 
~Randy