Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760895AbXJYOht (ORCPT ); Thu, 25 Oct 2007 10:37:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757494AbXJYOhl (ORCPT ); Thu, 25 Oct 2007 10:37:41 -0400 Received: from ts.adaptec.com ([162.62.93.58]:58614 "EHLO mail-gw3.adaptec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756894AbXJYOhk convert rfc822-to-8bit (ORCPT ); Thu, 25 Oct 2007 10:37:40 -0400 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH 3/4] [SCSI] ips: PCI API cleanups Date: Thu, 25 Oct 2007 10:37:38 -0400 Message-ID: In-Reply-To: <20071024234830.8F7891F81A9@havoc.gtf.org> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 3/4] [SCSI] ips: PCI API cleanups Thread-Index: AcgWmTXqvy3tOUdxTKq9aHcTecNAvwAe0uzg References: <09821349085390234lkjasdflkjasflkdj24746@havoc.gtf.org> <20071024234830.8F7891F81A9@havoc.gtf.org> From: "Salyzyn, Mark" To: "Jeff Garzik" , "LKML" , Cc: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1211 Lines: 35 ACK. Inspected only. Looks ok. Sincerely -- Mark Salyzyn > -----Original Message----- > From: linux-scsi-owner@vger.kernel.org > [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Jeff Garzik > Sent: Wednesday, October 24, 2007 7:49 PM > To: LKML; linux-scsi@vger.kernel.org > Cc: akpm@linux-foundation.org > Subject: [PATCH 3/4] [SCSI] ips: PCI API cleanups > > * pass Scsi_Host to ips_remove_device() via pci_set_drvdata(), > allowing us to eliminate the ips_ha[] search loop and call > ips_release() directly. > > * call pci_{request,release}_regions() and eliminate individual > request/release_[mem_]region() calls > > * call pci_disable_device(), paired with pci_enable_device() > > * s/0/NULL/ in a few places > > * check ioremap() return value > > Signed-off-by: Jeff Garzik > --- > drivers/scsi/ips.c | 72 > ++++++++++++++++++++++----------------------------- > 1 files changed, 31 insertions(+), 41 deletions(-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/