Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp5236643rwp; Sun, 16 Jul 2023 23:41:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlHTIj0+Od75/1C7LGnmzxSlyd9s4yUi778NazL/91gD3MSIRZMOL52QInSHFvq9dk23QbZD X-Received: by 2002:a17:90a:7641:b0:263:ed7:3574 with SMTP id s1-20020a17090a764100b002630ed73574mr10975116pjl.1.1689576064541; Sun, 16 Jul 2023 23:41:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689576064; cv=none; d=google.com; s=arc-20160816; b=xG/igT354ts63HCm4XWsQ7EWO7DU5k9GvBiEvpDYrVtOhz0jn63Sb5EL0Ler4jN1Y+ YhQNlBjM6HtRohEqmXFzTQG2+7duRoIHgH7VoUgMtmrNGXqwcBDsJnwbrdkXqyOqt4PD 6FLKmq+IPoZHKq9DP5IidRHbd1qAXmpa18UUtYBgpvrR6ZKtbLHCjWD5TxwbMVaY54/F /xywe5cvHPZMi2vChEKWSwc1JjY5c7rRppsgDuibg04onXkBrxXaxOqAt/YS6qvR4DL2 jboRjV/950KEpXCEQnv/C3rdGjckMIGirqaTwTu05iS2Jc+fUSPbbVcuEoMWjrMhYF8/ +g9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=g95ImAOv3GgK0GpjAzOClKviSQVPX7slmMjb9FKPgog=; fh=x2m4wo6hYSGrVSJGrMqv/UomUgPCycMUNxc99UzSUG0=; b=pj1MjLI4kn235KJVUCqm46QY8th/sKMw0sqp8UONZHtQCo7oUOXS1Hgz1gwV6IFJa2 riSfWkUmSn2DcikJrWBdiGPHFBbbJVpfvQgGdneYiUIf1FbbtBGkT0iBMzaT0fb/riyy 1NaU6+Mb8/n/x4e+8YflRxF+1HpBUENaJ9kdUFGnzyEsr+LlbEmIctd9Bj+0/+TdS/ip XuBc8zGbmktHwmAWXSg5A2y6FbAuaV7G7WQ2i+/PFCLCh3s0uX6Adc6xr6k4cO2T78G9 mTE4R2HFqP+nQGpAA2ZT7dNkjziLK1uI3BDXRxl4lebCWqy+Wpjo8p2JrMg9LeYCSG9G twSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="VtvXM7e/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e8-20020a17090a630800b00263bf1c6dc0si5185745pjj.102.2023.07.16.23.40.52; Sun, 16 Jul 2023 23:41:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="VtvXM7e/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231666AbjGQG2k (ORCPT + 99 others); Mon, 17 Jul 2023 02:28:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231355AbjGQG2Z (ORCPT ); Mon, 17 Jul 2023 02:28:25 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1D87172D for ; Sun, 16 Jul 2023 23:28:07 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-98e39784a85so1124548966b.1 for ; Sun, 16 Jul 2023 23:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689575282; x=1692167282; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=g95ImAOv3GgK0GpjAzOClKviSQVPX7slmMjb9FKPgog=; b=VtvXM7e/GE78fPNOyrYoDcCcPcb6WUt8MDO9ogXzlKh4Lg9LMqfFmojPSY8+6UsF0B qE/u/K96Un2jlMGEAZuTAWXfIwH2bx1sG9yFACcYHiMsT2fCmBN7Pd4jYHkXgldu6TsJ u07UMTS2+WXOr/AUKP4gCabVQaHJf+pQdATwRiWdyvSnct6v9HKoVRyb04zErZdK6xWa yvGToMMprF5ySw9B5U66RVjjqhbDpmQldpenRGicTJOl/IGln5/ZqFR74bmOF3waWSwY AwYZ30iysaAl3wTWnov557D79aA8iAtbp3L3yNwEKeHvN8aqhVAQ04U28+38edZzxCmf oUpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689575282; x=1692167282; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g95ImAOv3GgK0GpjAzOClKviSQVPX7slmMjb9FKPgog=; b=Ls22tvcoWd3CB3BP1dhu1PaH1Hd/thTkYvORM3IcdYxmsDfMTayCE1HGmdBv6pRe0g s2XcXIKkBJpbYfWQcN4v8Cuvt1p4Xwi9xETTT+Yq0kaFJFbUizK8KqVUG5c6DyumM416 /PrFLzLeBpuaGeopUeZxNq8WBYWmEpfHn/FrCteS7FIuV7dRZCQAPNWLjKHqvd4bS/KG cIiIoCp3tAKgrs/InySQZIxTa6HZmzTyxgt02RvlYc9RLmWUyAJszOX3tf17GoIceV8f 6PzoaaDQf4pKqS2m9ptOGZ8CIFQz7ZlzA9E5uiUyDRkV5aJx+hhlw7Ar31ip/jMMH0fZ eIMw== X-Gm-Message-State: ABy/qLat3cCH26rL4iSToqOhYkVeXLBCt7nb178duvn0/bu19H6K8dGe LMgHnmmsGX+Wt8jPgr4RMq+S0w== X-Received: by 2002:a17:907:970a:b0:98d:4b97:acc8 with SMTP id jg10-20020a170907970a00b0098d4b97acc8mr11930029ejc.25.1689575282268; Sun, 16 Jul 2023 23:28:02 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id s21-20020a170906355500b0098de7d28c34sm8704851eja.193.2023.07.16.23.27.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jul 2023 23:28:01 -0700 (PDT) Message-ID: <625a92b8-b629-a4ef-6176-635e1b7885db@linaro.org> Date: Mon, 17 Jul 2023 08:27:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 0/3] Add support for WDIOF_CARDRESET on TI AM65x Content-Language: en-US To: "Li, Hua Qian" , "wim@linux-watchdog.org" , "linux@roeck-us.net" , "conor+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "robh+dt@kernel.org" Cc: "kristo@kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "huaqianlee@gmail.com" , "nm@ti.com" , "vigneshr@ti.com" , "Kiszka, Jan" , "linux-arm-kernel@lists.infradead.org" , "Su, Bao Cheng" , "linux-watchdog@vger.kernel.org" References: <20230717040723.1306374-1-huaqian.li@siemens.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/07/2023 08:24, Li, Hua Qian wrote: > On Mon, 2023-07-17 at 08:16 +0200, Krzysztof Kozlowski wrote: >> On 17/07/2023 06:07, huaqian.li@siemens.com wrote: >>> From: Li Hua Qian >>> >>> The watchdog hardware of TI AM65X platform does not support >>> WDIOF_CARDRESET feature, add a reserved memory to save the watchdog >>> reset cause, to know if the board reboot is due to a watchdog >>> reset. >>> >>> Signed-off-by: Li Hua Qian >>> --- >>> Changes in v4: >>> - Fix the coding style. >>> - Add usage note for the reserved memory. >>> - Link to v3: >>>   >>> https://lore.kernel.org/linux-watchdog/20230713095127.1230109-1-huaqian.li@siemens.com >> >> Much more changed. You added example in the bindings which no one >> asked >> for. Then you added multiple fake review tags to all the patches. >> >> Best regards, >> Krzysztof >> > Hi, > > Sorry for the wrong statement. I missed some key information and > missunderstood `Reviewed-by`, I treated `Reviewed-by` as `Who > has reviewed`. But you don't have even that information who has reviewed! Where do you see any reviews coming from me for patch #2? Where do you see reviews from Rob for patch #3? Best regards, Krzysztof