Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp5279358rwp; Mon, 17 Jul 2023 00:44:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlF5wsCiTfDvjE3ahcMAEEuh3/NNreo62GsyzYSEOsVJLQ2/zZeM29+ZIxYb5li04ODHMf+/ X-Received: by 2002:a05:6358:7e41:b0:135:99fa:a125 with SMTP id p1-20020a0563587e4100b0013599faa125mr6861195rwm.1.1689579848629; Mon, 17 Jul 2023 00:44:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689579848; cv=none; d=google.com; s=arc-20160816; b=AqFd6kYsxSmBwFWn1SI/2GAMIzYa3u6JFWULf7K7cshInew+q5XfBH8DI9xsxfQDRw sQvhYSJiEyuiH8DKw/60jbmJJ6YL7aFcnW2urxo3JHLZ1N399VNEw+qWuSSx5LGc6UIE uZzpIPAlOvPCag/Ji9YVeNs4yEY88PilnH/TCvgUYbfY6e+gTzxFIrZsR8gXT9snX9em ilZTZer5NZgeRhKWIfntO9+XqQm/OLoMQ77wtHGWE05fTmgdv8qcz01dNtmzLPjohsAo jo0rgYAa9upa+TLkll30gT/KO5B8Wb7oxym9RGWUfOk3RFbL/Bppm1yR/swD66S0fDPp nMXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=2EMrmpU0dWa8Mwjz50d/l0emxjMG8G1dTCZtvgJ0j9Y=; fh=erxkzJueQOjFtiQzDo73Xa3XHZM8eJOUTdjGxd2NY50=; b=a5vOcXQUDJWSGjVZxxQvwA7/LLiLlbOERm95ffTn7vSshbIOzktbpMriew/unvFJCs xFgQkgXOtNPFNx92wpM/XMd18k+zWK9rKCN4ysdOuVXhDFIE5gYfESSLFKDYXndTdreL J8e+d+AqY8wHyGtnA4TC1SNI9X8q45WeZGOpQFUj3KF26ywIjQvJDIks2PTgCqsAwAE+ z1/73jvq5b2o2mN47TMe/M+mMOSW/xquX7EUqQHAD4XNpvwctycL2OWmtQypZI7T78K3 LybiopiWe471SW1BW/AcoMvZvzyzQ0Lk1Po6Hze4TFSdsnnuWm9S31d9hJcoJ0iPzQFp Mdqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="JKSa5/p5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y8-20020a056a00180800b0067d77ec0d2csi11514096pfa.123.2023.07.17.00.43.56; Mon, 17 Jul 2023 00:44:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="JKSa5/p5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230290AbjGQHSO (ORCPT + 99 others); Mon, 17 Jul 2023 03:18:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230260AbjGQHSM (ORCPT ); Mon, 17 Jul 2023 03:18:12 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B65E10DC; Mon, 17 Jul 2023 00:18:10 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5217bb5ae05so2173527a12.0; Mon, 17 Jul 2023 00:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689578289; x=1692170289; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2EMrmpU0dWa8Mwjz50d/l0emxjMG8G1dTCZtvgJ0j9Y=; b=JKSa5/p5A0TvX+LWBpC9OCela2Bv81r6IfZJLvQc5r5llp1ubDmRhjgWU9+77sKlCX rMl6Xwia9PE4/yrZdZr2sg0Y6/f3/Ww4mcgz3Q5DuxKmnRx+q8socsImWHwjideALIpB Dp9MzBAQw2h8MiJpzKAOhxbRNXcuAhXWKuNsSbAb3vkt9EUXMCaW87I53CRW+SqZAXJ+ 4q1KvlsSyWt5juPuU5q8fc1wHAd9fZBZxnFaBpmltoC+O4ub/d1E6eY9YatD4ul7Sha5 HnTUsVUG1MANjxewjksqD178Bfc90iEYuG+0e32Ok1AHqSl+z8WESwr23NfFPumy1vRt oGDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689578289; x=1692170289; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2EMrmpU0dWa8Mwjz50d/l0emxjMG8G1dTCZtvgJ0j9Y=; b=hWg72lHKG86wQZI3jIANcrXBjGIDViDxCetQZ5kFspZ+A8z8gxTsmWFln6N7gBi8pV PsSXLqCQzHkWDLbcEXe6z4ILqArqKHeLA/ALQjp2kWkPMDd/PksK0is824GP9pHR94sR wuN55aXkUyaEYgLIlBPWcRVhaJwpQVq8GGEK2h0Zvg6uAUicooikK737TNzsWNkDpmf8 5QrMvhitS2RRwQwE6aSpNeysryQQGoMr8O8fzQptAiZjfDOcIHBCu4sFn5iMi1nuCAMd ilSoIWLdxnODnbsqjgSJe+/CZlSmwID7an0kIoqECjKi9C0if3XYz9Fxr/8c7ZUDBD1c qHsg== X-Gm-Message-State: ABy/qLbq5ihSpkG8Smg1SI9zoqi60wtbj1B4dPQKQnu8tPyDYEYtqVtX jMRbZXFsHCQoBYZ0a0gtnR7Nq580Q8M= X-Received: by 2002:aa7:dd09:0:b0:521:7181:e8b7 with SMTP id i9-20020aa7dd09000000b005217181e8b7mr4484671edv.40.1689578288608; Mon, 17 Jul 2023 00:18:08 -0700 (PDT) Received: from orome (p200300e41f4b7100f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f4b:7100:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id t3-20020aa7d4c3000000b0051d87e72159sm9471778edr.13.2023.07.17.00.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 00:18:08 -0700 (PDT) Date: Mon, 17 Jul 2023 09:18:06 +0200 From: Thierry Reding To: Rob Herring Cc: Sudeep Holla , Cristian Marussi , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Matthias Brugger , AngeloGioacchino Del Regno , Florian Fainelli , Broadcom internal kernel review list , Dinh Nguyen , Jonathan Hunter , Michal Simek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] firmware: Explicitly include correct DT includes Message-ID: References: <20230714174438.4054854-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TiNl3sY2kGGAUSEk" Content-Disposition: inline In-Reply-To: <20230714174438.4054854-1-robh@kernel.org> User-Agent: Mutt/2.2.10 (2023-03-25) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --TiNl3sY2kGGAUSEk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 14, 2023 at 11:44:37AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. >=20 > Signed-off-by: Rob Herring > --- > drivers/firmware/arm_scmi/driver.c | 4 ++-- > drivers/firmware/imx/imx-dsp.c | 1 - > drivers/firmware/imx/imx-scu-irq.c | 1 + > drivers/firmware/imx/imx-scu.c | 1 + > drivers/firmware/mtk-adsp-ipc.c | 1 - > drivers/firmware/raspberrypi.c | 1 + > drivers/firmware/scpi_pm_domain.c | 3 ++- > drivers/firmware/stratix10-rsu.c | 1 - > drivers/firmware/tegra/bpmp.c | 3 +-- > drivers/firmware/xilinx/zynqmp.c | 1 + > 10 files changed, 9 insertions(+), 8 deletions(-) Acked-by: Thierry Reding --TiNl3sY2kGGAUSEk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS06y4ACgkQ3SOs138+ s6H3vxAAt+q3FQ+MBS2z+u74V8zvjMkyymL79TZvk56JPufzsPYsS6gvjgQeEJg8 R/slJzQCTxr3jPo3Z+wNWyfyEfE/1M58LbOBii5LVVxiQadLFmzqS/x9Zhy+LOVq LI1xBxmIE7fiC98G8rS5E0F/N8PPUm2KiNOtAelj0xeiy3TkG+kdNeTDQlt+yuHx tSTz992PllOwY2WSlYhXGwKJXZmibO5zmb6z1gWXYZZnzzIuyL2KeIuF0pRw/4Y9 HoWX10J/985/8uaeWWci4ucp87WAYX0Z1/DfLBVjVFXA7rDcw5To/JwvwR8JkgXo 2iF65qla1iOdqpq8KzWf485wdHISrWNwSiTLmhzeMNW3SagUNlsGtQCyCmDhIXD5 A2nj+9NUWQmVlhkEbEMcJug9GUNtluuFCyWz6F7ipkz+l6r0hxFAUVDlntgWDt7w xRdCGvohvX3squFZ2NxeU0AX7NGxBRyEVlnmExUYjsdlYRrNFATYrV0Xyu1GKTjt QcaBe5bhIx9anBIZCfbb2OjHXYguN9LGABN0CepVZEJQ+92CHsS9o5fAMasquHTg BKnkPKO9/hwB+oY/kV6DgMCReLLL9Xl1CCKW1IktCempLLX+M7oTpXSR1Gt4Iolj CUo463ao93rGLkBXs7nlXnzDf1iykUqesITmjzEcbV9NwI1AxFw= =lAG5 -----END PGP SIGNATURE----- --TiNl3sY2kGGAUSEk--