Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Jul 2023 09:30:31 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Zhang Shurong <zhang_shurong@foxmail.com>
Cc:     ldewangan@nvidia.com, broonie@kernel.org, jonathanh@nvidia.com,
        p.zabel@pengutronix.de, linux-spi@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: tegra20-sflash: Fix signedness bug in
 tegra_sflash_probe
Message-ID: <ZLTuFyYewf8pUiRw@orome>
References: <tencent_4D4974DE0CD4266C25819179B42888A3E20A@qq.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="9cyN+Lexs+8sRPGX"
Content-Disposition: inline
In-Reply-To: <tencent_4D4974DE0CD4266C25819179B42888A3E20A@qq.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--9cyN+Lexs+8sRPGX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jul 15, 2023 at 05:53:56PM +0800, Zhang Shurong wrote:
> The "tsd->irq" variable is unsigned so this error handling
> code will not work.
>=20
> Fix this by adding error handling statement

This doesn't really make sense. First you say that the error handling
will not work and then you say you fix that by adding error handling.

So the bug here is that there is no error checking in the first place,
so you should probably reword that commit message.

Thierry

>=20
> Fixes: 8528547bcc33 ("spi: tegra: add spi driver for sflash controller")
> Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
> ---
>  drivers/spi/spi-tegra20-sflash.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-s=
flash.c
> index 4286310628a2..4c18337de813 100644
> --- a/drivers/spi/spi-tegra20-sflash.c
> +++ b/drivers/spi/spi-tegra20-sflash.c
> @@ -455,7 +455,11 @@ static int tegra_sflash_probe(struct platform_device=
 *pdev)
>  		goto exit_free_master;
>  	}
> =20
> -	tsd->irq =3D platform_get_irq(pdev, 0);
> +	ret =3D platform_get_irq(pdev, 0);
> +	if (ret < 0)
> +		goto exit_free_master;
> +
> +	tsd->irq =3D ret;
>  	ret =3D request_irq(tsd->irq, tegra_sflash_isr, 0,
>  			dev_name(&pdev->dev), tsd);
>  	if (ret < 0) {
> --=20
> 2.30.2
>=20

--9cyN+Lexs+8sRPGX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS07hQACgkQ3SOs138+
s6FWsw//ejk+7MtZ9+XJ1pY/45JPEu2E9UgxMwjg2ZEIprSO5LM/gofh7Y0MrKTU
2yv0deTR+tTqN7Ks8gMLjyt+FkA2wu5KjiMZpuI9YNGZwvbugKL/m4KWsTosXpso
s5puXPqLAdschSFrIG3L7K+N/G5yziMT6MgZuLhF0KT9HYJE057ABc9ZjjYm+3pq
6yFubaU7Q5xNB0C3+91Fs71ZB6hoxCYg/3Yw5/WP4byzFXwalM/RftBAHyQlZ6fE
I+uKpvsuDpnSsCi3iwHPCXMmXmjaiH8Td1lgusGeQUG7taIp7a4stZ09M8vj+doK
QZAQljCVKX4lA4CB6WjGUXUEUq5GNsdsDbdhD80RJuh82hZ/ekkG9hGoAL+WV1wm
Hs1AsJr8QyfeQVLL01h0wU5sqDIAIZXjEXEC99HP/GV5H70qu1R1DSXZMOHjPQrP
BAzlKxrHB1OI6V8EXyq17jkNxrr9J/tk8G3CtQQMt6TEXhq6750MxLeqVUYhaemY
mynHAXwj5rElzdyQqWQdbg+QJQjDkQJTr56LF6bS8BYYabQAQkgK4uDbGEnPVHpi
Lj4vJBnGzmOx3MhsSWbg3cK6YWIfza0Nd6pPUv9tQiRZwtkFujHtNXa9VIfFXSCl
IwekZaVsY3aC/3FHylXy5KLTRDQFZg9D1iEGWPezgXuTbj7s8K0=
=tho+
-----END PGP SIGNATURE-----

--9cyN+Lexs+8sRPGX--