Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Jul 2023 09:33:03 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     yunchuan <yunchuan@nfschina.com>
Cc:     wg@grandegger.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, uttenthaler@ems-wuensche.com,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next v3 8/9] can: ems_pci: Remove unnecessary (void*)
 conversions
Message-ID: <20230717-overeater-handlebar-377cac2af8ec-mkl@pengutronix.de>
References: <20230717-clash-kerchief-afdf910e2ce6-mkl@pengutronix.de>
 <f1e0ecfd-b9b3-2c4b-f548-c08f7615febe@nfschina.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zynuj47hijq7ykbd"
Content-Disposition: inline
In-Reply-To: <f1e0ecfd-b9b3-2c4b-f548-c08f7615febe@nfschina.com>
Precedence: bulk


--zynuj47hijq7ykbd
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 17.07.2023 15:30:33, yunchuan wrote:
>=20
> On 2023/7/17 15:07, Marc Kleine-Budde wrote:
> > On 17.07.2023 08:52:42, Marc Kleine-Budde wrote:
> > > On 17.07.2023 11:12:21, Wu Yunchuan wrote:
> > > > No need cast (void*) to (struct ems_pci_card *).
> > > >=20
> > > > Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com>
> > > > Acked-by: Marc Kleine-Budde<mkl@pengutronix.de>
> > > Please add a space between my name and my e-mail address, so that it
> > > reads:
> > >=20
> > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > >=20
> > > nitpick:
> > > You should add your S-o-b as the last trailer.
> > BTW: The threading of this series is still broken. Make sure you send
> > the whole patch series with one single "git send-email" command. For
> > regular contribution you might have a look at the "b4" [1] tool.
>=20
> Hi,
>=20
> Thanks for you suggestions, I use 'git send-email' to send patch.
> I messing up the patch's order in different patchset. This might be the
> reason of the broken threading.
> Really sorry for this, I will take careful next time.

You should send _all_ 9 patches in the series with a _single_ "git
send-email" command. There's no risk to mess up the order.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

--zynuj47hijq7ykbd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmS07qwACgkQvlAcSiqK
BOgY1Qf/aiTDvlMlmCoRBIxvvrjt5KXRR9nKC9GZ+Xuj/iWW7RVne75zO2X7G1mW
xJEqOd65wTD6KkhFyPFuErTWScLKclXlmRL3cxEgE2228fTrv4XiNwUtKoO5f2R/
t4OAtJ8npU6J6D3BKzejj7fxAG2B/jgGIlTRx3YkhCmw5rCsz+GTmslj4PnJbIpa
+Kj1k2JcMd89YLdCSz3gbBdoPcf8vSBBqikZVyNnGmFJpAxMXwuSgO01V4UpjGvc
tnFr90AXmk24bmt+0kGETA6dkKQ4jAEoSG6cWqERas6JlNdTQjUhaC6nOv6NWFiW
doKFgls3KzLsBNznpJtbXgEsbdjZVQ==
=CQEc
-----END PGP SIGNATURE-----

--zynuj47hijq7ykbd--