Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230717071938.6204-1-duminjie@vivo.com>
In-Reply-To: <20230717071938.6204-1-duminjie@vivo.com>
From:   Andreas Gruenbacher <agruenba@redhat.com>
Date:   Mon, 17 Jul 2023 09:42:23 +0200
Message-ID: <CAHc6FU4_SDSpom3Qvt35AXOmmc3v9EJYksgP4EN3owMEC2y-AA@mail.gmail.com>
Subject: Re: [PATCH v1] gfs2: increase usage of folio_next_index() helper
To:     Minjie Du <duminjie@vivo.com>
Cc:     Bob Peterson <rpeterso@redhat.com>, cluster-devel@redhat.com,
        linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Minjie,

On Mon, Jul 17, 2023 at 9:20=E2=80=AFAM Minjie Du <duminjie@vivo.com> wrote=
:
> Simplify code pattern of 'folio->index + folio_nr_pages(folio)' by using
> the existing helper folio_next_index().
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  fs/gfs2/aops.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
> index ae49256b7..5f0254237 100644
> --- a/fs/gfs2/aops.c
> +++ b/fs/gfs2/aops.c
> @@ -272,8 +272,7 @@ static int gfs2_write_jdata_batch(struct address_spac=
e *mapping,
>                                  * not be suitable for data integrity
>                                  * writeout).
>                                  */
> -                               *done_index =3D folio->index +
> -                                       folio_nr_pages(folio);
> +                               *done_index =3D folio_next_index(folio);
>                                 ret =3D 1;
>                                 break;
>                         }
> --
> 2.39.0
>

Applied, thanks.

Email addresses like '"open list:GFS2 FILE SYSTEM"
<cluster-devel@redhat.com>' and 'open list
<linux-kernel@vger.kernel.org>' are not helpful though, so could you
please avoid using addresses like that in the future?

Thanks,
Andreas