Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\))
Subject: Re: [PATCH] vmbus_testing: fix wrong python syntax for integer value
 comparison
From:   Ani Sinha <anisinha@redhat.com>
In-Reply-To: <20230705134408.6302-1-anisinha@redhat.com>
Date:   Mon, 17 Jul 2023 13:13:25 +0530
Cc:     linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <761F02E9-7A80-486B-8CB4-B5E067D7F587@redhat.com>
References: <20230705134408.6302-1-anisinha@redhat.com>
To:     "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>
Precedence: bulk


> On 05-Jul-2023, at 7:14 PM, Ani Sinha <anisinha@redhat.com> wrote:
>=20
> It is incorrect in python to compare integer values using the "is" =
keyword.
> The "is" keyword in python is used to compare references to two =
objects,
> not their values. Newer version of python3 (version 3.8) throws a =
warning
> when such incorrect comparison is made. For value comparison, "=3D=3D" =
should
> be used.
>=20
> Fix this in the code and suppress the following warning:
>=20
> /usr/sbin/vmbus_testing:167: SyntaxWarning: "is" with a literal. Did =
you mean "=3D=3D"?

Ping =E2=80=A6

>=20
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
> tools/hv/vmbus_testing | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/tools/hv/vmbus_testing b/tools/hv/vmbus_testing
> index e7212903dd1d..4467979d8f69 100755
> --- a/tools/hv/vmbus_testing
> +++ b/tools/hv/vmbus_testing
> @@ -164,7 +164,7 @@ def recursive_file_lookup(path, file_map):
> def get_all_devices_test_status(file_map):
>=20
>         for device in file_map:
> -                if (get_test_state(locate_state(device, file_map)) is =
1):
> +                if (get_test_state(locate_state(device, file_map)) =3D=3D=
 1):
>                         print("Testing =3D ON for: {}"
>                               .format(device.split("/")[5]))
>                 else:
> @@ -203,7 +203,7 @@ def write_test_files(path, value):
> def set_test_state(state_path, state_value, quiet):
>=20
>         write_test_files(state_path, state_value)
> -        if (get_test_state(state_path) is 1):
> +        if (get_test_state(state_path) =3D=3D 1):
>                 if (not quiet):
>                         print("Testing =3D ON for device: {}"
>                               .format(state_path.split("/")[5]))
> --=20
> 2.39.1
>=20