Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Jul 2023 09:03:13 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     <hanyu001@208suo.com>
CC:     <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>, <liaochang1@huawei.com>,
        <heiko.stuebner@vrull.eu>, <linux-riscv@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: kernel: remove space before ')'
Message-ID: <20230717-gummy-frisbee-2f7dbe9f9512@wendy>
References: <tencent_6B88A6697F6AB7CEBD04EEABA52ACDC66909@qq.com>
 <8ef63e3296f5628896f373d696a078f8@208suo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="L/2VYdryjTVOyFzm"
Content-Disposition: inline
In-Reply-To: <8ef63e3296f5628896f373d696a078f8@208suo.com>
Precedence: bulk

--L/2VYdryjTVOyFzm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey,

On Mon, Jul 17, 2023 at 03:48:37PM +0800, hanyu001@208suo.com wrote:
> Fixes checkpatch errors:
>=20
> riscv/kernel/probes:ERROR:space prohibited before that close parenthesis =
')'
> riscv/kernel/probes:ERROR:space prohibited before that close parenthesis =
')'
> riscv/kernel/probes:ERROR:space prohibited before that close parenthesis =
')'
>=20
> Signed-off-by: ztt <1549089851@qq.com>

Checkpatch complaints that this does not match the email you sent the
patch from. "ztt" is not a known identity either, so that's insufficient
for DCO purposes.

Thirdly, the patch is corrupted, with tabs replaced by spaces.
I've seen a lot of "checkpatch -f" fix patches from 208suo.com people
across various subsystems over the last few weeks that are all corrupted
and do not apply. Please don't send any more for arch/riscv until you
figure out how to send them without corruption.

Thanks,
Conor.

> ---
>  arch/riscv/kernel/probes/simulate-insn.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/arch/riscv/kernel/probes/simulate-insn.c
> b/arch/riscv/kernel/probes/simulate-insn.c
> index 7441ac8a6843..60792c79b42e 100644
> --- a/arch/riscv/kernel/probes/simulate-insn.c
> +++ b/arch/riscv/kernel/probes/simulate-insn.c
> @@ -128,10 +128,10 @@ bool __kprobes simulate_auipc(u32 opcode, unsigned
> long addr, struct pt_regs *re
>      (((opcode) >> 12) & 0x7)
>=20
>  #define branch_imm(opcode) \
> -    (((((opcode) >>  8) & 0xf ) <<  1) | \
> +    (((((opcode) >>  8) & 0xf) <<  1) | \
>       ((((opcode) >> 25) & 0x3f) <<  5) | \
> -     ((((opcode) >>  7) & 0x1 ) << 11) | \
> -     ((((opcode) >> 31) & 0x1 ) << 12))
> +     ((((opcode) >>  7) & 0x1) << 11) | \
> +     ((((opcode) >> 31) & 0x1) << 12))
>=20
>  #define branch_offset(opcode) \
>      sign_extend32((branch_imm(opcode)), 12)

--L/2VYdryjTVOyFzm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZLT1wAAKCRB4tDGHoIJi
0riRAQC5x0bRrGl6P4BqE7Pp+DOZbmF0X73PbxpL8CQ3OQLu5wD+KlSkbuZfU55K
FyKYxpIKFpgkocwE27cbJKVW9svqQgE=
=iDgp
-----END PGP SIGNATURE-----

--L/2VYdryjTVOyFzm--