Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp5309362rwp; Mon, 17 Jul 2023 01:30:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlEs/ucRFDFys3Z1irszsd7AvbfFx0ylIgdLmE/5KyQ4YnlVOxxX5NOeAs22CCisMh1fyI7n X-Received: by 2002:a05:6a00:3995:b0:67e:18c6:d2c6 with SMTP id fi21-20020a056a00399500b0067e18c6d2c6mr17102708pfb.5.1689582603166; Mon, 17 Jul 2023 01:30:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689582603; cv=none; d=google.com; s=arc-20160816; b=eEMI1i3wnlsKX/Sy1UtNgAeis5cJWW4z2vesWWR4GL24SqBeOewiLjUZGkkVBmtZOo uag9MMnftn+gUPIXQ29qp8EsnSTssyxLgE7QprYTxE1cVZWwy0E8rEWV4kW5pFStnY3q GO++h4ytK1ADsHT+fhr7fzoaCidYfACYUN5hXTh9fgqdjF9J82uOmRH4ypNqF1RWcRt9 +wA04DlRkOSVIfibwo6iwtX+ovC6sOMq31cCohxnjyOt383abY7xEF978a6Za9apbwSB LfMGws5ZwUg6Zg9ZdzMgAWy6XZoXn2wTiBmr5eI4aYxiS7YQQoSL1457O6CICDDanQYZ k7hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8WbeqUwXg63Mjue9IkzBHg2sl77/SvPI+XDchBxbZf4=; fh=Ej4mcAjrurE8pHSVdT3ZD1KfS6Z31bJMaVQaa4yiDnc=; b=GsWbFFLNPtFrCGdEYVy1hxkwbVFw4J1tzBybL9cYDVT9IZGhyJb5/BLhUjrNya1AWv uoKIrHC+Twy6PJGMkuQ9+i3pRp51lKzCVbkvcGhD98Z0V9J9Z+Bpusw/vxOxxYeB7CPV H1N4jhEsszXPFUA9gcHHtqp0TbE88TdU3aAJGjL4hbsBBH/P1191lhBhpo8jVV/998nr 7mB8G8wqbrvpX2RkddxNMSms2cRls48b7736zW2vlUtqyde65Gfn/BFYrUIVnUEOZkkW GWmOipDfv2ha9ExkPkOoEdP27ZDI8ol5oad4Wgw537j2oK/JoO8bgn6oAkXMiBtKf5ng pjyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FISKc+7g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v10-20020a63610a000000b0055ff588077csi1774454pgb.365.2023.07.17.01.29.51; Mon, 17 Jul 2023 01:30:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FISKc+7g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231211AbjGQIDl (ORCPT + 99 others); Mon, 17 Jul 2023 04:03:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbjGQIDj (ORCPT ); Mon, 17 Jul 2023 04:03:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1ABD10F for ; Mon, 17 Jul 2023 01:03:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 891C260FB4 for ; Mon, 17 Jul 2023 08:03:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBF2CC433C7; Mon, 17 Jul 2023 08:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689581017; bh=fxCzi9cqQ/6Te9Id+fLIHCQJFVg7LEXG2cA0E+qADbg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FISKc+7gCFhCRRl0wkH4LKhJ2TtLo1Zcbd5H+B09PDWFKUUyJcBeJg8VL+QClvgea y4E77RexFfMjBLyDjcaeMg4lWfeICFn4Oveq5XGMC+aUifC1cYMA3yCcRwnIisZhxr Jmpm2nph7AAyTLi77S1ghli1vuBZpaVXqYg9dV3rWYMOUiVBlrmTDD1YOw7pTILx02 YQloLQwMXxGqmcyRSvTbK3zNyJJMG3uNkc4gP8mT5NWVi7UDBhl1QN06YpwygQOI9l o8qBEmIhDKjm3J9+L4ZVo00gG+Egb/vpHbwsCXAsatTAhdqhfCrUtZvhHwUBPryh7h 4UURKLSAGBsLQ== Date: Mon, 17 Jul 2023 10:03:32 +0200 From: Keith Busch To: Sean Wang Cc: "highenthalpyh@gmail.com" , "axboe@kernel.dk" , "hch@lst.de" , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "sagi@grimberg.me" , "xuwd1@hotmail.com" Subject: Re: [PATCH] nvme-pci: add NVME_QUIRK_DELAY_BEFORE_CHK_RDY for MAXIO MAP1602 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 07:41:26AM +0000, Sean Wang wrote: > My two SSDs are from different companies, but they all use MaxIO 1602 nvme controllers. > > After applying this patch, they could work. > > Otherwise, here is a workaround to make live cd to recognize these SSDs: > > > echo “1” > /sys/bus/pci/devices/0000:02:00.0/remove > sleep 1 > echo “1” > /sys/bus/pci/rescan > > Where device id (02:00.0) could be found via > > lspci -nn -d ::0108 We have a generic solution for such devices as of 6.5-rc2 so it should work now; however, it's still recommended to get devices with this behavior in the quirk list in order to ensure that the we get udev to generate deterministic symlinks. Since this controller is used by multiple vendors, though, it's unclear if this quirk applies to all variations.