Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d93030e9-938e-f394-8067-a7307f6acd30@intel.com>
Date:   Mon, 17 Jul 2023 16:12:39 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [RFC PATCH v2 3/3] mm: mlock: update mlock_pte_range to handle
 large folio
Content-Language: en-US
To:     Yu Zhao <yuzhao@google.com>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <akpm@linux-foundation.org>, <willy@infradead.org>,
        <david@redhat.com>, <ryan.roberts@arm.com>, <shy828301@gmail.com>
References: <20230712060144.3006358-1-fengwei.yin@intel.com>
 <20230712060144.3006358-4-fengwei.yin@intel.com>
 <CAOUHufYef--8MxFettL6fOGjVx2vyZHZQU6EEaTCoW0XBvuC8Q@mail.gmail.com>
 <CAOUHufZ6=9P_=CAOQyw0xw-3q707q-1FVV09dBNDC-hpcpj2Pg@mail.gmail.com>
 <40cbc39e-5179-c2f4-3cea-0a98395aaff1@intel.com>
 <CAOUHufZHyEvU-c2O6B6stM_QVMxc22zV4Szn52myYqjdZvptUA@mail.gmail.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <CAOUHufZHyEvU-c2O6B6stM_QVMxc22zV4Szn52myYqjdZvptUA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWxOQk4vNVhWMG5mNjA5TjJDYU9OcCs0TkFKdHh0bSs0aWhKRWR5V1VZbDlN?=
 =?utf-8?B?L2F5NnE5OUJYT3VsbUpocFNuUlRjZ3VWa2wrcjJzTG1rNVFwM1NxaC85dmo0?=
 =?utf-8?B?MGZTV3hVMDBQRVByMTY4N1A2NUZBMTBaVUx2YzI1eEtTRkJ4bFhnSDFEeW5o?=
 =?utf-8?B?eDJtWVh4a0ZlYWRnOGlxRkowVlIrcHpTM3pueUVOQklIa01wOWx3RzRZTjdp?=
 =?utf-8?B?V2FkQkZ2Q2NkSGFabUZVbk9sQ2MwRE1rSTFUNENON1pnTm1TWHRVcmxwWUVK?=
 =?utf-8?B?TmlxMytwK09aZmNNbHZUWFUwcUR3eThYVElSanJ5TU9VYmRDSEJOaFAyVXJu?=
 =?utf-8?B?SEJRZUgyWGxSYi81TmVzVWtGY3VTWlZuV1ZkOC9tUkpuTjVHdlVtaTJ1MmNW?=
 =?utf-8?B?OE16TWxmV2FuWHI4VzltUVV2Ymt1elMrWWpJV29KRnZLd0FycXVQaUU0djR1?=
 =?utf-8?B?YXA3L2JYWWtJbkkrcHpwaVlWTkp4c1U4V1hPL0FTQWI5R2xYOWIzUWhtRlFP?=
 =?utf-8?B?enlCUnNaMWsvNXN6ODBvaitHRkpZREE1a0RkdTVpUXArN0kxN3NSYVBtRjNz?=
 =?utf-8?B?akdNWXk3N0YxdHdiQlQ0SUZtODhHekVjVU85Z0MvSTB4ZGdQcDR4VU9EbEVT?=
 =?utf-8?B?eTNpbzliblVCdlZLM2tZUkdaa1B1TTdnaXIvY25vTnZHM0VMZHljbVNmR0Er?=
 =?utf-8?B?bVpOWDVYaTY0R2htR0liOG01ZXZxbjRZZThXMVlQL1ltbzlVVDZDaGlsZnJF?=
 =?utf-8?B?dk8wV1Q0N09CbGhBUHh1Y3JJNmhtRzdxcXBkck9jRnc2aUZaYXh6NWRNQ21B?=
 =?utf-8?B?TXJ1YkFxOUpSamN6ODZ2L3dFaUY5SHFPYXQ2Y0ZUY3RaVVY3dFBxdVRGVEhL?=
 =?utf-8?B?alV1RWYwRTZ0MjVXR3VhZzNmYTJZVEh6T1d4UTROTG9FeW9WdVBxY1NEUWFU?=
 =?utf-8?B?OWgzMTU0R0RzK3lMcmNYS1hjTG9hZkxTRStPc3UxdUY5YXlpeDI3bzltQVBm?=
 =?utf-8?B?WnM2SjhEVzE0MWJKZDZPTU52L24wRkkwbldhTFUzdzJEZnJBM0dOSVVxaEk1?=
 =?utf-8?B?K2ZBTXp4Z1dJNnhtdHBRdEwrZmhOb041NFBRMGVDVTBOTTlVQzdxYjBHV1V0?=
 =?utf-8?B?dU4weE5VOXgvRHJrRGFDUXk3akkyWEozMnF1RU9Ja3hpak4xMFA1OEMrc0hZ?=
 =?utf-8?B?NXRuaFpWZEg1YWRpMnpBa1E1L0FDN2pZYmJENllVRk5lV3J5NThpTUZINW9F?=
 =?utf-8?B?RkF0L3Brbm5IbWVqaTZUeFRvNllHVlMzSkxkQ1FvSXFRTUhpdi9kVGZNcCs1?=
 =?utf-8?B?RUZVTjdHUzlpbWgzSFgwZkIvQkpVNHM2d2RQcXpnam9uUWJLVU5QcFBUSFpU?=
 =?utf-8?B?UjZHcU1nMkVWT3NNMjF4d29pMCtWTzd6VE1DQXBrNmlNS1ZsVzlaWEN4cFpB?=
 =?utf-8?B?VDRwQVRwTjdJK3QvRm1ZZVQxRnJKSGdFbmpvUkxkeW5uZGxCUDRibDVrbGZU?=
 =?utf-8?B?c3FmY0N3S0NQN05mT2IzZFRkN1JuY2FPQnp5Q2MxNDJ2N1AvOUVQRVlObkVw?=
 =?utf-8?B?S3NPZkVyYUl5dzhYWXFkRUxzNGxFTElNNENXQjAvMkl0UW5NRXoyR0RPQ0RD?=
 =?utf-8?B?Y0I2ZWEzZzRVR0h2YytEWHJJZEZ3T2pUcEkwMU94Rks4QS9yTkxYL0ZkQTYv?=
 =?utf-8?B?VGVuMDdITTFmUDlnRFhYSTJ0Nk9qbUNPOTdvRzdib2hORGNFNjFsN2xmWm5j?=
 =?utf-8?B?MFM2aVRYcWRnZ2l1bC9MQWZGSUs3SW0rOEJJR0x6SXRjdjdxTjM4NVpEcmw4?=
 =?utf-8?B?U0FINmhpQ2gzZ3RuWnhQNTVYTWkvS0NnbDlTUVJDM0RBUTNQZ1NyWlltMTho?=
 =?utf-8?B?dDJvVkEvNVpBTFR4aGhPQXUxcE05RXBIS3dQWFVKdVRXT3hwNGtGZXdJQmEx?=
 =?utf-8?B?M3lGT1QzaFNKRkdQN2RUQ3BkMkQrVE9Tc0NTNDgyMi9qc0g2NW9JTEgzL09t?=
 =?utf-8?B?d2Z3YzFaMm1ETTQzeS9uY2tDSTRUUUFGUWFWS0M0cWNjTFNrd0ZvMVk2QWlF?=
 =?utf-8?B?MkxRWHBKQmowS2tkTmpLdEVyWTgxeGFTOW9RUTgrS0tNL2NBdWJVOUNsRFFy?=
 =?utf-8?Q?aMeBsjt1806LrNyWFjRgy8owc?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a4e3c80-3663-491e-8bae-08db869d981f
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 08:12:42.6021
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MICP0amb18oJWK27C78Y+nWZx613VXzdKctEVAB2OZgB5tBP9QSZSyPyK2JLZD4lWnezTNyZ+w6mpHXrK2hqNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5871
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/17/23 08:35, Yu Zhao wrote:
> On Sun, Jul 16, 2023 at 6:00 PM Yin, Fengwei <fengwei.yin@intel.com> wrote:
>>
>> On 7/15/2023 2:06 PM, Yu Zhao wrote:
>>> There is a problem here that I didn't have the time to elaborate: we
>>> can't mlock() a folio that is within the range but not fully mapped
>>> because this folio can be on the deferred split queue. When the split
>>> happens, those unmapped folios (not mapped by this vma but are mapped
>>> into other vmas) will be stranded on the unevictable lru.
>>
>> This should be fine unless I missed something. During large folio split,
>> the unmap_folio() will be migrate(anon)/unmap(file) folio. Folio will be
>> munlocked in unmap_folio(). So the head/tail pages will be evictable always.
> 
> It's close but not entirely accurate: munlock can fail on isolated folios.

I suppose normal 4K page can hit this problem also and following patch could
fix it:

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 1080209a568bb..839b8398aa613 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2498,7 +2498,7 @@ static unsigned int move_folios_to_lru(struct lruvec *lruvec,
 
                VM_BUG_ON_FOLIO(folio_test_lru(folio), folio);
                list_del(&folio->lru);
-               if (unlikely(!folio_evictable(folio))) {
+               if (unlikely(!folio_evictable(folio) || folio_test_unevictable(folio))) {
                        spin_unlock_irq(&lruvec->lru_lock);
                        folio_putback_lru(folio);
                        spin_lock_irq(&lruvec->lru_lock);
@@ -2723,7 +2723,7 @@ static void shrink_active_list(unsigned long nr_to_scan,
                folio = lru_to_folio(&l_hold);
                list_del(&folio->lru);
 
-               if (unlikely(!folio_evictable(folio))) {
+               if (unlikely(!folio_evictable(folio) || folio_test_unevictable(folio))) {
                        folio_putback_lru(folio);
                        continue;
                }
@@ -5182,7 +5182,7 @@ static int evict_folios(struct lruvec *lruvec, struct scan_control *sc, int swap
        sc->nr_reclaimed += reclaimed;
 
        list_for_each_entry_safe_reverse(folio, next, &list, lru) {
-               if (!folio_evictable(folio)) {
+               if (!folio_evictable(folio) || folio_test_unevictable(folio)) {
                        list_del(&folio->lru);
                        folio_putback_lru(folio);
                        continue;


Regards
Yin, Fengwei