Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp5328063rwp; Mon, 17 Jul 2023 02:00:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlF0+nO8kwtrCSHF3hMwkK85xvb0RrRx8VaPzUtT0GYp2kGxewNT7+O7hxE3XU4fhg8+3g8a X-Received: by 2002:a19:670a:0:b0:4f3:b61a:a94b with SMTP id b10-20020a19670a000000b004f3b61aa94bmr6358454lfc.53.1689584421382; Mon, 17 Jul 2023 02:00:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689584421; cv=none; d=google.com; s=arc-20160816; b=cscUTnfAC9y/ppsZf9pqVoUdFrfM2NKLLuopcx4zXFu42H4Sp0OAOATHakg373+5tR raaCQIpRvsder8SX4MwBdYmtyvxYcgzo+oLe1uokeGB80ruc+CwKoHUHbaUULGBfH8IJ R8ldzaVcBpiF5nD5X7bcUVc2nUlD7Hfej1M4RBwAjO52qnSz8bLRbykBRCsLAocM4/lu b07Uo090DFrJ1BB5Gt6v3Pj4KnBaWQFwJSwyeu5qjrKFuOsSgnwYq00wrO55TMSwTYHL UOWZICxBRZuFLqIHtTyxyHv+/TL/mXd+z9ZtNZiLNEp4yrjlvSaLjGwBtbcqSkCa78Xq XPiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=4wmygyhN8x99SgC4E7mGBBHLQm3fKTuKkB0Oqg/4CII=; fh=tglwTtRmFTSI3JUtWmZzmrkwHdv4vEFd8EvwUz/0Vcs=; b=CTtGjUKIhU9SykxAO6U7mkQVSbFuU8Haziux+R75V2PUmACYMoAiqzwpabL26XLCHf JfpibG0gDULHDvAB/v/GYNLjzDgvLkRLjK3Wws3f1WbdA9Cl2lGOrH165HlKYKZK6PE+ FX6WT1AWBcXxe08uRLwKHHnRidgmmesdQyYw+JbBnAqia1OHru+qVg5qcXwz8nCa4+y1 XHNqquZj1ddLH8RXOauUP1dK5T40qCreZDpDKiZuyoHP+GQYytlHWBIl2uvfM/TtE+NA cFW0pPgMrSkTazdxVmIFYn2U9wK/dzxhuXmk3jBkSjKZu0G42b9GppdmuVDB7JoVBsX9 TkfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bf11-20020a0564021a4b00b0051decf83dbesi12099457edb.205.2023.07.17.01.59.56; Mon, 17 Jul 2023 02:00:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230201AbjGQI3E convert rfc822-to-8bit (ORCPT + 99 others); Mon, 17 Jul 2023 04:29:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbjGQI3D (ORCPT ); Mon, 17 Jul 2023 04:29:03 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62FE3136; Mon, 17 Jul 2023 01:29:00 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 31F6724E1A6; Mon, 17 Jul 2023 16:28:58 +0800 (CST) Received: from EXMBX062.cuchost.com (172.16.6.62) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 17 Jul 2023 16:28:58 +0800 Received: from [192.168.120.43] (171.223.208.138) by EXMBX062.cuchost.com (172.16.6.62) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 17 Jul 2023 16:28:56 +0800 Message-ID: <6ed58545-c10a-d789-04d5-4eb715f4906d@starfivetech.com> Date: Mon, 17 Jul 2023 16:28:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg Content-Language: en-US To: Andrew Lunn CC: , , , Peter Geis , Frank , "David S . Miller" , "Eric Dumazet" , Jakub Kicinski , Paolo Abeni , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Yanhong Wang References: <20230714101406.17686-1-samin.guo@starfivetech.com> <20230714101406.17686-2-samin.guo@starfivetech.com> <4efd8643-455e-4f7f-b031-a0a02dd65210@lunn.ch> From: Guo Samin In-Reply-To: <4efd8643-455e-4f7f-b031-a0a02dd65210@lunn.ch> Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX062.cuchost.com (172.16.6.62) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -------- 原始信息 -------- 主题: Re: [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg From: Andrew Lunn 收件人: Samin Guo 日期: 2023/7/15 >> + motorcomm,rx-clk-driver-strength: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: | >> + drive strength of rx_clk rgmii pad. >> + |----------------------------------| >> + | rx_clk ds map table | >> + |----------------------------------| >> + | DS(3b) | wol@1.8v | wol@3.3v | >> + |________|_________________________| >> + | | current(uA)| current(uA)| >> + | 000 | 1200 | 3070 | >> + | 001 | 2100 | 4080 | >> + | 010 | 2700 | 4370 | >> + | 011 | 2910 | 4680 | >> + | 100 | 3110 | 5020 | >> + | 101 | 3600 | 5450 | >> + | 110 | 3970 | 5740 | >> + | 111 | 4350 | 6140 | >> + |--------|------------|------------| >> + enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970, >> + 4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ] >> + default: 2910 > > The DS(3b) value is not relevant to the binding. It is a driver > detail. So i would not bother listing it. > ok， will remove it. > Please add a comment explaining what wol is. > > Andrew Sorry，it should be vol (voltage), not wol. Best regards, Samin