Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp5335946rwp; Mon, 17 Jul 2023 02:08:56 -0700 (PDT) X-Google-Smtp-Source: APBJJlHM7KLgaHep6uy4pP/wZuNNJWz2ly2sdH+8NqX8rTK1A0roTGI48XWWEMdF+NFc+XT0xMCQ X-Received: by 2002:a17:906:6495:b0:994:1fee:3066 with SMTP id e21-20020a170906649500b009941fee3066mr10859727ejm.15.1689584935976; Mon, 17 Jul 2023 02:08:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689584935; cv=none; d=google.com; s=arc-20160816; b=QTRylFhXrfv13p8Ytv56CO/eBRMVVoD1F3VJyJAn+2kabRqfQrAVKFkIKAHpZL8qYh TE9tZsoZg6HcSjrKDWiOSxXfZLGrVDL1XUgEA0+1BmdQmquzSnqe2VGgTtXgqYOszWPt aIHcq+aInJRoHLM/FLd0bWM2t8ukTqlIEtwYN4xSJltkDCJ64z8LI3E82hmqBlp++SCO Ziio65B/euGUi/E40zUiE4LVIeZoUlG2q/7kNkoBjL99Hx9v6fd3wLkyb7G+Q4ldJN3n MHM07Edd3D/gYJ/OtKtpuJGv58vRklaZ8K3OEwFg3p8OmjC6eyIipy7gpVB3rDBKYk0U BOMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id; bh=BGVkiod7yzPCXbS2mxM4M4wMoXOnlEb71NB/sqawCT4=; fh=dAAnQ8VsTTd8p91XJIlyRVn3i2Com9HexD9JvSE310A=; b=gk+G/oy2Hphbwbere3rl2C8NyBEz4Hm8vWznmwuryKBPR/2JmrKdEN3NEaPxwQrw+L AVJvy4iEcPMac8vMGfXqCOIeTp4uqCuiAVvdlQsNLBc83pLV7BhknPvO+JYPjguVIH/W M+jL1rWycuUSj2/J1CIGlf0Jl3LkDXy+MiSgMWIwCQfI/eq1VT3Yu8b0uZafvqJOi3Ku 49ZV9AC4v5q+nBtPW7XzvBG1ck1vElWtwgwUuRsSArTHeqoTRXHzFH6f/B8qZlu6ykdC iI7R1/fqLswxfOLvfRmdkNaHjecFRaXzo7TredErdBNQFAHH7eNOPlSEtIA6lbBnvCkx YPDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v20-20020a170906339400b0098e24139529si12204805eja.733.2023.07.17.02.08.32; Mon, 17 Jul 2023 02:08:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbjGQIhS (ORCPT + 99 others); Mon, 17 Jul 2023 04:37:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbjGQIhR (ORCPT ); Mon, 17 Jul 2023 04:37:17 -0400 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 657FFE3 for ; Mon, 17 Jul 2023 01:37:14 -0700 (PDT) Received: from loongson.cn (unknown [10.20.42.43]) by gateway (Coremail) with SMTP id _____8DxPOu4_bRkddsFAA--.10265S3; Mon, 17 Jul 2023 16:37:12 +0800 (CST) Received: from [10.20.42.43] (unknown [10.20.42.43]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Cx_c6l_bRkmEQxAA--.5661S3; Mon, 17 Jul 2023 16:37:11 +0800 (CST) Message-ID: <73307b1e-1e0e-6265-0344-171d2700e495@loongson.cn> Date: Mon, 17 Jul 2023 16:36:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 0/8] drm/etnaviv: Various cleanup To: Sui Jingfeng , Lucas Stach , Russell King , Christian Gmeiner , David Airlie , Daniel Vetter Cc: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn References: <20230623100822.274706-1-sui.jingfeng@linux.dev> Content-Language: en-US From: suijingfeng In-Reply-To: <20230623100822.274706-1-sui.jingfeng@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf8Cx_c6l_bRkmEQxAA--.5661S3 X-CM-SenderInfo: xvxlyxpqjiv03j6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBj9xXoW7JF1UWw4ktr43tw1ruF18Xrc_yoWkKrc_CF yqv3srWr43JF1vqF47AryrZFW0kFW8Xan3tw1qqwnag343trZxGF1kCryDXa45JFWUKFn8 GF9xJr97Ary7WosvyTuYvTs0mTUanT9S1TB71UUUUj7qnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbqxYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_Jrv_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1ln4kS14v26r126r1DM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12 xvs2x26I8E6xACxx1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r12 6r1DMcIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr4 1lc7I2V7IY0VAS07AlzVAYIcxG8wCY1x0262kKe7AKxVWUAVWUtwCF04k20xvY0x0EwIxG rwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C267AKxVWUAVWUtwC20s026c02F40E14 v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkG c2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8Dl1DUUUU U== X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Dear etnaviv folks Would you like to review this cleanup patch set ? I am asking because I'm wondering that if I should re-spin my other patch from the code base which *with* this series applied or from the code base *without* this series applied. I think this series looks fine, is it acceptable? On 2023/6/23 18:08, Sui Jingfeng wrote: > From: Sui Jingfeng > > No functional change. > > Sui Jingfeng (8): > drm/etnaviv: Using the size_t variable to store the number of pages > drm/etnaviv: Using the unsigned int type to count the number of pages > drm/etnaviv: Drop the second argument of the etnaviv_gem_new_impl() > drm/etnaviv: Remove surplus else after return > drm/etnaviv: Keep the curly brace aligned > drm/etnaviv: No indentation by double tabs > drm/etnaviv: Add dedicated functions to create and destroy platform > device > drm/etnaviv: Add a helper to get a pointer to the first available node > > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 100 +++++++++++++------- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 14 +-- > drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 7 +- > 3 files changed, 77 insertions(+), 44 deletions(-) >