Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Jay Vosburgh <j.vosburgh@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Yufeng Mo <moyufeng@huawei.com>,
        Guangbin Huang <huangguangbin2@huawei.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, jay.vosburgh@canonical.com,
        Wang Ming <machel@vivo.com>
Subject: [PATCH net v3] net: bonding: Fix error checking for debugfs_create_dir()
Date:   Mon, 17 Jul 2023 16:53:02 +0800
Message-Id: <20230717085313.17188-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WxRXVzhH24xdGEXcWOcTRiR7TlsXK4lZBZYvP1U8laVhvU5rHmj6bbigT4uP?=
 =?us-ascii?Q?5KpgpfFyceBS0hi43eNuYIkfw26sO5Jp/88CcDRffuZczf6WV+D3pd8Oioni?=
 =?us-ascii?Q?lYrwCj24S6dL1oDv9lACFQyAtEpD9YZrpORVw3o3foAzmafF5aAXVLUv4Cbr?=
 =?us-ascii?Q?KuwLwloJ2qh1nsv8J/KLDmneog1AQyhRWFOa4n7oaHyYZL1QZvcDtbUj91km?=
 =?us-ascii?Q?nUANCKwD5uwRNNIYXYGqc1dbHgvJKAPCAO134Gza+3EzssESj1c3bQSEi1L0?=
 =?us-ascii?Q?ibXsy2BydarfPaoZxVxiLMgTTYR+rUjErlqbPKfOHtDb3lJwwipS9pJCpEzU?=
 =?us-ascii?Q?w2JDRz2OKtdSDtqf9K+kAMwF81X/SvQtIiWgXn99Ts8dCgCJ4eoP2arvSgc+?=
 =?us-ascii?Q?HehbkSbSqGXStKTzTaWWc2TJZEGjhRJkstbCbRi/YQpFQOtjn52O7NM+u16E?=
 =?us-ascii?Q?zqVcrNi4J5YCOM+Bco1x04bOJ+GfjIS2f2ieU9+gTCjmFGNNxJJPt/WsX3v3?=
 =?us-ascii?Q?y87KCjVC8tT8sTEoQRzQNnvmmQDS2HcsHgZogfvBbcKpmBazmCNHOgjpf22j?=
 =?us-ascii?Q?AyCnBePqdo8n/gAv5A5WboSJXBnF9y78z2RWj6ZsejAHjBqSSC7H0+ih7nT5?=
 =?us-ascii?Q?O+DtZfx1B+kVvhb24VPzuc1U2wW5O918ajeK9hf+3eHN7QmYFICwwnFaZm1n?=
 =?us-ascii?Q?jmzlUVFVInKuQRCVoVpyIUKH1mwlA4jPWENDsUjVh3BsPYumCVRJ2OVonLGK?=
 =?us-ascii?Q?dLGPy7GhhYDudPNkeOPe+ugy4W4muYiAlAjzTPHpaPbsATVuxROnD3+xbLuq?=
 =?us-ascii?Q?ILV0sSizZoj4NtOITpYyyzbbwMsoot94rQa+ckq/aME3mj9Ef0KTs4aT9LCE?=
 =?us-ascii?Q?xHufODcnYaSSq34T050qqxnHT5DMkzJh2XZM3Z4Vn05DJarz7z49GcykOVgV?=
 =?us-ascii?Q?QaJ9VN52p5qbk5DmVs2c93/aj0VKsS+gPV5bdG9YpJRoGMzZ6lcoSG3Crkqd?=
 =?us-ascii?Q?tQGHJpYElP0hdYnOOSy2RgSfYhPymLYj7aFq62Od7mxKvaVw8tsdPuKANrBP?=
 =?us-ascii?Q?wC4iv+eQfEDpwfhYlu92kX4sxaCvwDuZqA9PHjRdshGY3neIR3UEIFz5esVq?=
 =?us-ascii?Q?qdq49/z1/zwkNCQyq5VPB29QiJYJcHodU6KrpT/OoiFGMdYNQfqam529gq9z?=
 =?us-ascii?Q?FrxAdVixksVX8qcyZgeySvo9H7VIELAfISNZxr3Lh80d6HJvFF4PItHNAbxg?=
 =?us-ascii?Q?9yvcNYxmyXXqIcsqtkcyyNvFg3CEYDvcssf9RKT4/wB6qm6Gh38vNcRjPYo/?=
 =?us-ascii?Q?E3jXx0xq/oIkczoldY/88Mzg83O0m3kxJc7LKvIEL6eSN+9hD+AhawV/gRYI?=
 =?us-ascii?Q?X0NG5c3ht2iMDK46cTWD1BPgy1K5KWmpM7PiHY8aKFeNsuZ4tt0s7svHXjoW?=
 =?us-ascii?Q?dfoz5iIFm+b+SobWM2Ezx20N997ACVEcV1j7SvhwFeVmBlyfeG5uGZvdo9WX?=
 =?us-ascii?Q?ANeq2kFwAQSZ3N+MyEes2BEatKhx0CYZR+b73LPJi5JIkbnNZEzr+QxesIQg?=
 =?us-ascii?Q?So0aiZdgmGfI8NBCaozGbU7EBeFZI7euGbGLYe1J?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a59c4cd5-d46b-4ef2-1888-08db86a348a5
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 08:53:26.3301
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q7k8Y8+tGfB6FPBTbkT7tewt27ERa3rG1HIM7sfKH9i/e34EbXkjG2glItDDV8jVavqXtPEIJL4AgMeglTrFZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6099
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The debugfs_create_dir() function returns error pointers,
it never returns NULL. Most incorrect error checks were fixed,
but the one in bond_create_debugfs() was forgotten.

Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/net/bonding/bond_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
index 594094526648..d4a82f276e87 100644
--- a/drivers/net/bonding/bond_debugfs.c
+++ b/drivers/net/bonding/bond_debugfs.c
@@ -88,7 +88,7 @@ void bond_create_debugfs(void)
 {
 	bonding_debug_root = debugfs_create_dir("bonding", NULL);
 
-	if (!bonding_debug_root)
+	if (IS_ERR(bonding_debug_root))
 		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
 }
 
-- 
2.25.1