Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
        Mike Christie <michael.christie@oracle.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        open-iscsi@googlegroups.com (open list:ISCSI),
        linux-scsi@vger.kernel.org (open list:ISCSI),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] scsi: iscsi: use kfree_sensitive() in iscsi_session_free()
Date:   Mon, 17 Jul 2023 17:26:57 +0800
Message-Id: <20230717092657.9776-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8G7M/CcFAo+OqYUWsmBMaftxmUh0NAAHdgTTePgeKettQQVRKlxSpvxiWYMX?=
 =?us-ascii?Q?jhOzrag9evS4j+EflIM0U5zz2+3CkI+s5OC7aUpfMng34Tz+bVnYNvBrm3vs?=
 =?us-ascii?Q?UdVnMYJvy5qMo546NoOs16/xdDwiVr3H3IDo1pYqZrxGRYfjPxkcFXL6schn?=
 =?us-ascii?Q?1x2mbw0qhgJddn/WDbFKZfT8llaM73ozMku9zeiuLoM5sWhauwaCu7moWOmt?=
 =?us-ascii?Q?jY/yK9Rjk+1aTvxiDNsEhTHO891Fx0kWmsavbcoEkbDwCOSHdwNB1Nx0sQve?=
 =?us-ascii?Q?5BaJNS+YLOdQ6IGFNP1TSnNc7f3zry8yAtelC5m/sgnyK/EtkEuDte5XhL38?=
 =?us-ascii?Q?pGvdufgdelFVUR5zcQOzSr43oWKI59Kc2yK6+oreAYwcwPGhpUxdXpA97O96?=
 =?us-ascii?Q?kkRwBrf3kQjY63pgVOhfxbRF0aqWOJ2YpbQ4mfFJHTL6/uCFAoF2ZfGubsiq?=
 =?us-ascii?Q?E6hkc1R/sf0SD6CmZpblX5has8VWwc74lgrvMAgXo+sw8bBoQHkQ94NUeVAF?=
 =?us-ascii?Q?qGi0GDo0/0+jYqoTaL6IBdG5S9YYI1Fn4EU/rNNscLV3Cd+e+66DIs2taU3Y?=
 =?us-ascii?Q?MvxliNQ30h2NeXjye0gbWZlBVSidCD4OPosOLIgH7hYBvCv4bYlhWo4Q0Iep?=
 =?us-ascii?Q?Hd6HD/IPszHy58Yhd3CrBZ5fpIDyTTtt4Ft7TS9ZtkV7szqla1KD0R2okHIh?=
 =?us-ascii?Q?oucumLdPz82VlEt7poaVXqBM8pSniTq/GD9KeD71cnS0uYh1jQInjWmXY1mX?=
 =?us-ascii?Q?xDag5PWZ8sFdcNhTx4xJLd94N1ClFzeePMTlhHOaWQ8BN5CR5yvwwCb+oDTF?=
 =?us-ascii?Q?9H01SOFVlDFl0+yE2yr30tLLN84yFEVYSF7/42Yyy8lA3mxqYU6OdDyC32ID?=
 =?us-ascii?Q?uzcXSckKto3sJ0a6sLF8cJ5SVbX+LvKyhaPQa6WQPJib2VbbLh380SJ+F5g4?=
 =?us-ascii?Q?YDjtmR6S3fVaDMa2Q9qCGsHy7L7qKnCLNh6nqQSOf8hhK18rgaNghIa5IzOI?=
 =?us-ascii?Q?0WNW2T3I+mP3yCvfBEWQ6bbIye+MFkQjilWkN11QgGU1CWgFOlutbdjFm369?=
 =?us-ascii?Q?d7P5Ngz341hxjLrFIBJy3+TpUK52lZGqP59Qo9KvIRoDLR4W5YFqTjQKrE82?=
 =?us-ascii?Q?yQ692c5LYhLJSime5yAVYJ4drr0mxY6rzT2b0zzzdlCDZ6XkUMmiBS+Ld5d4?=
 =?us-ascii?Q?Nlog5hd0yZmtoAGa6pvHRT5W7SuuIHBfoTc3hE+wtjRu0t8D2mFWKaUjPYlc?=
 =?us-ascii?Q?lQ+Zm480HHRU/ucDDNn+jZxv/LZJiSAtrpJ6JxzByz4NjblkjJhAMasSw3iL?=
 =?us-ascii?Q?buJ7pwiQbOmWg9ZlxQj1bx0CykV5kSRAeJ3KfABOp3ZXOUHIjf9Ljta+g0Xz?=
 =?us-ascii?Q?FMhc4J8znXjqE3KtKB7b6Rv9wgiwfHg6D6WQSWo1u0mXDYvGf6XqMqzlEIwJ?=
 =?us-ascii?Q?8lh4LEko0j0PcjEpnErV+ksRohDYN0Q/CNOiRVnl5ZbYDiTuKhaWGU1sVsjP?=
 =?us-ascii?Q?kHe+bg3DMDNE2smyCyr2EFzlkjcSj2aWyQsm+XPvbPCSeaChluYIa8/neqZD?=
 =?us-ascii?Q?fKI6O1vKulsO4ewQ0LU5rjF1HRprexLq4DVFkiO7?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb03584b-2a78-4ee0-6032-08db86a7fc19
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 09:27:05.1592
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mqE/vQJCy/ezDQTEwfPlGAq9H0zKl+BMWmf7hADfo0vqeJ7SOqo9l2zzxNih0ABcM9Bp9fcBZPdAe72O9kGBdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6273
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

session might contain private part of the password, so better use
kfree_sensitive() to free it.
In iscsi_session_free() use kfree_sensitive() to free session->password.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/scsi/libiscsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 0fda8905e..2f273229c 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -3132,7 +3132,7 @@ void iscsi_session_free(struct iscsi_cls_session *cls_session)
 	struct module *owner = cls_session->transport->owner;
 
 	iscsi_pool_free(&session->cmdpool);
-	kfree(session->password);
+	kfree_sensitive(session->password);
 	kfree(session->password_in);
 	kfree(session->username);
 	kfree(session->username_in);
-- 
2.39.0