Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Mark Pearson <markpearson@lenovo.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] platform: x86: Use kfree_sensitive instead of kfree
Date:   Mon, 17 Jul 2023 18:11:02 +0800
Message-Id: <20230717101114.18966-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?THkD/wdBrhTmbRmVzdBKMcIjLPGT0BvhveA3P/J8btNqFdu7jWnnQQXg8V86?=
 =?us-ascii?Q?e45mPPpeyz7v9dOzI6UzKTmgFzatNaWkaG0BC36LQaoLabVNS6YYEnSpbOBt?=
 =?us-ascii?Q?4ZpGyEzAlqPqcewZvnk3em1Pygya82GR7M65Y1k6SUvTMzILFUO4RsUIied7?=
 =?us-ascii?Q?dAZfeAREPh5mZEfMt/MNJqP3IFiNHBeMfJBTRcxj/FUOpn1a6Fz3LbM/OOR4?=
 =?us-ascii?Q?r7KTNEy9JM6J8lhOOIXykR/lVf41h58yrw6ilbf0pQ9D6EFRXp/vGqUc7clg?=
 =?us-ascii?Q?Nuu6HJK8HyHozjfsD0mD/55NdIhuw0Zpj/coOcJfWmjxiU5fX4NkWrOk7Qud?=
 =?us-ascii?Q?dYXLRLKfFfI/rAQ8oEKw1zw9v30xEesvl6ff9G/P+HZ9gAEiExmt97BvdlU3?=
 =?us-ascii?Q?FDl0riKC1K77d9GlCri7OS37UUgjP8bZDvazs9FvMMW64QpTpkJaGhHSQf0O?=
 =?us-ascii?Q?rFaKgtBybV8V35GVtntwZfA+FPGCcUl+8FwSUf1uof1o6njcXAJh9rpf09ZL?=
 =?us-ascii?Q?wAzahEn56PziIJm2fytm+nlaWpHgtmodOAe7r4tEF8LmGY5mcdjzXFkc4XZo?=
 =?us-ascii?Q?stwOa4Pl8JUW+f8obDBuuTPpbQsioqUm3OH6JyiTusV0WdnU9Fmnw+CELyd3?=
 =?us-ascii?Q?9NQTrXHnZbgL2mfm7jBRty9gryfanKiGuQdfoZsvHwzf2Z9SbeQq7bV8h9h8?=
 =?us-ascii?Q?D5uqewPSMtyQpCOZt2UJrX/0DXzzhTrDU3msGO6BAFgw3mqBhu1CBzdeZ2fW?=
 =?us-ascii?Q?KfKefhxjEM0HL2R/7I12kDxpAunycm8FOSVNGozewUD4FF7QHqs7jXcQq3Pw?=
 =?us-ascii?Q?c1Wl0Gi8JjiSQDikFnyliZ/IvwV7WjytU4xGZJTAwcnshY3YMOzZelRxtExJ?=
 =?us-ascii?Q?StAf9zrAgkePudl9iszcjs/wavl3UeIzYBK41ftxM15zSskwaGqW8IIleHUR?=
 =?us-ascii?Q?uzs6oMIoLRQAASHVMb0kyy+N1PuJdR3ZnTf4lntEsPbY/MyxY758nrY2ZDAZ?=
 =?us-ascii?Q?xX6NEyrwwj9I6/gZcYo3+21OhS1dA0e64iLig9y1uFnk2VBYL9gsPuKFyqri?=
 =?us-ascii?Q?JGSXmNnx5z6F6qiTP3f4UJSYmIyqOLjXxe4gPah0Kn2qNn6WBXJOTBAOz96g?=
 =?us-ascii?Q?0y0Wg7DMNYZuAkg02aTOSrT1iM4to5gJcCk2pY5muCo5LnVawQ3crQoS1syK?=
 =?us-ascii?Q?Vixd3NOqznUZ5dpf9Luqbw1P9sEFo+LmBxMbFrsbFhiYWqU0ADZuY2ZJaLpf?=
 =?us-ascii?Q?l2rSA19ue1WSsGlmHAIdp5odJXiI899GOj3j588KePiiTm11ezgEotlW5o/K?=
 =?us-ascii?Q?IGw/gf+SdPS8sowYKnnMSmGJTAG3PxCjjtRr6MzaB3/ZLL8MguaIZnI9xSVQ?=
 =?us-ascii?Q?a4beTJJk8NxRcbPlNs/i3rwDsB1N9UCub1hpZo0/uAcggVgYXHgcnnsmfcC6?=
 =?us-ascii?Q?HcuFXsyjACqNGIp0B8x5mzP1x7YCjgvdAMXZDWq7vuCaVoR/RbIxnXY6rz66?=
 =?us-ascii?Q?Ae4H2+YzzSW0A4FiOfiW2CfXunso6FNhWpBBReKHZptZJVXBwLE6MTbmYd5m?=
 =?us-ascii?Q?Y4M1aD7NP8+1xcOIC+dNiT2ZWJrff2Uc7U3UH+W/?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 971a207b-1bbc-4924-c0c0-08db86ae2c8d
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 10:11:23.4344
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jfIKI5PP6fDC9hfOewTs5uaGh5fbcMFmDZ0s3IrfvrnESwsSgPO1H6c+CcSL5NB5zdZvNg9Q8D4GB7JRRlH0dg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5140
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

key might contain private part of the key, so better use
kfree_sensitive to free it.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/platform/x86/think-lmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
index 52d1ce8dfe44..79346881cadb 100644
--- a/drivers/platform/x86/think-lmi.c
+++ b/drivers/platform/x86/think-lmi.c
@@ -719,12 +719,12 @@ static ssize_t cert_to_password_store(struct kobject *kobj,
 	/* Format: 'Password,Signature' */
 	auth_str = kasprintf(GFP_KERNEL, "%s,%s", passwd, setting->signature);
 	if (!auth_str) {
-		kfree(passwd);
+		kfree_sensitive(passwd);
 		return -ENOMEM;
 	}
 	ret = tlmi_simple_call(LENOVO_CERT_TO_PASSWORD_GUID, auth_str);
 	kfree(auth_str);
-	kfree(passwd);
+	kfree_sensitive(passwd);
 
 	return ret ?: count;
 }
-- 
2.25.1