Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Steffen Klassert <steffen.klassert@secunet.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        David Ahern <dsahern@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH net v1] net: ipv4: Use kfree_sensitive instead of kfree
Date:   Mon, 17 Jul 2023 17:59:19 +0800
Message-Id: <20230717095932.18677-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Qy9y8lZEVI1Qm1D5StDmMqqQgIUDHGw+19sAJMvuD2SiUhamCoJqOAthLyYr?=
 =?us-ascii?Q?2IGjrQxfX7QEoSszXSokpALjukxhPRYkV2ANg0f2tDtD1YhfmHu7+tZH9YYA?=
 =?us-ascii?Q?eZQhpMsQgVyWunoOz0TNgedeyjXWYWJgZpPGxE0vOVau/HUqpxBkfU4T645b?=
 =?us-ascii?Q?fG4SLFvHb/UOkSn4zqBj57Y1uy6qiHG2ohcaUiPUAeCdNc655PZLjRZBu3AL?=
 =?us-ascii?Q?fsNfsO1YajfM0Tuz8+4b9mg7s4aHjOSPjpN0eSKOeuVEMeFL6Jv1mnm0Ojql?=
 =?us-ascii?Q?zpKM1a3uWVAw9vtJJZB7FjxDK+TsAhvAW5tL2SplHvYCLuR34zt5qXXE5GzP?=
 =?us-ascii?Q?vNg9BpqEuFsx0CtGdEaxXUxkenJDYkwDvX+6gnr12A0kPF4n33fRYMcA55ad?=
 =?us-ascii?Q?G7cn4BAE1ZSeSsX5XcTXMcET9GyNK2nyorluYZpwv6InWo6JNxl6yDVzVLtQ?=
 =?us-ascii?Q?2FWOC3fse40/W80IXmGDuSNEb8sjxE7p9iM56M7UWDwmW/7B6z9+djxrC/6h?=
 =?us-ascii?Q?YGrS4m64Ng6a2KKRdw7drdKvOc68G9LHxqCPi8ke/NSt35gOLJlGqqDWppGQ?=
 =?us-ascii?Q?OXu+KwmdVe1BbGlTLUq8CfzQvhOfJoguX5IlnBfMcuFtB3vs04z8PanUbrnb?=
 =?us-ascii?Q?8FvgH946xkNnIHsNasX1OAFvZw56OVw3civ96NlOQ/MIYFR4W3coQD9KedjG?=
 =?us-ascii?Q?MxiA0U0rq/2eEs+TirV+2xLnIYmpboUnWJRgBo46SlNtdLq96hl94JaxW1pB?=
 =?us-ascii?Q?qnvRwXrprQ/dimLQbrTK+4tq5O31N8ff0MB/UefQMSbb6FXNZAMo6s/KXz24?=
 =?us-ascii?Q?M4SuzCLUu9op1XLtr6hF3JiLhjS63UJxXvXX4KfZZKDaZ+Sa+J0LPeHL22cf?=
 =?us-ascii?Q?1xst4b99X1b7FBRt9PukOiKX76CtSWHu5Ie0ET+eMmXOqjI06hAbrRjGZeso?=
 =?us-ascii?Q?3LfdMUsy+DKIGt/IAngihPPzOFQZfxfykIatsHfa2cJCaI7CC18aZXwcKkld?=
 =?us-ascii?Q?DV4R9p6PMcG4L9tQ4gWMYgTnLRjXgCFs7prkAouknXRJrVgYLoG8i1fH6PLl?=
 =?us-ascii?Q?ZZPWiHTm8xvjUZfVaCdp5jO87QSdymLepn8/sI0rEF9KEXdoqgojZVqfvjvj?=
 =?us-ascii?Q?j5jkKzTisytPdxnAmIvV6nBeIXDpvhZtpH8oRIP9KT57XZI+JSvThXDyl/2g?=
 =?us-ascii?Q?PTNFUbTp8GkAyAo6CtBYiPDct91GZcMQ8mP9XmNNm9r0iiqtynlSgC6xPXFB?=
 =?us-ascii?Q?TFoZwbSY+/MfUZZ/S+m2+h4ZTB4nEp9h8n4xEsBc06PsJljELhZG9CgzUbUp?=
 =?us-ascii?Q?5bsct7HcaL50smwTPh1aTeAuJrV3iDr1kiuFjyh1wIQUu3rttlUJTDwEdt44?=
 =?us-ascii?Q?nZDMCiB3/PxituznF5Cx7k0SRfKhyq6y2kQQgyqxVDTQfUCl3JCSSGi8dWiX?=
 =?us-ascii?Q?H6N4LTXPT3jkA9Zxf8tEt7yivCS8a8uK7vj1Q2DKGpHSZTyAmVgbyzH7Dw51?=
 =?us-ascii?Q?HupjznhWJppuhiuwBys+yrlA7UYNoTbCGBMRow1UJHfZmh6lEiMOv6qhyfv9?=
 =?us-ascii?Q?4S8KJ3MsYUVPDpCz1aAAfXmmTab8N82Z5WCNtMmF?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df48cdb4-e192-4822-21e5-08db86ac8a69
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 09:59:41.9902
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tlLmlClhFMvY3IrXlwIXw+BqecYrkk55kVDn0PUWiKGGZ2b9cc5OoSemPQeXB9KuTQa9EkCmPtpxfyIPp8G0hQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5825
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

key might contain private part of the key, so better use
kfree_sensitive to free it.

Fixes: 38320c70d282 ("[IPSEC]: Use crypto_aead and authenc in ESP")
Signed-off-by: Wang Ming <machel@vivo.com>
---
 net/ipv4/esp4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c
index ba06ed42e428..2be2d4922557 100644
--- a/net/ipv4/esp4.c
+++ b/net/ipv4/esp4.c
@@ -1132,7 +1132,7 @@ static int esp_init_authenc(struct xfrm_state *x,
 	err = crypto_aead_setkey(aead, key, keylen);
 
 free_key:
-	kfree(key);
+	kfree_sensitive(key);
 
 error:
 	return err;
-- 
2.25.1