Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0debbf68-ef69-2d1b-42d1-376c05186cbe@kernel.org>
Date:   Mon, 17 Jul 2023 12:20:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2] ACPI: video: Add backlight=native DMI quirk for Lenovo
 Ideapad Z470
Content-Language: en-US
To:     rafael@kernel.org
Cc:     linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
References: <20230418064200.24303-1-jirislaby@kernel.org>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20230418064200.24303-1-jirislaby@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

this has been likely lost. Should I resend?

Thanks.

On 18. 04. 23, 8:42, Jiri Slaby (SUSE) wrote:
> The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using
> acpi_video for backlight control. But this is not functional on this
> model.
> 
> Add a DMI quirk to use the native backlight interface which works.
> 
> Link: https://bugzilla.suse.com/show_bug.cgi?id=1208724
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> 
> Notes:
>      [v2] fix authorship
> 
>   drivers/acpi/video_detect.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 69ef2d9710c2..af5cea005f54 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>   		DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"),
>   		},
>   	},
> +	{
> +	 /* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */
> +	 .callback = video_detect_force_native,
> +	 /* Lenovo Ideapad Z470 */
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"),
> +		},
> +	},
>   	{
>   	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */
>   	 .callback = video_detect_force_native,

-- 
js
suse labs