Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
To:     Dave Hansen <dave.hansen@linux.intel.com>,
        Borislav Petkov <bp@alien8.de>
Cc:     x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Juergen Gross <jgross@suse.com>,
        Andi Shyti <andi.shyti@linux.intel.com>,
        Marek =?ISO-8859-1?Q?Marczykowski=2DG=F3recki?= 
        <marmarek@invisiblethingslab.com>,
        "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify
 mask
Date:   Mon, 17 Jul 2023 11:42:13 +0200
Message-ID: <21945539.EfDdHjke4D@jkrzyszt-mobl2.ger.corp.intel.com>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173,
 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316
In-Reply-To: <20230710080519.GAZKu7v2N/eK/jYXPL@fat_crate.local>
References: <20230710073613.8006-2-janusz.krzysztofik@linux.intel.com>
 <20230710080519.GAZKu7v2N/eK/jYXPL@fat_crate.local>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Hi Borislav,

On Monday, 10 July 2023 10:05:19 CEST Borislav Petkov wrote:
> On Mon, Jul 10, 2023 at 09:36:14AM +0200, Janusz Krzysztofik wrote:
> > Assume that adding _PAGE_PAT to _PAGE_CHG_MASK doesn't break pte_modify()
> > and its users, and go for it.  Also, add _PAGE_PAT_LARGE to
> 
> That's my only worry.

Let me remind you that v1 was free of concerns on potential breakage of 
pte_modify().  I can update its commit description as Dave requested and 
resubmit if you confirm that it will be reconsidered as a potential solution.

Thanks,
Janusz

> 
> I'd suggest we queue this but not send it to Linus now. Instead, let it
> cook in linux-next for the whole 6.5 release cycle so that it can get at
> least *some* testing.
> 
> Because if we send it now and something else obscure breaks in a weird
> way in his tree, then we'll have to scramble to fix that too and it'll
> be one helluva mess.
> 
> Dave?
> 
>